From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=cGAmrh5S; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Fri, 20 Sep 2019 03:24:40 -0700 Received: by mail-wm1-f68.google.com with SMTP id x2so1865810wmj.2 for ; Fri, 20 Sep 2019 03:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Nt8rv+/W0xMtxaVOIAUE5KsfixZqyTNfOS/EYInt+Nk=; b=cGAmrh5SkUwuKGJlk4bTdlH5Co8xzBRkXC5RwSkVA32XBAkPkKxyhceku5BhnkNamd 7sA8SrYEKn+smYbPUjj5c5YVT7kBHXY4SO2f4K6aYlxXObjjPJYbZV3MuS+HdTZY1vKd C3CqMGJ3kUPO/eRwu35f4Zakc20QLdtHx/m89WZ4byFVK+fMRsy+rAf7sLGM5lpMe08Q rsqGpDhPit1OVpUvM2Zi66a9HcdbqGrtHVav4AIUPU/jzmjpJaCxMkCLSBL9nEAaYObt QXp2tiKslwegW2uebBx5A5zNy+NfRzI3Yd+kPO7FodwUNCWB6z/wbVEQ3BQpS9btRmGf iiPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Nt8rv+/W0xMtxaVOIAUE5KsfixZqyTNfOS/EYInt+Nk=; b=tpXqn1UolabUGuzzLA81aSB9y+WYCrEsEmy7wl0byre0DpzzbkrDQPBEtQregxd99F 6l4KXEN/qEDyNcYpJPcBZPdhTDtYv+ozXren+nTKizr9uc6clutv5hKrlnKN7DNYqVwa 7Gk9HNPMT+Sdq+meQnQyLHCO+kw3XyuevOd531saaV2639+lQgop0SrkrbX0bI7Vtsne 9IAkccFOzZ5SQGVJMIHFxrNALZAdwlKPNEFkZ2CT/ng4ECeKcaiXSc7j4yH7ZOHnmSk+ xXvQF20CaDDtc2krXq6xZW3DMNG3dsJhqtw/E7ukanks/UcaVnL33NQ+5qBclWvAvmNk QFbg== X-Gm-Message-State: APjAAAVtfRmQwbBjWspXq1BmKigWYgL8LWqZiwo7zSF/P4aZY9nyZDCs jtnq4Ifrnw3wDuw1hAMBkBLvjg== X-Google-Smtp-Source: APXvYqzd43HM3/6+n0MIlCAD6NAyvhRT4E37Gltcfkzaingk3lUfzHlBAfko0aVJMQawUVrN4F4r7g== X-Received: by 2002:a1c:48d5:: with SMTP id v204mr2990096wma.109.1568975078857; Fri, 20 Sep 2019 03:24:38 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n17sm1718101wrp.37.2019.09.20.03.24.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2019 03:24:38 -0700 (PDT) Date: Fri, 20 Sep 2019 11:24:36 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 6/7] OvmfPkg: strip trailing whitespace Message-ID: <20190920102436.GD28454@bivouac.eciton.net> References: <20190919180625.29150-1-leif.lindholm@linaro.org> <20190919180625.29150-7-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 20, 2019 at 08:13:36AM +0200, Laszlo Ersek wrote: > On 09/19/19 20:06, Leif Lindholm wrote: > > Cc: Jordan Justen > > Cc: Laszlo Ersek > > Cc: Ard Biesheuvel > > Cc: Anthony Perard > > Cc: Julien Grall > > Cc: David Woodhouse > > Signed-off-by: Leif Lindholm > > --- > > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 4 ++-- > > OvmfPkg/AcpiPlatformDxe/Xen.c | 8 ++++---- > > OvmfPkg/AcpiTables/Facs.aslc | 6 +++--- > > OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr | 18 +++++++++--------- > > OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h | 4 ++-- > > OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h | 4 ++-- > > OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen.h | 4 ++-- > > OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h | 2 +- > > OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h | 2 +- > > OvmfPkg/Include/IndustryStandard/Xen/io/ring.h | 34 +++++++++++++++++----------------- > > OvmfPkg/Include/IndustryStandard/Xen/memory.h | 4 ++-- > > OvmfPkg/Include/IndustryStandard/Xen/xen-compat.h | 4 ++-- > > OvmfPkg/Include/IndustryStandard/Xen/xen.h | 10 +++++----- > > OvmfPkg/Include/Register/QemuSmramSaveStateMap.h | 2 +- > > OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c | 12 ++++++------ > > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 2 +- > > OvmfPkg/Library/LockBoxLib/LockBoxLib.c | 2 +- > > OvmfPkg/Library/LockBoxLib/LockBoxLib.h | 2 +- > > OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.c | 4 ++-- > > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 2 +- > > OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c | 2 +- > > OvmfPkg/PlatformPei/Xen.c | 2 +- > > OvmfPkg/SataControllerDxe/ComponentName.c | 6 +++--- > > OvmfPkg/SataControllerDxe/SataController.c | 214 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------------------- > > OvmfPkg/SataControllerDxe/SataController.h | 208 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------------------------- > > (did you forget --stat-graph-width=20?) Hmm... *scratches head* First of all, I saw that before sending out and didn't even reflect on it. Clearly past git-send-email-o-clock. Secondly, I have [diff] statGraphWidth = 20 in .git/config from running SetupGit.py. Oh, rubbish. From git-diff manpage: --- The width of the graph part can be limited by using --stat-graph-width= (affects all commands generating a stat graph) or by setting diff.statGraphWidth= (does not affect git format-patch). --- I had missed that bit. So yeah, that setting in SetupGit.py is completely meaningless. (Why would you give those two different code paths?!?) Which given we already can't set --stat ... Do you think it might be a good idea to set up a few standard aliases? > > OvmfPkg/SataControllerDxe/SataControllerDxe.inf | 6 +++--- > > OvmfPkg/Sec/SecMain.c | 34 +++++++++++++++++----------------- > > 27 files changed, 301 insertions(+), 301 deletions(-) > > I've checked this patch with "git show -b" (--> nothing) and "git show > --word-diff" (--> output consists purely of context). > > Reviewed-by: Laszlo Ersek Thanks! / Leif