From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=a09JbYwW; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Fri, 20 Sep 2019 10:04:35 -0700 Received: by mail-wm1-f68.google.com with SMTP id i16so3268707wmd.3 for ; Fri, 20 Sep 2019 10:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gMqpcVdqcQeqIjl9ghg98qmIifwn7aNXCKCJa7QGxY0=; b=a09JbYwWlo/DyGblxvfn7Dn0sngJts/2mWqooptMyu2QbU4kbTARFVT+/LoNjaTbz/ Sz6hvJMnW/dscHWSe2HgrjTN0WkxMOdxixwdSaXt9vYRav8V6JR0oIWM6xXLFg29ocbw xQ9/h6Xai/TkONTnyTXynzQvET2lympAxF9BdA+LmQ6zKHP8t3ZWkoC4VTKHfq7navg8 4RU8yoEAnmfj0DjwwEXRJs0VV0Tjr+Uf4aJ6tMdDCLlAl+GltEGCu9z5PmAqk9AN1RV5 EXB+DZYOSxLnKXcTM9W3YOzGa62LvVXl3pdKoXSer6kuToU4CUA/B1fUQjuBhXoQpsrw 12Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gMqpcVdqcQeqIjl9ghg98qmIifwn7aNXCKCJa7QGxY0=; b=iypZ2LeBAUTxBRVPnaTSbBV82DQqi7lQDQEv0hSwcW+wCUk2AlQSyT8X8M3Ktp2ZR+ 4c+5sbFQ5B636Z+CdXy+nHHhN8AaH41jA8jGqEdFQYEtzDV71Wyh2XKk1iHE0GJtiHO5 LSH7TGXWOPs90SQB9T59JKOoQSawJylL4epF3rm5ngp+PNL5mPaRSoFv06FCkEzLOFI8 5SABcX18VKzv0rDzc9oNbuAGzv674Mymwf/jfnAqpWUwIB4My93DVwfTZDd31Syzs68U Ir3hdkkJFl8yuUlnRKSVs76da3DkK5IWr3Xl78ru/3JeRgP7tU4FmzxQRvSt994L8Fqp +AmA== X-Gm-Message-State: APjAAAXtoj/U/otXAS5DfvtO0MBSDsmwdcbzcct/WmivA/2VcZD+ziTE 7WaqRifYSIWTzAiYm5YGvAZi9A== X-Google-Smtp-Source: APXvYqxM8JOSbijAu+1zjVtDTdyaVq5rI5n9c1nx+vvtCdwyLSJtEs82Zh6PIiQjAkiAGh7ZQUb9cw== X-Received: by 2002:a1c:a5c3:: with SMTP id o186mr4491015wme.51.1568999074124; Fri, 20 Sep 2019 10:04:34 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o19sm3568900wro.50.2019.09.20.10.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2019 10:04:33 -0700 (PDT) Date: Fri, 20 Sep 2019 18:04:31 +0100 From: "Leif Lindholm" To: "Chang, Abner (HPS SW/FW Technologist)" Cc: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: RiscVPkg: RISC-V processor package. Message-ID: <20190920170431.GK28454@bivouac.eciton.net> References: <1567593797-26216-1-git-send-email-abner.chang@hpe.com> <1567593797-26216-2-git-send-email-abner.chang@hpe.com> <20190904175129.GO29255@bivouac.eciton.net> <20190917140318.GF28454@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 19, 2019 at 07:10:16AM +0000, Chang, Abner (HPS SW/FW Technologist) wrote: > > -----Original Message----- > > > > I personally think we need a longer-term encapsulation of libfdt > > > > that doesn't mess up the coding style. But until then, I would be > > > > much happier if you used the half measure we have in EmbeddedPkg: > > > > EmbeddedPkg/Library/FdtLib/ and EmbeddedPkg/Include/. > > > > > > We may not go this way due to everything is from OpenSBI and we don't > > > want to maintain the difference to open source OpenSBI. Just take what > > > OpenSBI provides. > > > > If libfdt was a very quickly changing project, I might agree with you. > > But it is not. It is a very simple piece of code that performs a small set of > > operations on a very well defined structured encapsulation format. > > > > So please use the one from EmbeddedPkg. On the very unlikely occurrence > > that you require functionality not provided by the version in there, we can > > update it. > > I am not sure how's compatibility between these two > libraries. However I can't agree to use EmbbedPkg one now, maybe > later once this port is got on edk2 repo. Currently we just simply > create an INF file and in which pull everything OpenSBI provides, > that is easy for us to integrate OpenSbi. We don't want to increase > complexities now. I am not saying to not adopting EmbbedPkg one, > just not for now. If the libfdt is simply what comes along with opensbi, then I can live with that for now, once opensbi becomes a submodule. The conversion to use the current EmbeddedPkg FdtLib should however be completely trivial. So I would still like to see the following *attempted* before we start considering this being included in edk2 master: - add FdtLib to RiscVOpensbiLib.inf [LibraryClasses] - delete all of the libfdt/* files from RiscVOpensbiLib.inf [Sources] - add EmbeddedPkg/EmbeddedPkg.dec to RiscVOpensbiLib.inf [Packages] / Leif