From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Liming Gao <liming.gao@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-platforms][PATCH V1 1/1] edk2-platforms: Add __pycache__ to .gitignore
Date: Tue, 24 Sep 2019 22:25:07 +0100 [thread overview]
Message-ID: <20190924212507.GO28454@bivouac.eciton.net> (raw)
In-Reply-To: <20190924205547.18156-1-michael.a.kubacki@intel.com>
On Tue, Sep 24, 2019 at 01:55:47PM -0700, Michael Kubacki wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2217
>
> Python build is enabled for some platform code leading to .pyc files
> created in __pycache__ directories. This change adds the __pycache__
> directory to a .gitignore file to allow git to ignore Python cache files.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
LGTM
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> new file mode 100644
> index 0000000000..58200d4d73
> --- /dev/null
> +++ b/.gitignore
> @@ -0,0 +1 @@
> +__pycache__/
> --
> 2.16.2.windows.1
>
prev parent reply other threads:[~2019-09-24 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 20:55 [edk2-platforms][PATCH V1 1/1] edk2-platforms: Add __pycache__ to .gitignore Kubacki, Michael A
2019-09-24 21:25 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924212507.GO28454@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox