From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=pXfqGdYC;
 spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66])
 by groups.io with SMTP; Tue, 24 Sep 2019 14:25:12 -0700
Received: by mail-wm1-f66.google.com with SMTP id i16so1953466wmd.3
        for <devel@edk2.groups.io>; Tue, 24 Sep 2019 14:25:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=vE+QL8QO40XcMash/P1Gpvvr6gfg6ZcS0oAOf0izEeg=;
        b=pXfqGdYCZHk+BTIyF4vF1HiSR5AhhqJTcROzG4AXZyhltcXUeZsRT5OAFReNX3gr1E
         ZDAUicqSldFiqKIiSN0PpI+3PrH7I2Pl5DMptv8+Rn0rFZnYZ4OfTxiOel+g2NKTqFFB
         nvFelSr12IaPwDVyTkSbFl96qTrRX4oPOtZ5YMdas33eg3w4Ob0CB9b9wg98fk/etgF7
         ua/iQPJfnYuJArBReJQQr+A2aL6XDUp/Rtnm1nMKw9/ygqk7J3xF39VC6bL4SphaQZDm
         y2tfX9P4UsYmg7er01JX3lGmAdZ8ooQPvRyqhwQ3q2aF9orHuu43o2DYYwzoSBuNZ9ZE
         K3Hg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=vE+QL8QO40XcMash/P1Gpvvr6gfg6ZcS0oAOf0izEeg=;
        b=Z0o2LGTpyBdssL4VIJ8aUvTCBjOBl2aWC9GHl7lCepe6ottiYFVg+WWP3oEncBs/3W
         lg9j5Wxg089fjl1P7NL3Bglw4ZOJS+8l2zKKhJO6yjzEzMWLN4UfZloTJbXcpNAhHUcO
         xZEJKXkAMD9qNfamuFQMk0y4nawZrQwYjJ4E1/PMbTAqrl/cPUBGmVw3FTy3mfPuDIMZ
         TZ+QlGIePxnP8I2t0WBxxmz1nj4OqUoIbgPzr39hoGG98la0kZeylodzD55AvVrvfApd
         gSM5FFuwV9Ujitlk/pUCPo0I6ZnfLiBz+Xhnmc1uHmOZY/cjyjBT8M08ZGq+ON8i53xz
         jlAA==
X-Gm-Message-State: APjAAAXaMg6ktLeV0NQOX1ib4HlSqMOgOF4oE5iSBUlrgv4ZUSghUfNI
	kdaMCsGzEuKGomQHCtcaUj7F0A==
X-Google-Smtp-Source: APXvYqxG0dZck5lEVU96xXYO2/swFp6g6pauVxWE5eG4XXtQz4nj3Di4FMMtGiUeN8bxd+BWHu+4jw==
X-Received: by 2002:a7b:c7c5:: with SMTP id z5mr2552836wmk.37.1569360310300;
        Tue, 24 Sep 2019 14:25:10 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id a71sm679353wma.43.2019.09.24.14.25.09
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 24 Sep 2019 14:25:09 -0700 (PDT)
Date: Tue, 24 Sep 2019 22:25:07 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Liming Gao <liming.gao@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-platforms][PATCH V1 1/1] edk2-platforms: Add __pycache__ to .gitignore
Message-ID: <20190924212507.GO28454@bivouac.eciton.net>
References: <20190924205547.18156-1-michael.a.kubacki@intel.com>
MIME-Version: 1.0
In-Reply-To: <20190924205547.18156-1-michael.a.kubacki@intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Sep 24, 2019 at 01:55:47PM -0700, Michael Kubacki wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2217
> 
> Python build is enabled for some platform code leading to .pyc files
> created in __pycache__ directories. This change adds the __pycache__
> directory to a .gitignore file to allow git to ignore Python cache files.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>

LGTM
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> new file mode 100644
> index 0000000000..58200d4d73
> --- /dev/null
> +++ b/.gitignore
> @@ -0,0 +1 @@
> +__pycache__/
> -- 
> 2.16.2.windows.1
>