From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=nSBCqdxQ; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by groups.io with SMTP; Tue, 24 Sep 2019 17:17:54 -0700 Received: by mail-wr1-f67.google.com with SMTP id y19so4094803wrd.3 for ; Tue, 24 Sep 2019 17:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jnQwu4cYHsTljnyZb1eMR2ONxkfmW/vJ1SKegPZjS2Y=; b=nSBCqdxQT6kIIAu4jAH+qPooZ5xnHky9BieJHTVhJEUistThiqaWeolTH5onq8/F6M oZ2FcDIOjUf5nMoi8QxkCqAAcJVE3B39pH5UKeR3+TIe/b9O9GpPcEvjCLGbPEL0N+4G 8D6zG/KTVPWnP+H4bUU2rysuBsibtBzgCU3BydMEQzo5WNUBigd+UZ8M/y5WBuEW2bPN qsYdJYkSF60GYHO83RX7hC1h/FKCGlSEjYjlnnECIKrOdKCyVulAlqmOUHkWGqv2s22/ R/1Pd1uFp4NAfLVkm5IlSD42tXmSiwt1ij10hbdCDAUWrzoCQhoKG4DR0S9K3fGqvnfG 3ptA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jnQwu4cYHsTljnyZb1eMR2ONxkfmW/vJ1SKegPZjS2Y=; b=NYauUV4SM1/GbHU2l7edqYVv1t/dlcJPQWguUsmSaTHbSYjubThwOXN0PlRl19Nf87 RhKfnsupNtuc7NpN+aofBO7K1bQdDAAbIGLV1/Kyv27YsflzYnNK2kPG/hF0qo4ppuKm jj4oQtYL1liDHHXM7Hddhhcs4C5liyZ2fCsmPAMjw6LLn6jtl7TdMKtOh2TmYW/9NGDf rO1tThh1y/n5SGZsX1AaRgX+CXj+fNMHvmSs/qWhgG4TXBKMPzrrr8WTo8DlEOEmg9/4 0jpHS/dJ8Pr19Qy6wBTtDXqyOK1lKFPPniMdpCqiWHvLIC0xzua712OwYNq6PNvsiRU6 jnCQ== X-Gm-Message-State: APjAAAVxkZdgO+4Dl4kIcHjibVKQMQGN1mBNh6jEgpPvME3vkP91PnIp o09DghI4u3xhGB1dn/NAECPlvqXLijulOw== X-Google-Smtp-Source: APXvYqzTT41Vy0UWBAU/lc5ykQOzKLRP/GKSzjHskoVvL8B7MZaCQB+k+qx+YdZ/NwlO65nPpGRvWA== X-Received: by 2002:a5d:4611:: with SMTP id t17mr5393720wrq.135.1569370672472; Tue, 24 Sep 2019 17:17:52 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y3sm3841874wrw.83.2019.09.24.17.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2019 17:17:51 -0700 (PDT) Date: Wed, 25 Sep 2019 01:17:50 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, liming.gao@intel.com Cc: Michael D Kinney Subject: Re: [edk2-devel] [Patch] MdePkg Base.h: Define STATIC_ASSERT macro as empty for EBC arch Message-ID: <20190925001750.GP28454@bivouac.eciton.net> References: <20190924150519.10304-1-liming.gao@intel.com> MIME-Version: 1.0 In-Reply-To: <20190924150519.10304-1-liming.gao@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 24, 2019 at 11:05:19PM +0800, Liming Gao wrote: > EBC compiler doesn't support C11 static_assert macro. > So, define STATIC_ASSERT as empty to pass EBC arch build. > STATIC_ASSERT macro is introduced @204ae9da230ecbf0910c21acac7aa5d5e8cbb8d0 > > Cc: Michael D Kinney > Signed-off-by: Liming Gao > --- > MdePkg/Include/Base.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h > index ed85b98318..70e4d8daf1 100644 > --- a/MdePkg/Include/Base.h > +++ b/MdePkg/Include/Base.h > @@ -799,12 +799,15 @@ typedef UINTN *BASE_LIST; > @param Message Raised compiler diagnostic message when expression is false. > > **/ > -#ifdef _MSC_EXTENSIONS > +#ifdef MDE_CPU_EBC > + #define STATIC_ASSERT(Expression, Message) > +#elif _MSC_EXTENSIONS > #define STATIC_ASSERT static_assert > #else > #define STATIC_ASSERT _Static_assert > #endif > > + Please delete this spurious added blank line. With that: Reviewed-by: Leif Lindholm > // > // Verify that ProcessorBind.h produced UEFI Data Types that are compliant with > // Section 2.3.1 of the UEFI 2.3 Specification. > -- > 2.13.0.windows.1 > > > >