From: "Supreeth Venkatesh" <supreeth.venkatesh@arm.com>
To: devel@edk2.groups.io
Cc: eric.jin@intel.com, Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Subject: [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience.
Date: Wed, 25 Sep 2019 18:51:42 -0500 [thread overview]
Message-ID: <20190925235143.33855-1-supreeth.venkatesh@arm.com> (raw)
For users, who operate the machine remotely through serial console on
some platforms, the test prompt message shown "System will shut down (or
cold reset) after 1 second..." is misleading, as the reset may not be
automatic.
This patch addresses the issue by adding a note "Note: On some
platforms, you may have to manually turn on the System again after few
seconds...".
This fixes bug 1623.
(https://bugzilla.tianocore.org/show_bug.cgi?id=1623)
Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
---
.../BlackBoxTest/MiscRuntimeServicesBBTestFunction.c | 4 +++-
.../BlackBoxTest/MiscRuntimeServicesBBTestStress.c | 6 ++++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
index 80e8297d..b4ebb806 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
@@ -371,7 +371,9 @@ BBTestResetSystemManualTest (
// And the stall a second is required to make sure the recovery data has
// been written into the storage device.
//
- SctPrint (L"System will shut down (or cold reset) after 1 second...");
+ SctPrint (L"System may shut down (or cold reset) after 1 second...");
+ SctPrint (L"Note: On some platforms, you may have to manually turn\
+ on the System again after few seconds...");
gtBS->Stall (1000000);
OldTpl = gtBS->RaiseTPL (TplArray[Index]);
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
index 1ad732a0..ef0e1148 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
@@ -374,7 +374,9 @@ BBTestResetSystemManualStressTest (
//
// Print out some information to avoid the user thought it is an error
//
- SctPrint (L"System will shut down (or cold reset) after 1 second...");
+ SctPrint (L"System may shut down (or cold reset) after 1 second...");
+ SctPrint (L"Note: On some platforms, you may have to manually turn\
+ on the System again after few seconds...");
gtBS->Stall (1000000);
OldTpl = gtBS->RaiseTPL (TplArray[Index]);
@@ -404,4 +406,4 @@ ManualStressTestStep2:
}
return EFI_SUCCESS;
-}
\ No newline at end of file
+}
--
2.17.1
next reply other threads:[~2019-09-25 23:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 23:51 Supreeth Venkatesh [this message]
2019-09-25 23:51 ` [edk2-test][PATCH v1 1/1] SctPkg: Fix issue with the shell script Supreeth Venkatesh
2019-09-26 5:36 ` [edk2-devel] " Eric Jin
2019-09-26 5:38 ` [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience Eric Jin
[not found] ` <15C7E669089EA5D2.20538@groups.io>
2019-09-27 3:12 ` Eric Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925235143.33855-1-supreeth.venkatesh@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox