From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: supreeth.venkatesh@arm.com) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by groups.io with SMTP; Wed, 25 Sep 2019 16:51:59 -0700 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C69E1000; Wed, 25 Sep 2019 16:51:58 -0700 (PDT) Received: from u201365.usa.Arm.com (supven01-thinkstation-p720.austin.arm.com [10.118.28.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 058173F67D; Wed, 25 Sep 2019 16:51:58 -0700 (PDT) From: "Supreeth Venkatesh" To: devel@edk2.groups.io Cc: eric.jin@intel.com, Supreeth Venkatesh Subject: [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience. Date: Wed, 25 Sep 2019 18:51:42 -0500 Message-Id: <20190925235143.33855-1-supreeth.venkatesh@arm.com> X-Mailer: git-send-email 2.17.1 For users, who operate the machine remotely through serial console on some platforms, the test prompt message shown "System will shut down (or cold reset) after 1 second..." is misleading, as the reset may not be automatic. This patch addresses the issue by adding a note "Note: On some platforms, you may have to manually turn on the System again after few seconds...". This fixes bug 1623. (https://bugzilla.tianocore.org/show_bug.cgi?id=1623) Signed-off-by: Supreeth Venkatesh --- .../BlackBoxTest/MiscRuntimeServicesBBTestFunction.c | 4 +++- .../BlackBoxTest/MiscRuntimeServicesBBTestStress.c | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c index 80e8297d..b4ebb806 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c @@ -371,7 +371,9 @@ BBTestResetSystemManualTest ( // And the stall a second is required to make sure the recovery data has // been written into the storage device. // - SctPrint (L"System will shut down (or cold reset) after 1 second..."); + SctPrint (L"System may shut down (or cold reset) after 1 second..."); + SctPrint (L"Note: On some platforms, you may have to manually turn\ + on the System again after few seconds..."); gtBS->Stall (1000000); OldTpl = gtBS->RaiseTPL (TplArray[Index]); diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c index 1ad732a0..ef0e1148 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c @@ -374,7 +374,9 @@ BBTestResetSystemManualStressTest ( // // Print out some information to avoid the user thought it is an error // - SctPrint (L"System will shut down (or cold reset) after 1 second..."); + SctPrint (L"System may shut down (or cold reset) after 1 second..."); + SctPrint (L"Note: On some platforms, you may have to manually turn\ + on the System again after few seconds..."); gtBS->Stall (1000000); OldTpl = gtBS->RaiseTPL (TplArray[Index]); @@ -404,4 +406,4 @@ ManualStressTestStep2: } return EFI_SUCCESS; -} \ No newline at end of file +} -- 2.17.1