[edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience.

[edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience.

[Supreeth Venkatesh]

For users, who operate the machine remotely through serial console on
some platforms, the test prompt message shown "System will shut down (or
cold reset) after 1  second..." is misleading, as the reset may not be
automatic.

This patch addresses the issue by adding a note "Note: On some
platforms, you may have to manually turn on the System again after few
seconds...".
This fixes bug 1623.
(https://bugzilla.tianocore.org/show_bug.cgi?id=1623)

Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
---
 .../BlackBoxTest/MiscRuntimeServicesBBTestFunction.c        | 4 +++-
 .../BlackBoxTest/MiscRuntimeServicesBBTestStress.c          | 6 ++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
index 80e8297d..b4ebb806 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
@@ -371,7 +371,9 @@ BBTestResetSystemManualTest (
     // And the stall a second is required to make sure the recovery data has
     // been written into the storage device.
     //
-    SctPrint (L"System will shut down (or cold reset) after 1 second...");
+    SctPrint (L"System may shut down (or cold reset) after 1 second...");
+    SctPrint (L"Note: On some platforms, you may have to manually turn\
+  		      on the System again after few seconds...");
     gtBS->Stall (1000000);
 
     OldTpl = gtBS->RaiseTPL (TplArray[Index]);
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
index 1ad732a0..ef0e1148 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
@@ -374,7 +374,9 @@ BBTestResetSystemManualStressTest (
       //
       // Print out some information to avoid the user thought it is an error
       //
-      SctPrint (L"System will shut down (or cold reset) after 1 second...");
+      SctPrint (L"System may shut down (or cold reset) after 1 second...");
+      SctPrint (L"Note: On some platforms, you may have to manually turn\
+    		    on the System again after few seconds...");
       gtBS->Stall (1000000);
 
       OldTpl = gtBS->RaiseTPL (TplArray[Index]);
@@ -404,4 +406,4 @@ ManualStressTestStep2:
   }
 
   return EFI_SUCCESS;
-}
\ No newline at end of file
+}
-- 
2.17.1

[edk2-test][PATCH v1 1/1] SctPkg: Fix issue with the shell script

[Supreeth Venkatesh]

Fix unintended "space" characters that were added when
IhvFirmwareManagementBBTest.efi was checked-in.

Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
---
 uefi-sct/SctPkg/CommonGenFramework.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh b/uefi-sct/SctPkg/CommonGenFramework.sh
index 83045309..779a6a44 100755
--- a/uefi-sct/SctPkg/CommonGenFramework.sh
+++ b/uefi-sct/SctPkg/CommonGenFramework.sh
@@ -313,7 +313,7 @@ then
   cp $ProcessorType/IhvUsb2HcTest.efi                        $Framework/Test/ > NUL
   cp $ProcessorType/IhviScsiInitiatorNameBBTest.efi          $Framework/Test/ > NUL
   cp $ProcessorType/IhvStorageSecurityCommandBBTest.efi      $Framework/Test/ > NUL
-..cp $ProcessorType/IhvFirmwareManagementBBTest.efi          $Framework/Test/ > NUL
+  cp $ProcessorType/IhvFirmwareManagementBBTest.efi          $Framework/Test/ > NUL
   cp $ProcessorType/IhvHIIConfigAccessBBTest.efi             $Framework/Test/ > NUL
 
   # *********************************************
-- 
2.17.1

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] SctPkg: Fix issue with the shell script

[Eric Jin]

Reviewed-by: Eric Jin <eric.jin@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Supreeth Venkatesh
Sent: Thursday, September 26, 2019 7:52 AM
To: devel@edk2.groups.io
Cc: Jin, Eric <eric.jin@intel.com>; Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Subject: [edk2-devel] [edk2-test][PATCH v1 1/1] SctPkg: Fix issue with the shell script

Fix unintended "space" characters that were added when IhvFirmwareManagementBBTest.efi was checked-in.

Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
---
 uefi-sct/SctPkg/CommonGenFramework.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh b/uefi-sct/SctPkg/CommonGenFramework.sh
index 83045309..779a6a44 100755
--- a/uefi-sct/SctPkg/CommonGenFramework.sh
+++ b/uefi-sct/SctPkg/CommonGenFramework.sh
@@ -313,7 +313,7 @@ then
   cp $ProcessorType/IhvUsb2HcTest.efi                        $Framework/Test/ > NUL
   cp $ProcessorType/IhviScsiInitiatorNameBBTest.efi          $Framework/Test/ > NUL
   cp $ProcessorType/IhvStorageSecurityCommandBBTest.efi      $Framework/Test/ > NUL
-..cp $ProcessorType/IhvFirmwareManagementBBTest.efi          $Framework/Test/ > NUL
+  cp $ProcessorType/IhvFirmwareManagementBBTest.efi          $Framework/Test/ > NUL
   cp $ProcessorType/IhvHIIConfigAccessBBTest.efi             $Framework/Test/ > NUL
 
   # *********************************************
--
2.17.1

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience.

[Eric Jin]

Reviewed-by: Eric Jin <eric.jin@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Supreeth Venkatesh
Sent: Thursday, September 26, 2019 7:52 AM
To: devel@edk2.groups.io
Cc: Jin, Eric <eric.jin@intel.com>; Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Subject: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience.

For users, who operate the machine remotely through serial console on some platforms, the test prompt message shown "System will shut down (or cold reset) after 1  second..." is misleading, as the reset may not be automatic.

This patch addresses the issue by adding a note "Note: On some platforms, you may have to manually turn on the System again after few seconds...".
This fixes bug 1623.
(https://bugzilla.tianocore.org/show_bug.cgi?id=1623)

Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
---
 .../BlackBoxTest/MiscRuntimeServicesBBTestFunction.c        | 4 +++-
 .../BlackBoxTest/MiscRuntimeServicesBBTestStress.c          | 6 ++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
index 80e8297d..b4ebb806 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServi
+++ ces/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
@@ -371,7 +371,9 @@ BBTestResetSystemManualTest (
     // And the stall a second is required to make sure the recovery data has
     // been written into the storage device.
     //
-    SctPrint (L"System will shut down (or cold reset) after 1 second...");
+    SctPrint (L"System may shut down (or cold reset) after 1 second...");
+    SctPrint (L"Note: On some platforms, you may have to manually turn\
+  		      on the System again after few seconds...");
     gtBS->Stall (1000000);
 
     OldTpl = gtBS->RaiseTPL (TplArray[Index]); diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
index 1ad732a0..ef0e1148 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServi
+++ ces/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
@@ -374,7 +374,9 @@ BBTestResetSystemManualStressTest (
       //
       // Print out some information to avoid the user thought it is an error
       //
-      SctPrint (L"System will shut down (or cold reset) after 1 second...");
+      SctPrint (L"System may shut down (or cold reset) after 1 second...");
+      SctPrint (L"Note: On some platforms, you may have to manually turn\
+    		    on the System again after few seconds...");
       gtBS->Stall (1000000);
 
       OldTpl = gtBS->RaiseTPL (TplArray[Index]); @@ -404,4 +406,4 @@ ManualStressTestStep2:
   }
 
   return EFI_SUCCESS;
-}
\ No newline at end of file
+}
--
2.17.1

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add statement to improve user experience.

[Eric Jin]

Hi Supreeth,

Sorry. I forget to check the patch format. Tab character is used in the patch.
Could you please to fix them? With that, please commit to repo. Thanks.

Best Regards
Eric

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Eric Jin
> Sent: Thursday, September 26, 2019 1:39 PM
> To: devel@edk2.groups.io; supreeth.venkatesh@arm.com
> Subject: Re: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices:
> Add statement to improve user experience.
> 
> Reviewed-by: Eric Jin <eric.jin@intel.com>
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Supreeth Venkatesh
> Sent: Thursday, September 26, 2019 7:52 AM
> To: devel@edk2.groups.io
> Cc: Jin, Eric <eric.jin@intel.com>; Supreeth Venkatesh
> <supreeth.venkatesh@arm.com>
> Subject: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add
> statement to improve user experience.
> 
> For users, who operate the machine remotely through serial console on
> some platforms, the test prompt message shown "System will shut down (or
> cold reset) after 1  second..." is misleading, as the reset may not be
> automatic.
> 
> This patch addresses the issue by adding a note "Note: On some platforms,
> you may have to manually turn on the System again after few seconds...".
> This fixes bug 1623.
> (https://bugzilla.tianocore.org/show_bug.cgi?id=1623)
> 
> Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> ---
>  .../BlackBoxTest/MiscRuntimeServicesBBTestFunction.c        | 4 +++-
>  .../BlackBoxTest/MiscRuntimeServicesBBTestStress.c          | 6 ++++--
>  2 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black
> BoxTest/MiscRuntimeServicesBBTestFunction.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black
> BoxTest/MiscRuntimeServicesBBTestFunction.c
> index 80e8297d..b4ebb806 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black
> BoxTest/MiscRuntimeServicesBBTestFunction.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServi
> +++ ces/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c
> @@ -371,7 +371,9 @@ BBTestResetSystemManualTest (
>      // And the stall a second is required to make sure the recovery data has
>      // been written into the storage device.
>      //
> -    SctPrint (L"System will shut down (or cold reset) after 1 second...");
> +    SctPrint (L"System may shut down (or cold reset) after 1 second...");
> +    SctPrint (L"Note: On some platforms, you may have to manually turn\
> +  		      on the System again after few seconds...");
Tab is used.

>      gtBS->Stall (1000000);
> 
>      OldTpl = gtBS->RaiseTPL (TplArray[Index]); diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black
> BoxTest/MiscRuntimeServicesBBTestStress.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black
> BoxTest/MiscRuntimeServicesBBTestStress.c
> index 1ad732a0..ef0e1148 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/Black
> BoxTest/MiscRuntimeServicesBBTestStress.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServi
> +++ ces/BlackBoxTest/MiscRuntimeServicesBBTestStress.c
> @@ -374,7 +374,9 @@ BBTestResetSystemManualStressTest (
>        //
>        // Print out some information to avoid the user thought it is an error
>        //
> -      SctPrint (L"System will shut down (or cold reset) after 1 second...");
> +      SctPrint (L"System may shut down (or cold reset) after 1 second...");
> +      SctPrint (L"Note: On some platforms, you may have to manually turn\
> +    		    on the System again after few seconds...");
Tab is used.

>        gtBS->Stall (1000000);
> 
>        OldTpl = gtBS->RaiseTPL (TplArray[Index]); @@ -404,4 +406,4 @@
> ManualStressTestStep2:
>    }
> 
>    return EFI_SUCCESS;
> -}
> \ No newline at end of file
> +}
> --
> 2.17.1
> 
> 
> 
> 
> 
>