From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=R3lnLiRY;
 spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66])
 by groups.io with SMTP; Thu, 26 Sep 2019 15:24:32 -0700
Received: by mail-wm1-f66.google.com with SMTP id m18so4148552wmc.1
        for <devel@edk2.groups.io>; Thu, 26 Sep 2019 15:24:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=A1/0GHSofdFBiRVGilS+eMu5aa+EL0wg1aB1VN4rTeM=;
        b=R3lnLiRY2ChkB6tTMwVd81l/99cKhCNjDlrAhJZOW0XaLuf1xraZGvEScJejO5Sp5c
         1krADulxH3/ngXGBTuCFdRWZqLlfE0SMkrh54l1wgd5hrmRDMA4SE2a9KReXtGcWDJma
         S07opHVV1mNGkfa3vfp4qvjHvQCw5F6qZmhBqJS3ChH3JwcwSjKYzRedJYEeIR45Kr6L
         fDa/TWmMuLCPD5Z1Ls7ldwGaN+2DBpVhsihVuxFj/mbB+MV3QwaXuC7YrT3PSZa0asRJ
         0jJSHsQQeIp9Nuh1dcAD0DaDlSMj85Ow1Wb1g3ETiVEuTtu+P0wEi71Nkz1OEZ6Ot2Pa
         lZ7Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=A1/0GHSofdFBiRVGilS+eMu5aa+EL0wg1aB1VN4rTeM=;
        b=IvhhDoTLiHe7kCn7Of1dK4k3CaNQ3opQycmY9tNss3bWVS9ItHjLwSLxfrj+4vdJjj
         ID/unTEi8egNBpkc/p4S4OAyppB/4eLPjAJpVfbDWC8S42HDnvMM29YQqpkJ4oM1910H
         B0Ms00j5hKSAwFsgyheOv4MzAeMHuiMdtkC21KuwKhO5j7vTsNZ+fgvJhDdPRBh0wHkf
         1AGTAFJD4T8hT/vPnb0LSXruZqeUsm8zATV5oaB9FNzldL9dNlkwHX6KCVhomw9FC2Os
         GK5hgnTmu1Q2Ar+YtsHNFmsF7PkG4Vs9Z6Sfc/CvGvUmWziK2aoQtm6BmcflZ4Xh0AXs
         nyTQ==
X-Gm-Message-State: APjAAAVOPSjDj4gYpwLpBCuMKM9vIaX5rDqTMDTnKcHKCNXC0ClWaMMX
	MegWoe09bPMH1Ts6tUOdpngHuDqrTsxdpw==
X-Google-Smtp-Source: APXvYqz3PP8K9lnunlQD4OB+qK5gHP/VFnBV1gk47VuHUYZgH9hZ3ZPMM7mhWLqFJVtKObX9rk12iA==
X-Received: by 2002:a1c:1a4b:: with SMTP id a72mr4728266wma.44.1569536670439;
        Thu, 26 Sep 2019 15:24:30 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id u10sm1621509wrg.55.2019.09.26.15.24.29
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 26 Sep 2019 15:24:29 -0700 (PDT)
Date: Thu, 26 Sep 2019 23:24:28 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, abner.chang@hpe.com
Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 27/29] edk2-staging/RISC-V-V2: Add submodule
Message-ID: <20190926222428.GB25504@bivouac.eciton.net>
References: <1569198715-31552-1-git-send-email-abner.chang@hpe.com>
 <1569198715-31552-29-git-send-email-abner.chang@hpe.com>
MIME-Version: 1.0
In-Reply-To: <1569198715-31552-29-git-send-email-abner.chang@hpe.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Sep 23, 2019 at 08:31:53AM +0800, Abner Chang wrote:
> Add submodule opensbi under RiscVPkg. The current supported opensbi
> version for RISC-V edk2 port is commit ID:ce228ee (tags/v0.4).
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> ---
>  .gitmodules      | 16 ++++++++++------
>  RiscVPkg/opensbi |  1 +
>  2 files changed, 11 insertions(+), 6 deletions(-)
>  create mode 160000 RiscVPkg/opensbi
> 
> diff --git a/.gitmodules b/.gitmodules
> index 508f0c1..6d3e28c 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -1,6 +1,10 @@
> -[submodule "CryptoPkg/Library/OpensslLib/openssl"]
> -	path = CryptoPkg/Library/OpensslLib/openssl
> -	url = https://github.com/openssl/openssl
> -[submodule "SoftFloat"]
> -	path = ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> -	url = https://github.com/ucb-bar/berkeley-softfloat-3.git
> +[submodule "CryptoPkg/Library/OpensslLib/openssl"]
> +	path = CryptoPkg/Library/OpensslLib/openssl
> +	url = https://github.com/openssl/openssl
> +[submodule "SoftFloat"]
> +	path = ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> +	url = https://github.com/ucb-bar/berkeley-softfloat-3.git

Can you investigate why the pre-existing modules are deleted and
re-added as part of this patch?

Other than that, this is all good.

/
    Leif

> +[submodule "RiscVPkg/opensbi"]
> +	path = RiscVPkg/opensbi
> +	url = https://github.com/riscv/opensbi.git
> +
> diff --git a/RiscVPkg/opensbi b/RiscVPkg/opensbi
> new file mode 160000
> index 0000000..ce228ee
> --- /dev/null
> +++ b/RiscVPkg/opensbi
> @@ -0,0 +1 @@
> +Subproject commit ce228ee0919deb9957192d723eecc8aaae2697c6
> -- 
> 2.7.4
> 
> 
> 
>