* [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support @ 2019-09-27 1:08 Gao, Zhichao 2019-09-27 1:12 ` Ni, Ray 0 siblings, 1 reply; 3+ messages in thread From: Gao, Zhichao @ 2019-09-27 1:08 UTC (permalink / raw) To: devel; +Cc: Jian J Wang, Hao A Wu, Ray Ni, Liming Gao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2219 First previous patch remove the VT100Plus's arrow keys' support. Add it back. The arrow keys would send ESC [A through to ESC [D. Add this support for the new introduced terminal type. Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Liming Gao <liming.gao@intel.com> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com> --- .../Universal/Console/TerminalDxe/TerminalConIn.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c index ac31f27984..f8c71f95c1 100644 --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c @@ -1670,8 +1670,12 @@ UnicodeToEfiKey ( if (TerminalDevice->TerminalType == TerminalTypePcAnsi || TerminalDevice->TerminalType == TerminalTypeVt100 || - TerminalDevice->TerminalType == TerminalTypeVtUtf8 || - TerminalDevice->TerminalType == TerminalTypeTtyTerm || + TerminalDevice->TerminalType == TerminalTypeVt100Plus || + TerminalDevice->TerminalType == TerminalTypeVtUtf8 || + TerminalDevice->TerminalType == TerminalTypeTtyTerm || + TerminalDevice->TerminalType == TerminalTypeLinux || + TerminalDevice->TerminalType == TerminalTypeXtermR6 || + TerminalDevice->TerminalType == TerminalTypeVt400 || TerminalDevice->TerminalType == TerminalTypeSCO) { switch (UnicodeChar) { case 'A': -- 2.21.0.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support 2019-09-27 1:08 [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support Gao, Zhichao @ 2019-09-27 1:12 ` Ni, Ray 2019-09-27 7:50 ` Liming Gao 0 siblings, 1 reply; 3+ messages in thread From: Ni, Ray @ 2019-09-27 1:12 UTC (permalink / raw) To: Gao, Zhichao, devel@edk2.groups.io; +Cc: Wang, Jian J, Wu, Hao A, Gao, Liming Reviewed-by: Ray Ni <ray.ni@intel.com> > -----Original Message----- > From: Gao, Zhichao <zhichao.gao@intel.com> > Sent: Thursday, September 26, 2019 6:09 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Liming > <liming.gao@intel.com> > Subject: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2219 > > First previous patch remove the VT100Plus's arrow keys' support. > Add it back. > > The arrow keys would send ESC [A through to ESC [D. Add this > support for the new introduced terminal type. > > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Hao A Wu <hao.a.wu@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com> > --- > .../Universal/Console/TerminalDxe/TerminalConIn.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > index ac31f27984..f8c71f95c1 100644 > --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > @@ -1670,8 +1670,12 @@ UnicodeToEfiKey ( > > if (TerminalDevice->TerminalType == TerminalTypePcAnsi || > TerminalDevice->TerminalType == TerminalTypeVt100 || > - TerminalDevice->TerminalType == TerminalTypeVtUtf8 || > - TerminalDevice->TerminalType == TerminalTypeTtyTerm || > + TerminalDevice->TerminalType == TerminalTypeVt100Plus || > + TerminalDevice->TerminalType == TerminalTypeVtUtf8 || > + TerminalDevice->TerminalType == TerminalTypeTtyTerm || > + TerminalDevice->TerminalType == TerminalTypeLinux || > + TerminalDevice->TerminalType == TerminalTypeXtermR6 || > + TerminalDevice->TerminalType == TerminalTypeVt400 || > TerminalDevice->TerminalType == TerminalTypeSCO) { > switch (UnicodeChar) { > case 'A': > -- > 2.21.0.windows.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support 2019-09-27 1:12 ` Ni, Ray @ 2019-09-27 7:50 ` Liming Gao 0 siblings, 0 replies; 3+ messages in thread From: Liming Gao @ 2019-09-27 7:50 UTC (permalink / raw) To: Ni, Ray, Gao, Zhichao, devel@edk2.groups.io; +Cc: Wang, Jian J, Wu, Hao A Push @e86664d2b03d0a84b8b952f3d5111424b3e9c916 >-----Original Message----- >From: Ni, Ray >Sent: Friday, September 27, 2019 9:12 AM >To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io >Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; >Gao, Liming <liming.gao@intel.com> >Subject: RE: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow >keys support > >Reviewed-by: Ray Ni <ray.ni@intel.com> > >> -----Original Message----- >> From: Gao, Zhichao <zhichao.gao@intel.com> >> Sent: Thursday, September 26, 2019 6:09 PM >> To: devel@edk2.groups.io >> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A ><hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Liming >> <liming.gao@intel.com> >> Subject: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys >support >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2219 >> >> First previous patch remove the VT100Plus's arrow keys' support. >> Add it back. >> >> The arrow keys would send ESC [A through to ESC [D. Add this >> support for the new introduced terminal type. >> >> Cc: Jian J Wang <jian.j.wang@intel.com> >> Cc: Hao A Wu <hao.a.wu@intel.com> >> Cc: Ray Ni <ray.ni@intel.com> >> Cc: Liming Gao <liming.gao@intel.com> >> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com> >> --- >> .../Universal/Console/TerminalDxe/TerminalConIn.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git >a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c >> b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c >> index ac31f27984..f8c71f95c1 100644 >> --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c >> +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c >> @@ -1670,8 +1670,12 @@ UnicodeToEfiKey ( >> >> if (TerminalDevice->TerminalType == TerminalTypePcAnsi || >> TerminalDevice->TerminalType == TerminalTypeVt100 || >> - TerminalDevice->TerminalType == TerminalTypeVtUtf8 || >> - TerminalDevice->TerminalType == TerminalTypeTtyTerm || >> + TerminalDevice->TerminalType == TerminalTypeVt100Plus || >> + TerminalDevice->TerminalType == TerminalTypeVtUtf8 || >> + TerminalDevice->TerminalType == TerminalTypeTtyTerm || >> + TerminalDevice->TerminalType == TerminalTypeLinux || >> + TerminalDevice->TerminalType == TerminalTypeXtermR6 || >> + TerminalDevice->TerminalType == TerminalTypeVt400 || >> TerminalDevice->TerminalType == TerminalTypeSCO) { >> switch (UnicodeChar) { >> case 'A': >> -- >> 2.21.0.windows.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-27 7:50 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-09-27 1:08 [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support Gao, Zhichao 2019-09-27 1:12 ` Ni, Ray 2019-09-27 7:50 ` Liming Gao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox