Re: [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev

["Leif Lindholm" <leif.lindholm@linaro.org>]

On Mon, Sep 09, 2019 at 05:53:10PM +0200, Patryk Duda wrote:
> This patch fixes missing MdioIndex copying during initialization.
> This bug appeared as inability to communicate with PHY connected
> to MDIO other than first.
> 
> Signed-off-by: Patryk Duda <pdk@semihalf.com>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as e4d3ddd7a51b.

Thanks!

> ---
>  Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> index 6cdef42391..2d2aad7e38 100644
> --- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> +++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> @@ -419,8 +419,12 @@ MvPhyInit (
>    PhyDev = AllocateZeroPool (sizeof (PHY_DEVICE));
>    PhyDev->Addr = PhySmiAddresses[PhyIndex];
>    PhyDev->Connection = PhyConnection;
> -  DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %d\n",
> -        PhyDev->Addr, PhyConnection));
> +  PhyDev->MdioIndex = MdioIndex;
> +  DEBUG ((DEBUG_INFO,
> +    "MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connection %d\n",
> +    PhyDev->MdioIndex,
> +    PhyDev->Addr,
> +    PhyConnection));
>    *OutPhyDev = PhyDev;
>  
>    DeviceIds = PcdGetPtr (PcdPhyDeviceIds);
> -- 
> 2.16.4
>