From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=t4NCsG4g; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by groups.io with SMTP; Sat, 28 Sep 2019 15:51:55 -0700 Received: by mail-wm1-f65.google.com with SMTP id i16so9463205wmd.3 for ; Sat, 28 Sep 2019 15:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bEcSmXq10LFei5ouQt0szprir9z1WAU3ObavSOq1iB8=; b=t4NCsG4g0sE83sq4L3l/lWxHh+T/MtdVfwTTKg8nVZbBtn7FPamHU7FxE5wEsMOe6V qN9IneYlxYxiiAuJnL6XTu4gQAdL8ZOt7mS9SoDm6ybCG9K3sJnxGWaZVFk8pkkb/jhi CszXp98PWZjJP+BXyCfRKdUa6hNJrugTDqylzcwm9cT9uHj/vl/rWPHkVKOWC2mHA332 hlIL66SoJIOiy84TX51FC/i6QZAW19QlXvb0sTofJ46s/IlGG88h6QxAZ0BOHQRB14i9 q97hP+cGZ2eAtJWr/hBbTvFYuVE2KEeMUJEOPnGGBPnoj/rdv2ORmfoyefeGqyCqWZDR C4Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bEcSmXq10LFei5ouQt0szprir9z1WAU3ObavSOq1iB8=; b=pV7f4ayxEYHaTbu1qN1TVRBtLJEZnWx0g6/mCJOah46NpuqobTAn6DszEWhOgZHdu1 XwHoWyHITHn43Kolwu5RP5DeOKQhBNvbXJfckyCy7mjKMzXMskvDUXhSAhH0673UXLsj d/WTUnQphUoOlUpcg7sRGCjtOiIr6xuA6HdGNgPXglIrdy8XMopQh5XArMAh/H46MXUH HtCQZcGHv6z1CX0wO+uMEuaz7SG7RaRHIVA3MvVvN50FRSeTB9WzrdBpTrvRCHk3kbhd zgDl/wsEgraYNoLzpyez9uTQel1HPoFX2sLbNE+qipKdouqyY8X29ZHzXOe+PjYpgyLp J+7g== X-Gm-Message-State: APjAAAVHRV41au+PEsgiW07Yd/FiMJtZ1fAL8DJyqvxtTs6L5OZpR0i4 t3AnvW82LVkVLWy4WWmgW3i9Fg== X-Google-Smtp-Source: APXvYqzNzQRc3rmsOZlCkb1G5nHplea6gn7ypVPm6kwmK/hVDepcIVI1BSxU1j5Y9G4jnv8BkBD6cw== X-Received: by 2002:a7b:cbd0:: with SMTP id n16mr11376351wmi.82.1569711113867; Sat, 28 Sep 2019 15:51:53 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y14sm15053639wrd.84.2019.09.28.15.51.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Sep 2019 15:51:53 -0700 (PDT) Date: Sat, 28 Sep 2019 23:51:51 +0100 From: "Leif Lindholm" To: Patryk Duda Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, mw@semihalf.com, jsd@semihalf.com Subject: Re: [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev Message-ID: <20190928225151.GV25504@bivouac.eciton.net> References: <20190909155310.30427-1-pdk@semihalf.com> MIME-Version: 1.0 In-Reply-To: <20190909155310.30427-1-pdk@semihalf.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 09, 2019 at 05:53:10PM +0200, Patryk Duda wrote: > This patch fixes missing MdioIndex copying during initialization. > This bug appeared as inability to communicate with PHY connected > to MDIO other than first. > > Signed-off-by: Patryk Duda Reviewed-by: Leif Lindholm Pushed as e4d3ddd7a51b. Thanks! > --- > Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > index 6cdef42391..2d2aad7e38 100644 > --- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > +++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > @@ -419,8 +419,12 @@ MvPhyInit ( > PhyDev = AllocateZeroPool (sizeof (PHY_DEVICE)); > PhyDev->Addr = PhySmiAddresses[PhyIndex]; > PhyDev->Connection = PhyConnection; > - DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %d\n", > - PhyDev->Addr, PhyConnection)); > + PhyDev->MdioIndex = MdioIndex; > + DEBUG ((DEBUG_INFO, > + "MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connection %d\n", > + PhyDev->MdioIndex, > + PhyDev->Addr, > + PhyConnection)); > *OutPhyDev = PhyDev; > > DeviceIds = PcdGetPtr (PcdPhyDeviceIds); > -- > 2.16.4 >