From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=n/EQUmfP;
 spf=pass (domain: linaro.org, ip: 209.85.128.45, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45])
 by groups.io with SMTP; Mon, 30 Sep 2019 13:03:35 -0700
Received: by mail-wm1-f45.google.com with SMTP id 5so823506wmg.0
        for <devel@edk2.groups.io>; Mon, 30 Sep 2019 13:03:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=34XvoZWxJoQt1kMop4CJ+Ym8oXNxPp9Lgeh/BU8KeT8=;
        b=n/EQUmfPJ1KqTjh210Loe92ZQ7yAe4DreYc8bIWGOI2wJcg+ie7Voh9SkKcOs4YmnF
         um16W/mXvbURJlyuYC1oEpaEA6dn9avpviEMusqF2YU+SSEhd38bVtjKhDbYd7ixEqGQ
         056ZgFW/orQKKzw9oghDqBUQkw04L5rkzf0Z5Ex55GoToYGa9dXXDHphpBryMvFWsD7w
         UFDS8cHuwVn65Wpmli0I47J8msnWgJtvz3gF3hTTg7JwdgrHtpUOU9G6vWBdXbO46WGf
         50NcVvaklezqfwtyje/Ia1mHs8Yum55fDmXBL0AaqCJnqyTUl55jrREOc7QWbFuRSfSF
         D/fg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=34XvoZWxJoQt1kMop4CJ+Ym8oXNxPp9Lgeh/BU8KeT8=;
        b=Hqd5enWlEiaah51w9huS5E6Xj01U9GgyqQ8aP4HZ3/9vRvX/nB4cJ91FhomeAtIUpG
         52S51eKyt+L7jqK3n8melxw+wPkKtbYhW2C/o6/guH+9KXKf9lBj0JInau3RBq+WuOiX
         m1JHDvIJy+gWZ6aXThCEK0N0RpXJuvbNiBeWprfLphGudJtuU9YOKiy3SFPtIbl+IpIu
         QrB7ZSPMtZ3/lx0CW/BiOV7YBR71TxZCQTLiPr5CBRgmAHgCFrdR7ACqXBeouGUtwIKk
         3pPv70Bw15PD/lIPgju122tdE8Fk0x9gDIuS5utOwZ07NgOqMWBAI3VTvMyV1qyVI6Wl
         PjLg==
X-Gm-Message-State: APjAAAWk6ujxdWHpl3ycTiATcSGKpIKc1nyxc5OlBkKi+I61m5w6mtWG
	MCULzlOs6DP34TGJRMZ3gr2uaobvKW8=
X-Google-Smtp-Source: APXvYqy4wJh9+Xwj5bHEVZqApyOT3LwMJ6Nb7gVwuoprAKrTVYwkkjTCQNq0ldnl5tz2hgCKkh37ZQ==
X-Received: by 2002:a1c:9d0b:: with SMTP id g11mr672305wme.22.1569873813679;
        Mon, 30 Sep 2019 13:03:33 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id w12sm22447973wrg.47.2019.09.30.13.03.32
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 30 Sep 2019 13:03:32 -0700 (PDT)
Date: Mon, 30 Sep 2019 21:03:31 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, abner.chang@hpe.com
Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 18/29] RiscVPkg/Library: Add EDK2 RISC-V OpenSBI library.
Message-ID: <20190930200331.GC25504@bivouac.eciton.net>
References: <1569198715-31552-1-git-send-email-abner.chang@hpe.com>
 <1569198715-31552-20-git-send-email-abner.chang@hpe.com>
MIME-Version: 1.0
In-Reply-To: <1569198715-31552-20-git-send-email-abner.chang@hpe.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Sep 23, 2019 at 08:31:44AM +0800, Abner Chang wrote:
> EDK2 RISC-V OpenSBI library which pull in external source files under
> RiscVPkg/opensbi to the build process.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> ---
>  .../Library/RiscVOpensbiLib/RiscVOpensbiLib.inf    | 52 ++++++++++++++++++++++
>  1 file changed, 52 insertions(+)
>  create mode 100644 RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf
> 
> diff --git a/RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf b/RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf
> new file mode 100644
> index 0000000..640ffba
> --- /dev/null
> +++ b/RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf
> @@ -0,0 +1,52 @@
> +## @file
> +# RISC-V Opensbi Library Instance.
> +#
> +#  Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> +#
> +#  SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +[Defines]
> +  INF_VERSION    = 0x0001001b
> +  BASE_NAME      = RiscVOpensbiLib
> +  FILE_GUID      = 6EF0C812-66F6-11E9-93CE-3F5D5F0DF0A7
> +  MODULE_TYPE    = BASE
> +  VERSION_STRING = 1.0
> +  LIBRARY_CLASS  = RiscVOpensbiLib
> +
> +[Sources]
> +  ../../opensbi/lib/sbi/riscv_asm.c

Please move the opensbi directory to here instead.

/
    Leif

> +  ../../opensbi/lib/sbi/riscv_atomic.c
> +  ../../opensbi/lib/sbi/riscv_hardfp.S
> +  ../../opensbi/lib/sbi/riscv_locks.c
> +  ../../opensbi/lib/sbi/riscv_unpriv.c
> +  ../../opensbi/lib/sbi/sbi_console.c
> +  ../../opensbi/lib/sbi/sbi_ecall.c
> +  ../../opensbi/lib/sbi/sbi_emulate_csr.c
> +  ../../opensbi/lib/sbi/sbi_fifo.c
> +  ../../opensbi/lib/sbi/sbi_hart.c
> +  ../../opensbi/lib/sbi/sbi_illegal_insn.c
> +  ../../opensbi/lib/sbi/sbi_init.c
> +  ../../opensbi/lib/sbi/sbi_ipi.c
> +  ../../opensbi/lib/sbi/sbi_misaligned_ldst.c
> +  ../../opensbi/lib/sbi/sbi_scratch.c
> +  ../../opensbi/lib/sbi/sbi_string.c
> +  ../../opensbi/lib/sbi/sbi_system.c
> +  ../../opensbi/lib/sbi/sbi_timer.c
> +  ../../opensbi/lib/sbi/sbi_tlb.c
> +  ../../opensbi/lib/sbi/sbi_trap.c
> +  ../../opensbi/lib/utils/sys/clint.c
> +  ../../opensbi/lib/utils/irqchip/plic.c
> +  ../../opensbi/lib/utils/serial/sifive-uart.c
> +  ../../opensbi/lib/utils/serial/uart8250.c
> +
> +[Packages]
> +  MdePkg/MdePkg.dec
> +  RiscVPkg/RiscVPkg.dec
> +
> +[LibraryClasses]
> +  BaseLib
> +  PcdLib
> +  RiscVCpuLib
> +
> -- 
> 2.7.4
> 
> 
> 
>