public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, philmd@redhat.com
Cc: pete@akeo.ie, ard.biesheuvel@linaro.org
Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements
Date: Tue, 1 Oct 2019 14:18:36 +0100	[thread overview]
Message-ID: <20191001131836.GU25504@bivouac.eciton.net> (raw)
In-Reply-To: <d7cb7f8d-5e48-ec28-5a96-ea69a1ab3ea9@redhat.com>

On Tue, Oct 01, 2019 at 12:20:03PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Pete,
> 
> On 9/27/19 10:41 PM, Pete Batard wrote:
> > Try this after making sure that you have edk2/, edk2-platforms/ and
> > edk-non-osi/ in /home/phil/source:
> > 
> > cd /home/phil/source
> > export GCC5_AARCH64_PREFIX=aarch64-linux-gnu-
> > export WORKSPACE=$PWD
> > export PACKAGES_PATH=$WORKSPACE/edk2:$WORKSPACE/edk2-platforms:$WORKSPACE/edk2-non-osi
> > 
> > source edk2/edksetup.sh --reconfig
> > build -a AARCH64 -t GCC5 -p
> > edk2-platforms/Platform/RaspberryPi/RPi3/RPi3.dsc -b DEBUG
> 
> [note for other readers: I'm answering to Pete top-posted comment,
>  start of the discussion can be followed below my reply]
> 
> I'm confused because this works like charm.
> 
> I always used:
> 
> WORKSPACE        = /home/phil/source/edk2
> PACKAGES_PATH    =
> /home/phil/source/edk2:/home/phil/source/edk2-platforms
> 
> and built into my edk2/ folder (my $WORKSPACE).
> 
> Leif noticed I was missing edk2-non-osi, so I added it (this reply below):
> 
> PACKAGES_PATH    =
> /home/phil/source/edk2:/home/phil/source/edk2-platforms:/home/phil/source/edk2-non-osi
> 
> 
> I don't understand why modifying $WORKSPACE out of edk2/ this changes the
> behavior into failure, I thought it was would mostly change the Build/
> folder location, and the packages were only searched into $PACKAGES_PATH
> (which did not change).

Yeah, I recall this from the early days of moving from OpenPlatformPkg
(symlink or submodule) to edk2-platforms (and PACKAGES_PATH).
Something in the "let's avoid getting namespace clashes" logic goes
bonkers[1] when you get any part of path overlap (i.e. Platform/ in
more than one PACKAGES_PATH directory) ... but only when using edk2/
as WORKSPACE.

[1] does what Leif wouldn't have expected

> Anyhow I'll adapt my setup and not use edk2/ as $WORKSPACE anymore.

Yeah, that's what I did.

/
    Leif

> Thanks for the pointers,
> 
> Phil.

  reply	other threads:[~2019-10-01 13:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27  9:20 [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements Pete Batard
2019-09-27 16:38 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-27 17:49   ` Leif Lindholm
2019-09-27 20:23     ` Philippe Mathieu-Daudé
2019-09-27 20:41       ` Pete Batard
2019-10-01 10:20         ` Philippe Mathieu-Daudé
2019-10-01 13:18           ` Leif Lindholm [this message]
2019-09-27 17:51   ` Pete Batard
2019-09-28 23:05 ` Leif Lindholm
2019-09-30  9:32   ` Pete Batard
2019-10-01 13:10     ` Leif Lindholm
2019-10-01 13:35       ` [edk2-devel] " Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191001131836.GU25504@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox