From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=ThSZqs7W; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Tue, 01 Oct 2019 06:18:41 -0700 Received: by mail-wm1-f68.google.com with SMTP id a6so3332730wma.5 for ; Tue, 01 Oct 2019 06:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=VI6r7SGmgbdvTeISxl6quI9CtLnInXBgzP40IUc2dCc=; b=ThSZqs7W1O2rtIrzpjs9IJ/TXm/xU4BbwFcsz5jyEJRL34GmDEtkxbky032jT3MjL1 EjBc0eyELsZfhMx2gGzjNmJWgVDuPNtI7p5d4y7GHBY4AlVb4ony2WXXL8xLUcD+2ZhL pbkaW5qWmFrZuifSDEJoZwPW3z+uShcMfh5VjpFWXsj1ug+/q3rxzAKMFAxHfGfDHxVs b6rCDy/TSpD0GEqICgPpa8Sz2s0h8inTDUfjV1fgyZ8Sborp4TFSt2xhKVErEswB0Mtd HZ21vG+1OjLYk+JL4KMSrgX7Yq9f3XQ0cm55hwEx4i2zO5YZD4Ci90zJ1Y2MzdqaE0Ah z9Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=VI6r7SGmgbdvTeISxl6quI9CtLnInXBgzP40IUc2dCc=; b=fYa8thGr6Yja2L7XVau4+XyrYzM1zXH1I7IReW6MPCyNcLrT77x71UkiDar93xJM0j 8mTuz467cYDk7wXjRVguxWmoRFwlV2Jgjy/jBmPttOqmWD50R11TrQZN+xr3FyOfhW7g 33Ai2Lxcp1yLdy849EUkojaoLOyy9c9uwjTcQqVctj+jPUPb0+NYLc23MCxFt+pCnUXM 7hgIC1wQhZ2qyND/UEwV56tyfxlTswdeYsPbb///02y16h2tgunjn6KMajDgsuIDbklm icGSHstNRPj2Q8xzcKySLk1n8UPHCPuIgT5n/D4m9mVC4G66yA2ueL59zVSoPs4ipusA OgCA== X-Gm-Message-State: APjAAAXk5E8INDLwhLAfWzAlzgXpZYHNAHabaRxDJWiJ7kznJkD7rXib A3Lo7wCAe85Iword+/dAp/gVZW8MA+U= X-Google-Smtp-Source: APXvYqzjwdkFxhTATG5dQXlHfeSaml6Iy9Oexn99xYp8F79zeymJ22Cza0ATS3vimnvKaCIvTD7m3g== X-Received: by 2002:a7b:cbc5:: with SMTP id n5mr3938081wmi.31.1569935918880; Tue, 01 Oct 2019 06:18:38 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id p85sm4354003wme.23.2019.10.01.06.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 06:18:38 -0700 (PDT) Date: Tue, 1 Oct 2019 14:18:36 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, philmd@redhat.com Cc: pete@akeo.ie, ard.biesheuvel@linaro.org Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements Message-ID: <20191001131836.GU25504@bivouac.eciton.net> References: <20190927092016.5604-1-pete@akeo.ie> <20190927174923.GP25504@bivouac.eciton.net> <471e60ec-2fe4-7d6f-619c-f35b2ec29bf9@redhat.com> <8cd1da3e-86b4-c8c8-1737-01fd8c728402@akeo.ie> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Oct 01, 2019 at 12:20:03PM +0200, Philippe Mathieu-Daudé wrote: > Hi Pete, > > On 9/27/19 10:41 PM, Pete Batard wrote: > > Try this after making sure that you have edk2/, edk2-platforms/ and > > edk-non-osi/ in /home/phil/source: > > > > cd /home/phil/source > > export GCC5_AARCH64_PREFIX=aarch64-linux-gnu- > > export WORKSPACE=$PWD > > export PACKAGES_PATH=$WORKSPACE/edk2:$WORKSPACE/edk2-platforms:$WORKSPACE/edk2-non-osi > > > > source edk2/edksetup.sh --reconfig > > build -a AARCH64 -t GCC5 -p > > edk2-platforms/Platform/RaspberryPi/RPi3/RPi3.dsc -b DEBUG > > [note for other readers: I'm answering to Pete top-posted comment, > start of the discussion can be followed below my reply] > > I'm confused because this works like charm. > > I always used: > > WORKSPACE = /home/phil/source/edk2 > PACKAGES_PATH = > /home/phil/source/edk2:/home/phil/source/edk2-platforms > > and built into my edk2/ folder (my $WORKSPACE). > > Leif noticed I was missing edk2-non-osi, so I added it (this reply below): > > PACKAGES_PATH = > /home/phil/source/edk2:/home/phil/source/edk2-platforms:/home/phil/source/edk2-non-osi > > > I don't understand why modifying $WORKSPACE out of edk2/ this changes the > behavior into failure, I thought it was would mostly change the Build/ > folder location, and the packages were only searched into $PACKAGES_PATH > (which did not change). Yeah, I recall this from the early days of moving from OpenPlatformPkg (symlink or submodule) to edk2-platforms (and PACKAGES_PATH). Something in the "let's avoid getting namespace clashes" logic goes bonkers[1] when you get any part of path overlap (i.e. Platform/ in more than one PACKAGES_PATH directory) ... but only when using edk2/ as WORKSPACE. [1] does what Leif wouldn't have expected > Anyhow I'll adapt my setup and not use edk2/ as $WORKSPACE anymore. Yeah, that's what I did. / Leif > Thanks for the pointers, > > Phil.