* [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Resize FSP-T to accommodate debug FSP builds.
@ 2019-10-02 7:38 Nate DeSimone
2019-10-02 21:24 ` [edk2-devel] " Jeremy Soller
2019-10-03 1:31 ` Kubacki, Michael A
0 siblings, 2 replies; 3+ messages in thread
From: Nate DeSimone @ 2019-10-02 7:38 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Michael Kubacki, Jeremy Soller
Resize the flash map for the GalagoPro3 platform to provide
enough space to accommodate a debug build of FSP-T.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Jeremy Soller <jeremy@system76.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../GalagoPro3/Include/Fdf/FlashMapInclude.fdf | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclude.fdf b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclude.fdf
index b33b1e09a9..1fd7a882cf 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclude.fdf
+++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclude.fdf
@@ -41,8 +41,8 @@ SET gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize = 0x000A0000
SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSOffset = 0x00440000 # Flash addr (0xFFE60000)
SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize = 0x00060000 #
SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMOffset = 0x004A0000 # Flash addr (0xFFEC0000)
-SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize = 0x000BC000 #
-SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTOffset = 0x0055C000 # Flash addr (0xFFF7C000)
-SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize = 0x00004000 #
+SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize = 0x000BA000 #
+SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTOffset = 0x0055A000 # Flash addr (0xFFF7C000)
+SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize = 0x00006000 #
SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemoryOffset = 0x00560000 # Flash addr (0xFFF80000)
SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemorySize = 0x00080000 #
--
2.23.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Resize FSP-T to accommodate debug FSP builds.
2019-10-02 7:38 [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Resize FSP-T to accommodate debug FSP builds Nate DeSimone
@ 2019-10-02 21:24 ` Jeremy Soller
2019-10-03 1:31 ` Kubacki, Michael A
1 sibling, 0 replies; 3+ messages in thread
From: Jeremy Soller @ 2019-10-02 21:24 UTC (permalink / raw)
To: devel, Nathaniel L Desimone; +Cc: Chasel Chiu, Michael A Kubacki
Reviewed-by: Jeremy Soller <jeremy@system76.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Resize FSP-T to accommodate debug FSP builds.
2019-10-02 7:38 [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Resize FSP-T to accommodate debug FSP builds Nate DeSimone
2019-10-02 21:24 ` [edk2-devel] " Jeremy Soller
@ 2019-10-03 1:31 ` Kubacki, Michael A
1 sibling, 0 replies; 3+ messages in thread
From: Kubacki, Michael A @ 2019-10-03 1:31 UTC (permalink / raw)
To: Desimone, Nathaniel L, devel@edk2.groups.io; +Cc: Chiu, Chasel, Jeremy Soller
Although it is just a comment, the PcdFlashFvFspTOffset value should be 0xFFF7A000 instead of 0xFFF7C000.
> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Wednesday, October 2, 2019 12:38 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Jeremy Soller <jeremy@system76.com>
> Subject: [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Resize FSP-T to
> accommodate debug FSP builds.
>
> Resize the flash map for the GalagoPro3 platform to provide enough space to
> accommodate a debug build of FSP-T.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> .../GalagoPro3/Include/Fdf/FlashMapInclude.fdf | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapIncl
> ude.fdf
> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapIncl
> ude.fdf
> index b33b1e09a9..1fd7a882cf 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapIncl
> ude.fdf
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMa
> +++ pInclude.fdf
> @@ -41,8 +41,8 @@ SET gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize
> = 0x000A0000
> SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSOffset =
> 0x00440000 # Flash addr (0xFFE60000) SET
> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize = 0x00060000 #
> SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMOffset =
> 0x004A0000 # Flash addr (0xFFEC0000)-SET
> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize = 0x000BC000
> #-SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTOffset =
> 0x0055C000 # Flash addr (0xFFF7C000)-SET
> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize = 0x00004000
> #+SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize =
> 0x000BA000 #+SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTOffset
> = 0x0055A000 # Flash addr (0xFFF7C000)+SET
> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize = 0x00006000 #
> SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemoryOffset =
> 0x00560000 # Flash addr (0xFFF80000) SET
> gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemorySize =
> 0x00080000 #--
> 2.23.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-03 1:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-02 7:38 [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Resize FSP-T to accommodate debug FSP builds Nate DeSimone
2019-10-02 21:24 ` [edk2-devel] " Jeremy Soller
2019-10-03 1:31 ` Kubacki, Michael A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox