From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=bk5qcqLD; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Wed, 02 Oct 2019 09:35:15 -0700 Received: by mail-wr1-f66.google.com with SMTP id w12so20435725wro.5 for ; Wed, 02 Oct 2019 09:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qKM9e/BGBfegVY3DXzeLxYRYS+IciqffadqRcyhY4Yo=; b=bk5qcqLDZKM6MPEsnNGYqtUs8jmRtVknIQv10XClvtq1hdh+mBHScGaf85dIUezA+a 2xmczvj3Py1PV5WCI6MM9ImeVP71uqGZYeTuEd4h2r97oxOrRibPI5SAiEtfy/3/dVJL zVKUdpNhDj2Ub9w5waLAIMVxBOvPZk7cNEWAps1WwZeGNWDuO7vIXPH987S6eWYP2uXW kTcYauBEHIdIMmE1Y6PqQrlPWMXH06rY5vT7ZDyP1hwROwk7MZuuiozTKtnru3H1G3yk oyR1I62+lPPqyqP0WQudlnW/11IpBfMDOmx2JeGlYt0gs1NMF1GWhA5SUpobzKh0LxO6 NlXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qKM9e/BGBfegVY3DXzeLxYRYS+IciqffadqRcyhY4Yo=; b=LyEpHRkur6Mz+IiRWIO6rsVtpcStHAvxNAS8ucv+Vd6SuhB+izukO3hAP5sD0455Pn hB25a619JBieq3A3ZBZ3w/zYgZmP9v3ieMjwnWbx3n2Q4+4cAHO8jio3udJB1ongwZ2H wS/dXpCMIa8HuDXWPds6uW7yDy8i+bghnPLUpMGiJnlVQzQM+3womaeLHJFCyeg2YE9H lEKK+Gg8Wpe2msEiQHYrtEW2Oz63jBbGjRR/S7sBZh/Wt2TjS7j5KOMT3IsP7JRPi7dm h5xZvTMX6RKXBZW9DD43eZv3lBYhhte4keBdVicQoX8R+CjPsp586nyrILqQDqjwDn2t fNfw== X-Gm-Message-State: APjAAAW4V1mlqmFrPIei/RwamJHnqBbePC6GUHcNVdVlHzzBm7QIc4lQ hnuXdtJptAuS0ae0tTgWWgAx4QzIwqY= X-Google-Smtp-Source: APXvYqzFzyPI4Km5XmykuL5H1ICRHBOT4xnvYFM69mM7Y4O7OAFchpdg/wAsTH01BtHZh2hqKOTwjA== X-Received: by 2002:adf:cc0a:: with SMTP id x10mr3326307wrh.195.1570034112992; Wed, 02 Oct 2019 09:35:12 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z125sm10707501wme.37.2019.10.02.09.35.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2019 09:35:12 -0700 (PDT) Date: Wed, 2 Oct 2019 17:35:10 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, afish@apple.com Cc: abner.chang@hpe.com, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Mike Kinney , Liming Gao Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions. Message-ID: <20191002163510.GB25504@bivouac.eciton.net> References: <1569198715-31552-1-git-send-email-abner.chang@hpe.com> <1569198715-31552-11-git-send-email-abner.chang@hpe.com> <20190926233928.GL25504@bivouac.eciton.net> <90c04adf-79b1-2d89-1683-c916444126c7@redhat.com> <20191001090705.GQ25504@bivouac.eciton.net> <20191002091317.GZ25504@bivouac.eciton.net> <22170513-D99D-43E1-8086-B322DAC50857@apple.com> MIME-Version: 1.0 In-Reply-To: <22170513-D99D-43E1-8086-B322DAC50857@apple.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 02, 2019 at 11:27:16AM -0500, Andrew Fish via Groups.Io wrote: > > > > On Oct 2, 2019, at 11:14 AM, Abner Chang wrote: > > > > Thanks Leif, let me check with maintainers. > > > > Hi Mike and Liming, > > How do you think about to use IoLibArm as the I/O lib instance for RISC-V arch? I personally don't like to use IoLibArm.c in [Source.RISCV64] section, instead I would like to use IoLibRiscV.c which conform with current source file organization under BaseIoLibIntrinsics. What's your preference? > > > > Abner, > > So is the plan to just copy IoLibArm.c to IoLibRiskV.c? I kind of > agree with Leif that having two copies of the same thing does not > make sense. I do see your point about naming, but maybe the issue > the IoLibArm.c name. I don't see anything ARM specific in > IoLibArm.c it seems to me it is generic C code for a platform that > does not have IO Ports. So I guess we could just change the file > name of IoLibArm.c to IoLibNoIo.c and have ARM and RISC-V point at > the common file? Works for me. We can untangle the remaining mess unrelated from the Risc-V upstreaming. Best Regards, Leif