From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=gjKaiaiT; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by groups.io with SMTP; Thu, 03 Oct 2019 01:38:12 -0700 Received: by mail-wr1-f65.google.com with SMTP id q9so1974675wrm.8 for ; Thu, 03 Oct 2019 01:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q0BnT57BCh33l2KLDEH5bpwsvEQJi+gqKcQ/vwTTzEc=; b=gjKaiaiTqn81mgzoYlIFrBzM7ZjfWca4IqfBmgrCJc2PI2pqWtZt4TGceGrj9Kbvqc /C3bBAAcJ6PLPtyIh8ZTibFshulld5SJ8cttBWafEqAIvIqfxDDJVsjBhFVZOzZ6ndm4 h9ki5VAltbWbwss+xqH0wpgaI8wAjbWq8OOkKq5rux36KEDjtsZEGSzyts8DUub6aTRc D3lrV5080xVRy6Zp5rmK//0JMCTlcRBSxnTYmRVX9N6+C1qIuzlOKzL3WVW8n6841UT0 AmMKuDFvfa3lna3X1+4yGLWoqQqYKniHlqC+tLVb8WKm9QwX0bunBU8xbsPx6aQBLTbT gV7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=q0BnT57BCh33l2KLDEH5bpwsvEQJi+gqKcQ/vwTTzEc=; b=HNDKKEin+8ywx5e8PfwMZa3O44cNV0eTl2lMi9P+GusBTyEOZaEYalcMj3QTZs8TSx 6xgWh8/QpoMw6M1wChyGO1PWHOgwGVZAutM9Wv6Kqvex4GEDM8tSaq2LsBaVYa6qWyl5 YhLIeQ45N1AZgOUKJO4f6stQuXd4o3ftdbcuxfzCzO5o4FfQwhufBtsZJY/CzBfznPgf esFOILP/8NuG4KGUcpTsL77kl+fNwCf8x7gu5GxfBJZalAYE/iH/y9m5ztAO/cVfv1Kr eoJVqLkGAPz4xokeAVxNJAQSwwI8xA6EtYPKTqARIYmE5X6GfTgY1Q7JyxfpeZRpiolP IWbA== X-Gm-Message-State: APjAAAWM5SVFFkJxP5ua7n9JEWsh47f4QCWaxHHqw+0nOeId42L3zfED Nj9wsq9mcESbIxDIds25F749nu/4J7M= X-Google-Smtp-Source: APXvYqwto3XsDsrh6Co2aGeYxUARrg1U39dOmaheaLwsXX8ClfACt9By6oKQozW1a7dhugEE4pmsCA== X-Received: by 2002:a5d:690e:: with SMTP id t14mr4876933wru.333.1570091890546; Thu, 03 Oct 2019 01:38:10 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v11sm1414531wml.30.2019.10.03.01.38.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2019 01:38:09 -0700 (PDT) Date: Thu, 3 Oct 2019 09:38:08 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, abner.chang@hpe.com Cc: "afish@apple.com" , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Mike Kinney , Liming Gao , Palmer Dabbelt Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions. Message-ID: <20191003083808.GJ25504@bivouac.eciton.net> References: <1569198715-31552-11-git-send-email-abner.chang@hpe.com> <20190926233928.GL25504@bivouac.eciton.net> <90c04adf-79b1-2d89-1683-c916444126c7@redhat.com> <20191001090705.GQ25504@bivouac.eciton.net> <20191002091317.GZ25504@bivouac.eciton.net> <22170513-D99D-43E1-8086-B322DAC50857@apple.com> <20191002163510.GB25504@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 03, 2019 at 12:52:57AM +0000, Abner Chang wrote: > > > So is the plan to just copy IoLibArm.c to IoLibRiskV.c? I kind of > > > agree with Leif that having two copies of the same thing does not make > > > sense. I do see your point about naming, but maybe the issue the > > > IoLibArm.c name. I don't see anything ARM specific in IoLibArm.c it > > > seems to me it is generic C code for a platform that does not have IO > > > Ports. So I guess we could just change the file name of IoLibArm.c to > > > IoLibNoIo.c and have ARM and RISC-V point at the common file? > > Yes, naming is my concern. No technical issues here. > Thanks for this suggestion. > > > Works for me. > > We can untangle the remaining mess unrelated from the Risc-V upstreaming. > > Leif, I will rename IoLibRiscV.c to IoLibNoIo.c in the next version > of patches. You can adopt the new file in ARM side later. The suggestion was to rename IoLibArm.c. If you're insisting on keeping your duplicated version, you're back to looking for another maintainer to convince that this is the better solution. Best Regards, Leif