From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web12.6698.1570720891712965276 for ; Thu, 10 Oct 2019 08:21:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=GcvACMpK; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f68.google.com with SMTP id f22so7220345wmc.2 for ; Thu, 10 Oct 2019 08:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=resent-from:resent-date:resent-message-id:resent-to:date:from:to:cc :subject:message-id:references:mime-version:content-disposition :in-reply-to:user-agent; bh=srAIhheNlBsD5VtxgfXNl5LEApZDoaJlvzu0/o83tAk=; b=GcvACMpKa+N403NzrIx0/OqaJvhIGxcSryDfezUXA6c0yjdM5JDaanwOKuz/DYPRd8 67KvFxykuILBWDCpC/xcUvMLG8jRRSWN33fifFvtjDYZoVhWhlfzMjWYRMCf1RDRDXGJ FuAVFYpo6CdYW5nok9TLhBpGgKwnGiu5gYMLQ/Tq1KsWqh0H5meYuwwNdCNZjP2fFbmh 6G8L9cid587R70fbuIkCXKxxdwvzsC8BFL7z/8Ej0L5p11IMkiRaP5WxkEi1hGPm8zSD 3DnX6Jzn2dGJTwuKVynX+P2sNKNxUUWv+hPhM5GMyzAjcJq5gd/k50QANYaL+TlUqfJ+ bOig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:resent-from:resent-date:resent-message-id :resent-to:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=srAIhheNlBsD5VtxgfXNl5LEApZDoaJlvzu0/o83tAk=; b=NRuuekaWVM7rnzlRu+ljCSAPGpjLbwjtzWj3xA66VM3dNq6XhPDScU2qKHLzMgervj s/tj7R2T0QEY7vHt26JH+u+Ggn8ZhxX4xHOWrxHQY1LMXBI93G/sMfdeVk2Vdfl7IQSQ prJTqRwQTNdDdnDTNZDktvurMJOl7gzurqT1FROa4NlZvxSg/Cz9czlOCjp92NNOoo6I mok1HJXTkoCE8NlRVicjH8tcuhjBCDdrC/2/BbTfc34PSC7lGe1R303HSlw9b5jsy4gw qhFtxS2yh0i+N7RXcnsLWEz4EYAwW7grPXJq5DF+M6615NxfshPTFk4QQQxv2027G7Cg QIow== X-Gm-Message-State: APjAAAU4uY8MYsitSQHByxtb7dTSmto8YYIIq9k2lkRSIF/kjbiDFH5e KXSU/V5D5lFPJpcsyKTpDUD1jvIC9t4= X-Google-Smtp-Source: APXvYqwnPbWnIpX9YX690k/vSS1B1pHzI0lXFBcmis1HlFy/5KceyoxsJXE6yFqalyUdTuaCudYyRQ== X-Received: by 2002:a05:600c:10ce:: with SMTP id l14mr8239508wmd.102.1570720889914; Thu, 10 Oct 2019 08:21:29 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w3sm8183041wru.5.2019.10.10.08.21.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 08:21:29 -0700 (PDT) Resent-From: Leif Lindholm Resent-Date: Thu, 10 Oct 2019 16:21:28 +0100 Resent-Message-ID: <20191010152128.GL25504@bivouac.eciton.net> Resent-To: devel@edk2.groups.io Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a3sm5645245wmj.35.2019.10.10.08.12.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 08:12:44 -0700 (PDT) Date: Thu, 10 Oct 2019 16:12:42 +0100 From: "Leif Lindholm" To: Meenakshi Aggarwal Cc: ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, edk2-devel@lists.01.org, v.sethi@nxp.com Subject: Re: [PATCH edk2-platforms 10/12] Platform/NXP: Add Platform driver for LS1043 RDB board Message-ID: <20191010151242.GG25504@bivouac.eciton.net> References: <1543417315-5763-1-git-send-email-meenakshi.aggarwal@nxp.com> <1570639758-30355-1-git-send-email-meenakshi.aggarwal@nxp.com> <1570639758-30355-11-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1570639758-30355-11-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 09, 2019 at 10:19:16PM +0530, Meenakshi Aggarwal wrote: > Platform driver will be used for platform specific work. > At present, it populate i2c driver structure with platform > specific information and install RTC on i2c. > > Signed-off-by: Meenakshi Aggarwal Reviewed-by: Leif Lindholm > --- > .../Drivers/PlatformDxe/PlatformDxe.c | 114 +++++++++++++++++++++ > .../Drivers/PlatformDxe/PlatformDxe.inf | 52 ++++++++++ > 2 files changed, 166 insertions(+) > create mode 100644 Platform/NXP/LS1043aRdbPkg/Drivers/PlatformDxe/PlatformDxe.c > create mode 100644 Platform/NXP/LS1043aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf > > diff --git a/Platform/NXP/LS1043aRdbPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/NXP/LS1043aRdbPkg/Drivers/PlatformDxe/PlatformDxe.c > new file mode 100644 > index 0000000..f89dcde > --- /dev/null > +++ b/Platform/NXP/LS1043aRdbPkg/Drivers/PlatformDxe/PlatformDxe.c > @@ -0,0 +1,114 @@ > +/** @file > + LS1043 DXE platform driver. > + > + Copyright 2018-2019 NXP > + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +typedef struct { > + EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR StartDesc; > + UINT8 EndDesc; > +} ADDRESS_SPACE_DESCRIPTOR; > + > +STATIC ADDRESS_SPACE_DESCRIPTOR mI2cDesc[FixedPcdGet64 (PcdNumI2cController)]; > + > +STATIC > +EFI_STATUS > +RegisterDevice ( > + IN EFI_GUID *TypeGuid, > + IN ADDRESS_SPACE_DESCRIPTOR *Desc, > + OUT EFI_HANDLE *Handle > + ) > +{ > + NON_DISCOVERABLE_DEVICE *Device; > + EFI_STATUS Status; > + > + Device = (NON_DISCOVERABLE_DEVICE *)AllocateZeroPool (sizeof (*Device)); > + if (Device == NULL) { > + return EFI_OUT_OF_RESOURCES; > + } > + > + Device->Type = TypeGuid; > + Device->DmaType = NonDiscoverableDeviceDmaTypeNonCoherent; > + Device->Resources = (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *)Desc; > + > + Status = gBS->InstallMultipleProtocolInterfaces (Handle, > + &gEdkiiNonDiscoverableDeviceProtocolGuid, Device, > + NULL); > + if (EFI_ERROR (Status)) { > + goto FreeDevice; > + } > + return EFI_SUCCESS; > + > +FreeDevice: > + FreePool (Device); > + > + return Status; > +} > + > +VOID > +PopulateI2cInformation ( > + IN VOID > + ) > +{ > + UINT32 Index; > + > + for (Index = 0; Index < FixedPcdGet32 (PcdNumI2cController); Index++) { > + mI2cDesc[Index].StartDesc.Desc = ACPI_ADDRESS_SPACE_DESCRIPTOR; > + mI2cDesc[Index].StartDesc.Len = sizeof (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR) - 3; > + mI2cDesc[Index].StartDesc.ResType = ACPI_ADDRESS_SPACE_TYPE_MEM; > + mI2cDesc[Index].StartDesc.GenFlag = 0; > + mI2cDesc[Index].StartDesc.SpecificFlag = 0; > + mI2cDesc[Index].StartDesc.AddrSpaceGranularity = 32; > + mI2cDesc[Index].StartDesc.AddrRangeMin = FixedPcdGet64 (PcdI2c0BaseAddr) + > + (Index * FixedPcdGet32 (PcdI2cSize)); > + mI2cDesc[Index].StartDesc.AddrRangeMax = mI2cDesc[Index].StartDesc.AddrRangeMin + > + FixedPcdGet32 (PcdI2cSize) - 1; > + mI2cDesc[Index].StartDesc.AddrTranslationOffset = 0; > + mI2cDesc[Index].StartDesc.AddrLen = FixedPcdGet32 (PcdI2cSize); > + > + mI2cDesc[Index].EndDesc = ACPI_END_TAG_DESCRIPTOR; > + } > +} > + > +EFI_STATUS > +EFIAPI > +PlatformDxeEntryPoint ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + EFI_STATUS Status; > + EFI_HANDLE Handle; > + > + Handle = NULL; > + > + PopulateI2cInformation (); > + > + Status = RegisterDevice (&gNxpNonDiscoverableI2cMasterGuid, > + &mI2cDesc[0], &Handle); > + ASSERT_EFI_ERROR (Status); > + > + // > + // Install the DS1307 I2C Master protocol on this handle so the RTC driver > + // can identify it as the I2C master it can invoke directly. > + // > + Status = gBS->InstallProtocolInterface (&Handle, > + &gDs1307RealTimeClockLibI2cMasterProtocolGuid, > + EFI_NATIVE_INTERFACE, NULL); > + ASSERT_EFI_ERROR (Status); > + > + return EFI_SUCCESS; > +} > diff --git a/Platform/NXP/LS1043aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf b/Platform/NXP/LS1043aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf > new file mode 100644 > index 0000000..d689cf4 > --- /dev/null > +++ b/Platform/NXP/LS1043aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf > @@ -0,0 +1,52 @@ > +## @file > +# > +# Component description file for LS1043 DXE platform driver. > +# > +# Copyright 2018-2019 NXP > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[Defines] > + INF_VERSION = 0x0001001A > + BASE_NAME = PlatformDxe > + FILE_GUID = 21108101-adcd-4123-930e-a2354a554db7 > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + ENTRY_POINT = PlatformDxeEntryPoint > + > +[Sources] > + PlatformDxe.c > + > +[Packages] > + ArmPkg/ArmPkg.dec > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.dec > + Silicon/NXP/NxpQoriqLs.dec > + > +[LibraryClasses] > + BaseLib > + BaseMemoryLib > + DebugLib > + MemoryAllocationLib > + PcdLib > + UefiBootServicesTableLib > + UefiDriverEntryPoint > + UefiLib > + > +[Guids] > + gNxpNonDiscoverableI2cMasterGuid > + > +[Protocols] > + gEdkiiNonDiscoverableDeviceProtocolGuid ## PRODUCES > + gDs1307RealTimeClockLibI2cMasterProtocolGuid ## PRODUCES > + > +[FixedPcd] > + gNxpQoriqLsTokenSpaceGuid.PcdI2c0BaseAddr > + gNxpQoriqLsTokenSpaceGuid.PcdI2cSize > + gNxpQoriqLsTokenSpaceGuid.PcdNumI2cController > + > +[Depex] > + TRUE > -- > 1.9.1 >