From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web12.6752.1570721240818562776 for ; Thu, 10 Oct 2019 08:27:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=WLfY/+70; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f66.google.com with SMTP id r19so7428205wmh.2 for ; Thu, 10 Oct 2019 08:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wMt9LkyWiM0JnXLJ5+XrjzPaW7mfIh7jFSc4Fjpn/6Y=; b=WLfY/+70I/FBjSyTIL5N7U3NVZOVNqxwFnRvLT/QDKpAusjNACH2m8CdjqoAlyED54 fJAc/KIRkqlOqTxTCr32ZDz++qmUXKpl1bdX8bpTXfir2Elshhr72ErdKSBEI6OC4ycz NtDj3emkshDFaIaxi6grCyCzVuSbGSM7y8CSnmoSupAiYx5qCcn0fNI+BdvqWu7WHRY1 iCDxpEmCGd8BOxxw6MXEyZWvZACdbz6ch43s9IdctjC2lSqVp4KV7GyIXS0faOEV5m3u Ti519tQRe1d15HUoHJFIfqW3IAg9ktJXk7j/Z6vUuc1xZJayonFvlPq7tvPeFYdwwjli rLGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wMt9LkyWiM0JnXLJ5+XrjzPaW7mfIh7jFSc4Fjpn/6Y=; b=uLVxOaGK9wNl4s2pOTEzBZgjO0QsILM1C8D1pOVwEFR6pcp9Wn+Z/Ed3VPv5P9VL7M CALDb3XyCqUUMJ8fFw3tt/RyVqjgB7zyz9+AeaDWytlj31hdjSlWZK7FEwXGjPEBF9Lq 7oAb9q7qKIHGuepOlU+U6i8O0nkBcHmfVUbIZiWyQsoMOM764dgl6d1tgQMGRbS6H7io W5LsHvbTEPLN2DeMsljr6/FXLR2IMDd25gXNXujwInOsnOCODllbfZhAMCZi/f1FWuhG 9KsJPM13ApoQt/jhPmyJT6iIrSIH6N1dZ8r8wS6KTVr11DWRK93za62ufxsbL9x+yww9 kbPg== X-Gm-Message-State: APjAAAX+Qe5dkmRWq0aCn/ttl1ZVhqBfF2PVFgxlXa+kzIcP70OWSy7l WaOf4zozzww9k+VdBPNF+71/bw== X-Google-Smtp-Source: APXvYqzx7RQx2QP7tscqb4LBpeH/XoYJU411OeoUKHRw2WK8uV7cCQNv8QkS6hy8QmIsLCVqOlvJEA== X-Received: by 2002:a1c:f718:: with SMTP id v24mr7706330wmh.82.1570721239316; Thu, 10 Oct 2019 08:27:19 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id r6sm7559550wmh.38.2019.10.10.08.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 08:27:18 -0700 (PDT) Date: Thu, 10 Oct 2019 16:27:17 +0100 From: "Leif Lindholm" To: Meenakshi Aggarwal Cc: ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, devel@edk2.groups.io, v.sethi@nxp.com Subject: Re: [PATCH edk2-platforms 00/12] NXP : Add support of LS1043 SoC. Message-ID: <20191010152717.GN25504@bivouac.eciton.net> References: <1543417315-5763-1-git-send-email-meenakshi.aggarwal@nxp.com> <1570639758-30355-1-git-send-email-meenakshi.aggarwal@nxp.com> MIME-Version: 1.0 In-Reply-To: <1570639758-30355-1-git-send-email-meenakshi.aggarwal@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thanks for this. On the whole, the watchdog situation is the only real concern I have with regards to merging this set, the rest is pretty much all code style, and there's not much left of that. Looking forward to a v2, and finally merging some of this - but I warn you that I am on holiday Friday/Monday, so will not be able to have another look until Tuesday (UK time). Best Regards, Leif On Wed, Oct 09, 2019 at 10:19:06PM +0530, Meenakshi Aggarwal wrote: > We have combined all review comments recieved till now. > Major changes are: > - Created SocLib > - Divided Swapped MMIO APIs in two separate patches. > - Removed local helper script for compilation. > > Following patches will add support of LS1043 SoC in edk2-platforms. > > We will send patches to support LS2088 and LS1046 SoC after LS1043 gets merged. > > Our directory structure will be: > > edk2-platforms > |-- Platform > | |-- NXP > | | |-- FVRules.fdf.inc > | | |-- LS1043aRdbPkg > | | | |-- Drivers > | | | | `-- PlatformDxe > | | | | |-- PlatformDxe.c > | | | | `-- PlatformDxe.inf > | | | |-- Library > | | | | `-- PlatformLib > | | | | |-- ArmPlatformLib.c > | | | | |-- ArmPlatformLib.inf > | | | | |-- NxpQoriqLsHelper.S > | | | | `-- NxpQoriqLsMem.c > | | | |-- LS1043aRdbPkg.dec > | | | |-- LS1043aRdbPkg.dsc > | | | `-- LS1043aRdbPkg.fdf > | | |-- NxpQoriqLs.dsc.inc > | | `-- Readme.md > |-- Silicon > | |-- Maxim > | | `-- Library > | | `-- Ds1307RtcLib > | | |-- Ds1307Rtc.h > | | |-- Ds1307RtcLib.c > | | |-- Ds1307RtcLib.dec > | | `-- Ds1307RtcLib.inf > | |-- NXP > | | |-- Drivers > | | | |-- I2cDxe > | | | | |-- ComponentName.c > | | | | |-- DriverBinding.c > | | | | |-- I2cDxe.c > | | | | |-- I2cDxe.h > | | | | `-- I2cDxe.inf > | | | `-- WatchDog > | | | |-- WatchDog.c > | | | |-- WatchDogDxe.inf > | | | `-- WatchDog.h > | | |-- Include > | | | |-- Chassis2 > | | | | |-- LsSerDes.h > | | | | `-- NxpSoc.h > | | | |-- DramInfo.h > | | | `-- Library > | | | `-- IoAccessLib.h > | | |-- Library > | | | |-- DUartPortLib > | | | | |-- DUart.h > | | | | |-- DUartPortLib.c > | | | | `-- DUartPortLib.inf > | | | |-- IoAccessLib > | | | | |-- IoAccessLib.c > | | | | `-- IoAccessLib.inf > | | | |-- MemoryInitPei > | | | | |-- MemoryInitPeiLib.c > | | | | `-- MemoryInitPeiLib.inf > | | | |-- Pcf8563RealTimeClockLib > | | | | |-- Pcf8563RealTimeClockLib.c > | | | | |-- Pcf8563RealTimeClockLib.dec > | | | | `-- Pcf8563RealTimeClockLib.inf > | | | `-- SocLib > | | | |-- Chassis2 > | | | | `-- Soc.c > | | | |-- Chassis.c > | | | |-- LS1043aSocLib.inf > | | | |-- NxpChassis.h > | | | `-- SerDes.c > | | |-- LS1043A > | | | |-- Include > | | | | `-- SocSerDes.h > | | | |-- LS1043A.dec > | | | `-- LS1043A.dsc.inc > | | `-- NxpQoriqLs.dec > > > In Silicon/NXP, we are keeping our SoC specific information and all Drivers and Library which are used by SoCs. > > Platform/NXP/ will host our board packages and build script. > > Board specific libraries and header files will reside inside board package. > > > Looking forward for your kind support in upstreaming our boards in edk2-platforms. > > > Meenakshi Aggarwal (12): > Silicon/NXP: Add Library to provide Mmio APIs with swapped data. > Silicon/NXP: Add function to return swapped Mmio APIs pointer > Silicon/NXP : Add support for Watchdog driver > SocLib : Add support for initialization of peripherals > Silicon/NXP : Add support for DUART library > Silicon/NXP: Add support for I2c driver > Silicon/Maxim : Add support for DS1307 RTC library > Silicon/NXP : Add MemoryInitPei Library > Platform/NXP: Add support for ArmPlatformLib > Platform/NXP: Add Platform driver for LS1043 RDB board > Compilation : Add the fdf, dsc and dec files. > Readme : Add Readme.md file. > > Platform/NXP/FVRules.fdf.inc | 93 +++ > .../Drivers/PlatformDxe/PlatformDxe.c | 114 ++++ > .../Drivers/PlatformDxe/PlatformDxe.inf | 52 ++ > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dec | 23 + > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 84 +++ > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 169 +++++ > .../Library/PlatformLib/ArmPlatformLib.c | 98 +++ > .../Library/PlatformLib/ArmPlatformLib.inf | 55 ++ > .../Library/PlatformLib/NxpQoriqLsHelper.S | 31 + > .../Library/PlatformLib/NxpQoriqLsMem.c | 144 +++++ > Platform/NXP/NxpQoriqLs.dsc.inc | 373 +++++++++++ > Platform/NXP/Readme.md | 8 + > Readme.md | 3 + > Silicon/Maxim/Library/Ds1307RtcLib/Ds1307Rtc.h | 48 ++ > Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c | 372 +++++++++++ > .../Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.dec | 23 + > .../Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.inf | 40 ++ > Silicon/NXP/Drivers/I2cDxe/ComponentName.c | 179 ++++++ > Silicon/NXP/Drivers/I2cDxe/DriverBinding.c | 235 +++++++ > Silicon/NXP/Drivers/I2cDxe/I2cDxe.c | 690 +++++++++++++++++++++ > Silicon/NXP/Drivers/I2cDxe/I2cDxe.h | 100 +++ > Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf | 58 ++ > Silicon/NXP/Drivers/WatchDog/WatchDog.c | 396 ++++++++++++ > Silicon/NXP/Drivers/WatchDog/WatchDog.h | 32 + > Silicon/NXP/Drivers/WatchDog/WatchDogDxe.inf | 41 ++ > Silicon/NXP/Include/Chassis2/LsSerDes.h | 62 ++ > Silicon/NXP/Include/Chassis2/NxpSoc.h | 361 +++++++++++ > Silicon/NXP/Include/DramInfo.h | 38 ++ > Silicon/NXP/Include/Library/IoAccessLib.h | 326 ++++++++++ > Silicon/NXP/LS1043A/Include/SocSerDes.h | 51 ++ > Silicon/NXP/LS1043A/LS1043A.dec | 16 + > Silicon/NXP/LS1043A/LS1043A.dsc.inc | 61 ++ > Silicon/NXP/Library/DUartPortLib/DUart.h | 122 ++++ > Silicon/NXP/Library/DUartPortLib/DUartPortLib.c | 364 +++++++++++ > Silicon/NXP/Library/DUartPortLib/DUartPortLib.inf | 34 + > Silicon/NXP/Library/IoAccessLib/IoAccessLib.c | 404 ++++++++++++ > Silicon/NXP/Library/IoAccessLib/IoAccessLib.inf | 26 + > .../NXP/Library/MemoryInitPei/MemoryInitPeiLib.c | 139 +++++ > .../NXP/Library/MemoryInitPei/MemoryInitPeiLib.inf | 48 ++ > Silicon/NXP/Library/SocLib/Chassis.c | 498 +++++++++++++++ > Silicon/NXP/Library/SocLib/Chassis2/Soc.c | 162 +++++ > Silicon/NXP/Library/SocLib/LS1043aSocLib.inf | 45 ++ > Silicon/NXP/Library/SocLib/NxpChassis.h | 136 ++++ > Silicon/NXP/Library/SocLib/SerDes.c | 268 ++++++++ > Silicon/NXP/NxpQoriqLs.dec | 103 +++ > 45 files changed, 6725 insertions(+) > create mode 100644 Platform/NXP/FVRules.fdf.inc > create mode 100644 Platform/NXP/LS1043aRdbPkg/Drivers/PlatformDxe/PlatformDxe.c > create mode 100644 Platform/NXP/LS1043aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf > create mode 100644 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dec > create mode 100644 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > create mode 100644 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > create mode 100644 Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.c > create mode 100644 Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > create mode 100644 Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S > create mode 100644 Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > create mode 100644 Platform/NXP/NxpQoriqLs.dsc.inc > create mode 100644 Platform/NXP/Readme.md > create mode 100644 Silicon/Maxim/Library/Ds1307RtcLib/Ds1307Rtc.h > create mode 100644 Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c > create mode 100644 Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.dec > create mode 100644 Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.inf > create mode 100644 Silicon/NXP/Drivers/I2cDxe/ComponentName.c > create mode 100644 Silicon/NXP/Drivers/I2cDxe/DriverBinding.c > create mode 100644 Silicon/NXP/Drivers/I2cDxe/I2cDxe.c > create mode 100644 Silicon/NXP/Drivers/I2cDxe/I2cDxe.h > create mode 100644 Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf > create mode 100644 Silicon/NXP/Drivers/WatchDog/WatchDog.c > create mode 100644 Silicon/NXP/Drivers/WatchDog/WatchDog.h > create mode 100644 Silicon/NXP/Drivers/WatchDog/WatchDogDxe.inf > create mode 100644 Silicon/NXP/Include/Chassis2/LsSerDes.h > create mode 100644 Silicon/NXP/Include/Chassis2/NxpSoc.h > create mode 100644 Silicon/NXP/Include/DramInfo.h > create mode 100644 Silicon/NXP/Include/Library/IoAccessLib.h > create mode 100644 Silicon/NXP/LS1043A/Include/SocSerDes.h > create mode 100644 Silicon/NXP/LS1043A/LS1043A.dec > create mode 100644 Silicon/NXP/LS1043A/LS1043A.dsc.inc > create mode 100644 Silicon/NXP/Library/DUartPortLib/DUart.h > create mode 100644 Silicon/NXP/Library/DUartPortLib/DUartPortLib.c > create mode 100644 Silicon/NXP/Library/DUartPortLib/DUartPortLib.inf > create mode 100644 Silicon/NXP/Library/IoAccessLib/IoAccessLib.c > create mode 100644 Silicon/NXP/Library/IoAccessLib/IoAccessLib.inf > create mode 100644 Silicon/NXP/Library/MemoryInitPei/MemoryInitPeiLib.c > create mode 100644 Silicon/NXP/Library/MemoryInitPei/MemoryInitPeiLib.inf > create mode 100644 Silicon/NXP/Library/SocLib/Chassis.c > create mode 100644 Silicon/NXP/Library/SocLib/Chassis2/Soc.c > create mode 100644 Silicon/NXP/Library/SocLib/LS1043aSocLib.inf > create mode 100644 Silicon/NXP/Library/SocLib/NxpChassis.h > create mode 100644 Silicon/NXP/Library/SocLib/SerDes.c > create mode 100644 Silicon/NXP/NxpQoriqLs.dec > > -- > 1.9.1 >