From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web12.226.1570726144407208689 for ; Thu, 10 Oct 2019 09:49:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Ddw6HLfC; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f66.google.com with SMTP id r19so7699483wmh.2 for ; Thu, 10 Oct 2019 09:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0/6RfDuE2y9zGQ1w0xd/4bU9ggQVD1vsvCIqTSso7Ow=; b=Ddw6HLfC8tIh+1i8gkxiihKGoiRCR4pBsdEHGt1isBRXVl1qiqixUjaZRp8YP0SvPD mZpwzwUsDU1hsfJ/n2r77Ae1PuMxl2VL/wANodNBnyc3JDyHbNAnAub85oa/M9TvBJ3h qSvL394bv/3/iKYFArfhFH0TKpytfE61FWyJgS3Z/k7TU64gL/Hv+YG0ODuDrDCKZftO UnVX3duMWcp8OTtOu2OqvvOjFR1S2wnfy0bX0DQRcAAhWozO0ufxANcoPtk0f+zoHrWK zNcSKc1EnNm+OB2YlhVKIcxY3M+P5j0D4aoQ+Sp64TDIIo8LB33HmuEB/xb3o4i/BS5d Dqbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0/6RfDuE2y9zGQ1w0xd/4bU9ggQVD1vsvCIqTSso7Ow=; b=lmmxM++UgQWzYl7vv9V15P8Yhui8Yc0/QTipTgDYYKjw0vRQVnpEQ8WHNsaRLN0NSD aEN3+w/IjFmgwB/VwKJdCmxcXV+pngPtGwFb9GO8Chhmg43wtv0SXg1uZh49KLAhZmr/ TDVC6UkZRbSQhBd98KFqKN6kggOMSOpCX4pAN8Co95rT576DLvTir6FLP3+YLErZOI/C FwddUQuGtkUC/jABl8MCK0liF9bNm1ocL8DiWAcgjNrR0qwRKuaFAUIldmACYMmfhNIk BIbVxkwwPchXtwy5vomPF+HycZGRS7xF9yET1esysjetiMTXCuB5wJu1JxdvSNIe0JT2 0DbQ== X-Gm-Message-State: APjAAAWKqct/zyWTSx5Zveduyp9ber6eExCFsLYtu8wlxhh4bra69lmM DUvEX7ncHaPk6/FsM7AlFHrYHg== X-Google-Smtp-Source: APXvYqzBd2pqXJRBC90nxFtVxZZJQ7ezD7mUcRz9LsPQ5gmqvJsEzLRsgoxgO09pyaactvsJr9OFbQ== X-Received: by 2002:a05:600c:2c2:: with SMTP id 2mr8541944wmn.112.1570726142717; Thu, 10 Oct 2019 09:49:02 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y19sm6603482wmi.13.2019.10.10.09.49.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 09:49:01 -0700 (PDT) Date: Thu, 10 Oct 2019 17:49:00 +0100 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org Subject: Re: [edk2-platforms][PATCH v2 2/5] Platform/RPi3/RpiFirmwareDxe: Improve serial number population Message-ID: <20191010164900.GP25504@bivouac.eciton.net> References: <20191008123841.12952-1-pete@akeo.ie> <20191008123841.12952-3-pete@akeo.ie> <20191010084344.GT25504@bivouac.eciton.net> <766e6b6f-d788-e46e-e58f-84a2f851645c@akeo.ie> MIME-Version: 1.0 In-Reply-To: <766e6b6f-d788-e46e-e58f-84a2f851645c@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 10, 2019 at 01:41:20PM +0100, Pete Batard wrote: > It's a disagreement. And the same goes for 3/5 & 4/5. Please see the note I > wrote in 0/5 for the v2, because the cover letter this is usually the place > I try to clarify elements that may throw off a maintainer, and that don't > belong in a commit message. > > Not so sound flippant here, but as long as there isn't an MTV award for > "Most atomic codebase ever", I just don't have the time to split what I > consider to be frivolous commits. The reasoning behind that is that I > realistically don't consider that people are actually going to be thrown off > by a "while I was here I also fixed an obvious typo" that got added into an > existing commit or, most important, that even if they do, the amount of time > that is going to be collectively wasted by people who might be thrown of by > not having uber atomicity is not going to exceed the amount of time it will > cost *me* to split it. > > Therefore, while I do understand the desire to have an atomic commit > history, I'm afraid that if we can't strike a balance between how much extra > time contributors are expected to waste vs how atomic a *real-life* > codebase is enforced to be, if I have to split every little typo and > stylistic fix into yet another commit, I'm simply not going to bother fixing > typos or low hanging fruits I see any more. I understand, we all have a limited supply of time. Since I don't wish to start implementing different rules for different contributors, could I ask you to stop contributing typo and low hanging fruit fixes? Best Regards, Leif