From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web11.3715.1570748873982687864 for ; Thu, 10 Oct 2019 16:07:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=vFs+mnHP; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f66.google.com with SMTP id r17so8128778wme.0 for ; Thu, 10 Oct 2019 16:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ssxTu8gwCuMA8Hm1aWCiztOBP6iE2ChxpYLLxSy7scY=; b=vFs+mnHPpsersDC0Ns4fpCD/le0LZ+EUOA5JJ4wMYnisnksQS07P8vvIuVpuS6XtHy lfGzksmQ2JEhqn3NS9uEmQgq+Vtw9eueaX+DyDqfVL9S0oYJ0HyT5wi5A91f8K0sTWNv vf6WZQQ3A4oFrtz4TZ4ZwbwDA2OkBDnSNUEWmn4EMRlYriKU18PJHbcliqpr3hb69PK7 hHO2qXxyvOBf7s8FK6OfchWWMWHJ1dR6ubAntuGskQkm6zomLE0soe+SVpBdhqer6Nb4 vXKlG8NCEdanamzK5xhCABs9oC5RI72d7B19kXEuIpzw2pV+FjtEEzqSOUedQj29F4je 9ZDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ssxTu8gwCuMA8Hm1aWCiztOBP6iE2ChxpYLLxSy7scY=; b=fgI/naCLUEuM2jK9pzYi+xiefgsEJ2SewzizfCHtZSaBJrlS01Y49ra165bixqTI32 m+GhWZkE5g0E8NCftgSErnLhltu+3R25q2svEra3P7SgrM07LxuzA2UC/XAyqHtPwxeY 8ccQMicorv0qxlis5c4Ilu8TLp+yfo97X+EOLqHfP4s+Uob7MR/KlL9/i8DawbdSxJf7 D7GLCkdqLuxmvgaJeyOvyo36B5TeiZRO6EjgvawWXnr3avWwacUex2xfSJb+8KpUM6ag K0TDEOUgfScWc5W5O0R+6HJVi1okngDdhETZh31H1Qn9OY/QuUOysufXFJjuj51Y7zIz tJXw== X-Gm-Message-State: APjAAAXLsJcItcQL5Q4OxnKTyv9Ihq7jtONi6PCEaXt1udJVNvI7beU2 oec88YzBuCa3KPgmmjrKH/+CMg== X-Google-Smtp-Source: APXvYqxnk9Z60ZPU/JpCdhW6/oJFdz6CS3YZWbQcRoTGDJqcg+VHHzgjglvEdcOj8FHNfbGNPtzElQ== X-Received: by 2002:a1c:444:: with SMTP id 65mr641887wme.73.1570748872473; Thu, 10 Oct 2019 16:07:52 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 90sm9630476wrr.1.2019.10.10.16.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 16:07:51 -0700 (PDT) Date: Fri, 11 Oct 2019 00:07:50 +0100 From: "Leif Lindholm" To: Marcin Wojtas Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com Subject: Re: [edk2-platforms: PATCH v3 9/9] Marvell: Customize per-board SBMIOS strings Message-ID: <20191010230750.GY25504@bivouac.eciton.net> References: <1570686139-25182-1-git-send-email-mw@semihalf.com> <1570686139-25182-10-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1570686139-25182-10-git-send-email-mw@semihalf.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 10, 2019 at 07:42:19AM +0200, Marcin Wojtas wrote: > Now that the customization of Type1/2/3 SBMIOS > tables strings is possible, adjust them for all > supported boards. > > Signed-off-by: Marcin Wojtas > --- > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 4 ++++ > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 4 ++++ > Platform/Marvell/Cn913xDb/Cn913xDbA.dsc | 11 +++++++++++ > Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 5 +++++ > 4 files changed, 24 insertions(+) > > diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc > index 523e60e..3626967 100644 > --- a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc > +++ b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc > @@ -45,6 +45,10 @@ > # > ################################################################################ > [PcdsFixedAtBuild.common] > + #Platform description > + gMarvellTokenSpaceGuid.PcdProductPlatformName|"Armada 7040 DB\0" > + gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.5\0" Why have we ended up requiring explicit \0 in literal strings? This does not seem to be needed for (for example) gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor so why is it needed here? / Leif > + > #CP110 count > gMarvellTokenSpaceGuid.PcdMaxCpCount|1 > > diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc > index 4e6e62b..ce0c541 100644 > --- a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc > +++ b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc > @@ -45,6 +45,10 @@ > # > ################################################################################ > [PcdsFixedAtBuild.common] > + #Platform description > + gMarvellTokenSpaceGuid.PcdProductPlatformName|"Armada 8040 DB\0" > + gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.4\0" > + > #MPP > gMarvellTokenSpaceGuid.PcdMppChipCount|3 > > diff --git a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc > index 268c39c..bcc5158 100644 > --- a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc > +++ b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc > @@ -62,3 +62,14 @@ > ArmadaBoardDescLib|Platform/Marvell/Cn913xDb/BoardDescriptionLib/Cn9130DbABoardDescLib.inf > !endif > NonDiscoverableInitLib|Platform/Marvell/Cn913xDb/NonDiscoverableInitLib/NonDiscoverableInitLib.inf > + > +[PcdsFixedAtBuild.common] > + #Platform description > + !if $(CN9130) > + gMarvellTokenSpaceGuid.PcdProductPlatformName|"CN9130 DB-A\0" > + !elseif $(CN9131) > + gMarvellTokenSpaceGuid.PcdProductPlatformName|"CN9131 DB-A\0" > + !elseif $(CN9132) > + gMarvellTokenSpaceGuid.PcdProductPlatformName|"CN9132 DB-A\0" > + !endif > + gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.1\0" > diff --git a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc > index 2b42d75..f7d5a57 100644 > --- a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc > +++ b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc > @@ -46,6 +46,11 @@ > # > ################################################################################ > [PcdsFixedAtBuild.common] > + #Platform description > + gMarvellTokenSpaceGuid.PcdProductManufacturer|"SolidRun\0" > + gMarvellTokenSpaceGuid.PcdProductPlatformName|"Armada 8040 MacchiatoBin\0" > + gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.3\0" > + > #MPP > gMarvellTokenSpaceGuid.PcdMppChipCount|3 > > -- > 2.7.4 >