public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pete Batard" <pete@akeo.ie>
To: devel@edk2.groups.io
Cc: afish@apple.com, lersek@redhat.com, liming.gao@intel.com
Subject: [PATCH 0/1] MdeModulePkg/BdsDxe: Fix calling PlatformBootManagerWaitCallback on 0
Date: Fri, 11 Oct 2019 16:43:36 +0100	[thread overview]
Message-ID: <20191011154337.1652-1-pete@akeo.ie> (raw)

Independently of the OvmfPkg fix, I think Lazlo's fix is what we ultimately
want to have, as the logic of not wanting to get calls for progress updates
if the Timeout Pcd is zet to zero stands. Plus we want to handle the 0xFFFF
case.

Therefore I am submitting Lazlo's proposed patch as well, which, even if it
seems redundant, I don't think invalidates the OvmfPkg one, as a call that
may produce a division by zero should consider that case unless it can have
absolute certainty that it will never be called for the zero value, which I
don't think we can or should rely on here.

Laszlo Ersek (1):
  MdeModulePkg/BdsDxe: Fix calling PlatformBootManagerWaitCallback on 0

 MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

-- 
2.21.0.windows.1


             reply	other threads:[~2019-10-11 15:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 15:43 Pete Batard [this message]
2019-10-11 15:43 ` [PATCH 1/1] MdeModulePkg/BdsDxe: Fix calling PlatformBootManagerWaitCallback on 0 Pete Batard
2019-10-12  1:44   ` Liming Gao
2019-10-14 14:45     ` Laszlo Ersek
2019-10-15  0:17       ` [edk2-devel] " Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191011154337.1652-1-pete@akeo.ie \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox