From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mx.groups.io with SMTP id smtpd.web12.1947.1570808630994845625 for ; Fri, 11 Oct 2019 08:43:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=bcXfUTa0; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.48, mailfrom: pete@akeo.ie) Received: by mail-wr1-f48.google.com with SMTP id j18so12444266wrq.10 for ; Fri, 11 Oct 2019 08:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bRpjhdN+YGYJSJV7yHok0sMm74S0SMQBB9fTIeRczRM=; b=bcXfUTa03vpMmProz9A9P+PinQvbYR25i26dNNGAf+v98Bsn1WMAd0q04nxXnzXkEz 5+owfnLQwKzXBGhnfRBF4WCztHntWc6d2Aa5/07mlKE0vK+UN0H2Sjpw5HUo5IQByEnR QgiyRzh7TMTqkB9kpJBm5VJzCquwj99BzYKEYIU8lVQpZBAfBlGFK9vON8/FFK2GOuLC +IgDYmhEfXIDBfRTrqHty6EFwkQ+uxOofgNg0cXmJoP5smm/Sr+NL32l9g8NEvcEDR05 p2V5JLL9KGVW2GfcDKfUggUXVj1xGAcxBI2e1tlk5IKUus6rPxZWqSRzB5yYF/9L1KkG 2LzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bRpjhdN+YGYJSJV7yHok0sMm74S0SMQBB9fTIeRczRM=; b=XvldowO5NSsjM/qJleEQ2awOFHOXofFVz/gvjMeqNOTWUIPR/b/jRAHohr2M1FfU1C xUhLCj3xZ2MD6tG+ilzFjIXOMuRfti/TztEvm9fv65z7JaZZb3P7aIiSQUu0xmLfETfC 6uLA9br9+UOmso1+a2g1YLIJwZ7K4CdJ4alfB9qe4fkiory/16RDy1KymScdrebnxoL/ SldQ+tqvfD9/sQFD6NrKUnUmu9bXr4MN48heaveT9v5VjlAE6ICez8wgbpvgb9DKqM9w dtKe7XSDmLCIU1ybLH7xBXbdb5NKfv4nQshF8rD52H1Gym+C1PnXBlftTjWMCJGuzFDh Ncsw== X-Gm-Message-State: APjAAAWAwXnIIs8+BDU3SreR4BBYI0o0dR75qtVcgR4L2BwoWCzRY0TR M1+PJwKA27Xu1pFW3ZN04qSCT5S6uxM= X-Google-Smtp-Source: APXvYqxUpZG1UAJfKauu2VE2NZCpQ5l7GAHigymxXZQr/FY0Uy638Oeu/sh5f1WaRGx+syS+b5Jo7g== X-Received: by 2002:adf:dcc6:: with SMTP id x6mr13550458wrm.81.1570808629318; Fri, 11 Oct 2019 08:43:49 -0700 (PDT) Return-Path: Received: from localhost.localdomain ([84.203.40.122]) by smtp.gmail.com with ESMTPSA id e3sm9436052wme.39.2019.10.11.08.43.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Oct 2019 08:43:48 -0700 (PDT) From: "Pete Batard" To: devel@edk2.groups.io Cc: afish@apple.com, lersek@redhat.com, liming.gao@intel.com Subject: [PATCH 0/1] MdeModulePkg/BdsDxe: Fix calling PlatformBootManagerWaitCallback on 0 Date: Fri, 11 Oct 2019 16:43:36 +0100 Message-Id: <20191011154337.1652-1-pete@akeo.ie> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Independently of the OvmfPkg fix, I think Lazlo's fix is what we ultimately want to have, as the logic of not wanting to get calls for progress updates if the Timeout Pcd is zet to zero stands. Plus we want to handle the 0xFFFF case. Therefore I am submitting Lazlo's proposed patch as well, which, even if it seems redundant, I don't think invalidates the OvmfPkg one, as a call that may produce a division by zero should consider that case unless it can have absolute certainty that it will never be called for the zero value, which I don't think we can or should rely on here. Laszlo Ersek (1): MdeModulePkg/BdsDxe: Fix calling PlatformBootManagerWaitCallback on 0 MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) -- 2.21.0.windows.1