From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org,
jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com
Subject: Re: [edk2-platforms: PATCH v4 9/9] Marvell: Customize per-board SBMIOS strings
Date: Mon, 14 Oct 2019 09:44:10 +0100 [thread overview]
Message-ID: <20191014084410.GB25504@bivouac.eciton.net> (raw)
In-Reply-To: <1570807231-4155-10-git-send-email-mw@semihalf.com>
On Fri, Oct 11, 2019 at 05:20:31PM +0200, Marcin Wojtas wrote:
> Now that the customization of Type1/2/3 SBMIOS
> tables strings is possible, adjust them for all
> supported boards.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 4 ++++
> Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 4 ++++
> Platform/Marvell/Cn913xDb/Cn913xDbA.dsc | 11 +++++++++++
> Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 5 +++++
> 4 files changed, 24 insertions(+)
>
> diff --git a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
> index 523e60e..0c2c748 100644
> --- a/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
> +++ b/Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc
> @@ -45,6 +45,10 @@
> #
> ################################################################################
> [PcdsFixedAtBuild.common]
> + #Platform description
> + gMarvellTokenSpaceGuid.PcdProductPlatformName|"Armada 7040 DB"
> + gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.5"
> +
> #CP110 count
> gMarvellTokenSpaceGuid.PcdMaxCpCount|1
>
> diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> index 4e6e62b..40aeb62 100644
> --- a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> +++ b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc
> @@ -45,6 +45,10 @@
> #
> ################################################################################
> [PcdsFixedAtBuild.common]
> + #Platform description
> + gMarvellTokenSpaceGuid.PcdProductPlatformName|"Armada 8040 DB"
> + gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.4"
> +
> #MPP
> gMarvellTokenSpaceGuid.PcdMppChipCount|3
>
> diff --git a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
> index 3f6b70e..a754c3e 100644
> --- a/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
> +++ b/Platform/Marvell/Cn913xDb/Cn913xDbA.dsc
> @@ -62,3 +62,14 @@
> ArmadaBoardDescLib|Platform/Marvell/Cn913xDb/BoardDescriptionLib/Cn9130DbABoardDescLib.inf
> !endif
> NonDiscoverableInitLib|Platform/Marvell/Cn913xDb/NonDiscoverableInitLib/NonDiscoverableInitLib.inf
> +
> +[PcdsFixedAtBuild.common]
> + #Platform description
> + !if $(CN9130)
> + gMarvellTokenSpaceGuid.PcdProductPlatformName|"CN9130 DB-A"
> + !elseif $(CN9131)
> + gMarvellTokenSpaceGuid.PcdProductPlatformName|"CN9131 DB-A"
> + !elseif $(CN9132)
> + gMarvellTokenSpaceGuid.PcdProductPlatformName|"CN9132 DB-A"
> + !endif
> + gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.1"
> diff --git a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc
> index 2b42d75..fec0cc2 100644
> --- a/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc
> +++ b/Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc
> @@ -46,6 +46,11 @@
> #
> ################################################################################
> [PcdsFixedAtBuild.common]
> + #Platform description
> + gMarvellTokenSpaceGuid.PcdProductManufacturer|"SolidRun"
> + gMarvellTokenSpaceGuid.PcdProductPlatformName|"Armada 8040 MacchiatoBin"
> + gMarvellTokenSpaceGuid.PcdProductVersion|"Rev. 1.3"
> +
> #MPP
> gMarvellTokenSpaceGuid.PcdMppChipCount|3
>
> --
> 2.7.4
>
prev parent reply other threads:[~2019-10-14 8:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 15:20 [edk2-platforms: PATCH v4 0/9] Marvell Octeon CN913X SoC family support Marcin Wojtas
2019-10-11 15:20 ` [edk2-platforms: PATCH v4 1/9] Marvell/Armada7k8k: Fix 32-bit compilation Marcin Wojtas
2019-10-11 15:20 ` [edk2-platforms: PATCH v4 2/9] Marvell/Cn9130Db: Add ACPI tables Marcin Wojtas
2019-10-11 15:20 ` [edk2-platforms: PATCH v4 3/9] Marvell/Cn9130Db: Introduce board support Marcin Wojtas
2019-10-11 15:20 ` [edk2-platforms: PATCH v4 4/9] Marvell/Library: ArmadaSoCDescLib/MppLib: Extend Xenon information Marcin Wojtas
2019-10-11 15:20 ` [edk2-platforms: PATCH v4 5/9] Marvell/Library: IcuLib: Fix debug information Marcin Wojtas
2019-10-11 15:20 ` [edk2-platforms: PATCH v4 6/9] Marvell/Cn9131Db: Introduce board support Marcin Wojtas
2019-10-11 15:20 ` [edk2-platforms: PATCH v4 7/9] Marvell/Cn9132Db: " Marcin Wojtas
2019-10-11 15:20 ` [edk2-platforms: PATCH v4 8/9] Marvell/Drivers: SmbiosPlatformDxe: Load SMBIOS strings from PCD Marcin Wojtas
2019-10-14 8:43 ` Leif Lindholm
2019-10-11 15:20 ` [edk2-platforms: PATCH v4 9/9] Marvell: Customize per-board SBMIOS strings Marcin Wojtas
2019-10-14 8:44 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014084410.GB25504@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox