From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web12.246.1571077419916238438 for ; Mon, 14 Oct 2019 11:23:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=t/QkeJ+y; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f67.google.com with SMTP id a6so18220668wma.5 for ; Mon, 14 Oct 2019 11:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2ds4HIdEKfiAmg2ioVs0UXLc6rnARlKuA7kfiC7BbFA=; b=t/QkeJ+yzh4VuxIk6BgTr46wN9xvsdezhYKgnBYeVH44VLkic5skQdwrgL21RDo3I0 7QYc0C966/H9JrAh/TxSqr2md7GYbnSARmOIup6QNFJrcbQrtN097eBESbczbmLSkvt0 GjdzZ2Q+9/p5Z4NotrDwJkn0WnfXJCazABf4KkI+nOa5mH3g4iZ+syo1QV014E8v4p/t Or29Dice4Zo5MdSZBSEWJpAMMxWQsOIltNpBGQMklalUSC9UpwdVFNj9Cw+V5Wi/bmW4 4EU2F2M7IpTRKNF7l/u4aRh1uD7LEowdw+DZqrWNFh/oi9GtR46wEbg+OJu52reVA/OA kpjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2ds4HIdEKfiAmg2ioVs0UXLc6rnARlKuA7kfiC7BbFA=; b=n8jKK5tddDOI9Jjx5I5nT35LtYJeC5FbaCxPFurTNd9ux2vAIaS3Si/IJr3iZ/GrVD DAjh7jT9lygp9WpAM3wXgfcnxjWJG2HTdoEdCznJUi/wpPiCp0HNEn7hI91jnnmkYOHC PErezutB5Z4Ijb7tTHZH3SBycz2mztNXZUi1dsfiZfpn6J3F2XmoVluI/FkDvx/vlU7Z SO0TN7mjDnG2EwIJy4jy0y2ZTqxCqgZT58ACii729VzoPBNrcpxwgCpvDzPFWw9hwDL/ 5J+mPaRM3OAnUXRkjSkZiQnfSsYY0bL2wtZNcxg/MJ37U52RD0/RVf523uVZyJxyQbWZ /3Jw== X-Gm-Message-State: APjAAAXfpAtZiGyk8Awrz+Fn1PQ+etMcJTRj8SNbODVWrKXjAzObPCn+ N0SCEvO4W6eN3Ywi+5eLFKs9SqwBob8= X-Google-Smtp-Source: APXvYqxHlpMBq5WlLfOwfc0LCVGGfhOsdyMXLg9uECWYEpwTz3RzUR2VB//tn/DpmGemubofBjWUnQ== X-Received: by 2002:a1c:b654:: with SMTP id g81mr15771942wmf.172.1571077417977; Mon, 14 Oct 2019 11:23:37 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 5sm18669786wrk.86.2019.10.14.11.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2019 11:23:36 -0700 (PDT) Date: Mon, 14 Oct 2019 19:23:35 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, abner.chang@hpe.com Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 07/29] MdePkg/BaseLib: BaseLib for RISC-V RV64 Processor. Message-ID: <20191014182335.GE25504@bivouac.eciton.net> References: <1569198715-31552-1-git-send-email-abner.chang@hpe.com> <1569198715-31552-8-git-send-email-abner.chang@hpe.com> <20190926225639.GI25504@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 14, 2019 at 04:47:30PM +0000, Abner Chang wrote: > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Leif Lindholm > > Sent: Friday, September 27, 2019 6:57 AM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 07/29] > > MdePkg/BaseLib: BaseLib for RISC-V RV64 Processor. > > > > On Mon, Sep 23, 2019 at 08:31:32AM +0800, Abner Chang wrote: > > > Add RISC-V RV64 BaseLib functions. > > > > > > Signed-off-by: Abner Chang > > > diff --git a/MdePkg/Library/BaseLib/RiscV64/Unaligned.c > > > b/MdePkg/Library/BaseLib/RiscV64/Unaligned.c > > > new file mode 100644 > > > index 0000000..012d913 > > > --- /dev/null > > > +++ b/MdePkg/Library/BaseLib/RiscV64/Unaligned.c > > > > We do need to fix BaseLib/Unaligned.c (as well as the associated definitions > > in header file), but having a separate implementation for RISCV does not > > make sense. > > Leif, not quite understand this. So you would like RISCV to use generic Unaligned.c? Yes please. / Leif