From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web12.1244.1571128517737953445 for ; Tue, 15 Oct 2019 01:35:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=j6GDv32y; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f67.google.com with SMTP id z9so22707570wrl.11 for ; Tue, 15 Oct 2019 01:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+ti/toYw0MASykPbj2vmM19dEt+xUnyYyNszxxeh2Og=; b=j6GDv32y68NBuLUezgK6dGLvZQx+C9DtDLrXuOgk8KEihVCyWqc4ociAFU1Mc+dIOc QVlgq54kQSFMkpEpG3NsaDeipPWuZQRK20YjZupAUicsG/5DNCldtbMwtSHRlVtzfNY0 eRmv/VrJ4Cc/T+x56EPGUT5kx2ALiiPRHiHhZwJF1/EBLsWeloxiftvfC1IGlVI3cuqP mdNtSMz1ETo9VDl+YVuw23XA/Uv3qcgCr/pcG7yWhA8sAFH9Xwr7f+pNdlb6LB2KnOqs WGwroezXaHv0Q30thpDdM7lRUcKQO8p8anDxNm9EclYvDCCgh+PSYM0W11ZknThvLax4 B2SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+ti/toYw0MASykPbj2vmM19dEt+xUnyYyNszxxeh2Og=; b=Kfmci3XK2f5lJfkTfgv0E4DHbx8UO0LqrFi1Uw/85kAdXQ0mDQqWu3y6Sou/ugsQEC 88eXzhR+Icgzg0STmHv2OwNi0uvDouY+vGN+4TQtRtsxIn2N5IYfICFh6Zaz3TQjbLjX ml5FIwoYJma42nnQIBuaP++s30jbgBuxDkYhehsbj+gkI01FnhC5hdGKEngFnCrno/c8 f3pFwTBAYXSdi7FMSRQfy2OReIHMH7EacLW9wtJR4e//69+r6HPJmi8a5IBCKFAdsspX 9IwYlVXMRmhpfHkG+ZZ9pMrqDmIT/oVsGqJftu1HdmFr/zYpHevpeyzQ//dEdBmg3TwL v9Rg== X-Gm-Message-State: APjAAAVOtby/cvEPWDCR8QoSXhfGAPQBI27a17aiXRr9PJChM6Xrcib0 8A/q0pdcWrI+I46864Sk2jACCw== X-Google-Smtp-Source: APXvYqyeKrs6lDOeFq+ID4hP6R21boKTtD08j9c7whVHsnb/uSEex8Te16u4c+boH5AJAU+YcANmTw== X-Received: by 2002:adf:9403:: with SMTP id 3mr31441592wrq.281.1571128516108; Tue, 15 Oct 2019 01:35:16 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g13sm17567573wrm.42.2019.10.15.01.35.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2019 01:35:15 -0700 (PDT) Date: Tue, 15 Oct 2019 09:35:13 +0100 From: "Leif Lindholm" To: "Chang, Abner (HPS SW/FW Technologist)" Cc: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 18/29] RiscVPkg/Library: Add EDK2 RISC-V OpenSBI library. Message-ID: <20191015083513.GF25504@bivouac.eciton.net> References: <1569198715-31552-1-git-send-email-abner.chang@hpe.com> <1569198715-31552-20-git-send-email-abner.chang@hpe.com> <20190930200331.GC25504@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 15, 2019 at 01:21:35AM +0000, Chang, Abner (HPS SW/FW Technologist) wrote: > > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Tuesday, October 1, 2019 4:04 AM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 18/29] > > RiscVPkg/Library: Add EDK2 RISC-V OpenSBI library. > > > > On Mon, Sep 23, 2019 at 08:31:44AM +0800, Abner Chang wrote: > > > EDK2 RISC-V OpenSBI library which pull in external source files under > > > RiscVPkg/opensbi to the build process. > > > > > > Signed-off-by: Abner Chang > > > --- > > > .../Library/RiscVOpensbiLib/RiscVOpensbiLib.inf | 52 > > ++++++++++++++++++++++ > > > 1 file changed, 52 insertions(+) > > > create mode 100644 > > > RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf > > > > > > diff --git a/RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf > > > b/RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf > > > new file mode 100644 > > > index 0000000..640ffba > > > --- /dev/null > > > +++ b/RiscVPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf > > > @@ -0,0 +1,52 @@ > > > +## @file > > > +# RISC-V Opensbi Library Instance. > > > +# > > > +# Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All > > > +rights reserved.
# # SPDX-License-Identifier: > > > +BSD-2-Clause-Patent # ## > > > + > > > +[Defines] > > > + INF_VERSION = 0x0001001b > > > + BASE_NAME = RiscVOpensbiLib > > > + FILE_GUID = 6EF0C812-66F6-11E9-93CE-3F5D5F0DF0A7 > > > + MODULE_TYPE = BASE > > > + VERSION_STRING = 1.0 > > > + LIBRARY_CLASS = RiscVOpensbiLib > > > + > > > +[Sources] > > > + ../../opensbi/lib/sbi/riscv_asm.c > > > > Please move the opensbi directory to here instead. > > > This is good. Now [Includes] in RiscVPkg.dec looks like this, > [Includes] > Library/RiscvOpensbiLib/opensbi > Library/RiscvOpensbiLib/opensbi/include Exactly, thanks! / Leif