From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"Gao, Zhichao" <zhichao.gao@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [edk2-devel] [PATCH V2 3/8] MdePkg/UefiDebugLibStdErr: Decrease the name collisions
Date: Tue, 15 Oct 2019 12:20:40 +0100 [thread overview]
Message-ID: <20191015112040.GM25504@bivouac.eciton.net> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9C9DA8C@ORSMSX113.amr.corp.intel.com>
(Ancient thread, responding due to finding this when looking at recent
BZ activity.)
On Wed, Apr 24, 2019 at 05:31:36PM +0000, Michael D Kinney wrote:
> I see no issues with using 'static' on more symbols.
>
> I am not sure how to enforce it, so it would be a good
> recommendation for code style and a good recommendation
> for a code reviews.
For GCC family, -Wmissing-prototypes is a pretty good way of catching
at least functions that should be static. Adding that to default build
flags would be a way of preventing new such code being added ... after
we had gone through and made sure all current code built with it...
Regards,
Leif
next prev parent reply other threads:[~2019-10-15 11:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 4:58 [PATCH V2 0/8] Decrease the name collisions Gao, Zhichao
2019-04-24 4:58 ` [PATCH V2 1/8] MdePkg/UefiDebugLibConOut: " Gao, Zhichao
2019-04-24 4:58 ` [PATCH V2 2/8] MdePkg/UefiDebugLibDebugPortProtocol: " Gao, Zhichao
2019-04-24 4:58 ` [PATCH V2 3/8] MdePkg/UefiDebugLibStdErr: " Gao, Zhichao
2019-04-24 8:07 ` [edk2-devel] " Ard Biesheuvel
2019-04-24 16:59 ` Michael D Kinney
2019-04-24 17:09 ` Ard Biesheuvel
2019-04-24 17:31 ` Michael D Kinney
2019-04-24 17:51 ` Ard Biesheuvel
2019-10-15 11:20 ` Leif Lindholm [this message]
2019-04-26 16:49 ` Laszlo Ersek
2019-04-29 16:40 ` Michael D Kinney
2019-04-30 9:43 ` Laszlo Ersek
2019-04-24 4:58 ` [PATCH V2 4/8] IntelFrameworkModulePkg: " Gao, Zhichao
2019-04-24 4:58 ` [PATCH V2 5/8] MdeModulePkg/FirmwarePerformanceDxe: " Gao, Zhichao
2019-04-24 4:58 ` [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: " Gao, Zhichao
2019-04-24 5:19 ` Chiu, Chasel
2019-04-24 5:27 ` Nate DeSimone
2019-04-24 4:58 ` [PATCH V2 7/8] IntelFrameworkModulePkg: " Gao, Zhichao
2019-04-24 4:58 ` [PATCH V2 8/8] MdeModulePkg/StatusCodeHandlerRuntimeDxe: " Gao, Zhichao
2019-04-24 11:16 ` [PATCH V2 0/8] " Laszlo Ersek
2019-04-25 7:00 ` Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015112040.GM25504@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox