From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web10.2028.1571138444098750287 for ; Tue, 15 Oct 2019 04:20:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Soriy3bh; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f67.google.com with SMTP id j11so23394458wrp.1 for ; Tue, 15 Oct 2019 04:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Zrvb4UsNW3ADJ0CLrB1lw+mynj0e/5n0vGZ3IW+R4kc=; b=Soriy3bh4Z8b5DHOjFo1M5083wNCe+up+OEDJfIDkf2+4OcqJLua5bMsYoACoBLH3d wEggc//FMShKcPuelbh/unFr+U/byQzOfmkP9xXM867kDcSFAU3egXy1nGepmEX4jMKB CSP4zxkEpY3M+b6u3oWsb1O1u4Lk3knCN/0i6rZY4Eoyabnf3XyRGvlQOvlVos4jJgh8 y6Hi2RcpuVk5ha7+IMRhoIjyBZ0rvTsOUBsvkL5DMlUmcZGvKE6aOeXRrPIeCX7t3I3h H4+oSnL5folclQT2DoBF27mkXLAkVtaffGyzEwGy7s719m48Oc7+Hgy0RfMmIT0jBzYn lK1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Zrvb4UsNW3ADJ0CLrB1lw+mynj0e/5n0vGZ3IW+R4kc=; b=d/VmWYCbZBpfng/cJ9+XJVa/bx7xt/BAZjwR/UU2W4RuSbIPR/BanGS1giNdEXHGxo Mci9R504dozAvbrGDABr9+GJGvmDtmend0JLGXXQOR9BquKdMnYLuBCQ2XLYW1T+JdOI STqlcBPUZnM2DsI9AfyVKEW+863n8i5mVCMYg4MUf/R0PpaUW9aNFf1RVJAqo2S5RFzC EtAZQfHLa/rGZnm5TUoG7OGNAya5TaJ7d4otT78jP8PBbKZeyINcJYXtBBpNEXVJgdnf gR2I9VN68mwTjKl3c1f7ksoc5UdXAF3e56QgXuXgQeRlWl6iQsmniTGN20RLexiV2+S/ 5AxA== X-Gm-Message-State: APjAAAUrE7PmoOe3R4X0YpGJaL/gslGZBL4o1vucHkfRI2fBjwoLK1t0 V/smgScZFG49pFZwm3Xz5FEtJgcMxjo= X-Google-Smtp-Source: APXvYqxRTRPlQs6K23Ql3KDMN0X/gB3qMocq+UGIN4Fa1bklREmoIYni1rqCDCEtbU8m/LovCwclxA== X-Received: by 2002:adf:a506:: with SMTP id i6mr11355557wrb.159.1571138442283; Tue, 15 Oct 2019 04:20:42 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t13sm45488459wra.70.2019.10.15.04.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2019 04:20:41 -0700 (PDT) Date: Tue, 15 Oct 2019 12:20:40 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: "ard.biesheuvel@linaro.org" , "Gao, Zhichao" , Laszlo Ersek , "Gao, Liming" , "Bi, Dandan" Subject: Re: [edk2-devel] [PATCH V2 3/8] MdePkg/UefiDebugLibStdErr: Decrease the name collisions Message-ID: <20191015112040.GM25504@bivouac.eciton.net> References: <20190424045827.19348-1-zhichao.gao@intel.com> <20190424045827.19348-4-zhichao.gao@intel.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline (Ancient thread, responding due to finding this when looking at recent BZ activity.) On Wed, Apr 24, 2019 at 05:31:36PM +0000, Michael D Kinney wrote: > I see no issues with using 'static' on more symbols. > > I am not sure how to enforce it, so it would be a good > recommendation for code style and a good recommendation > for a code reviews. For GCC family, -Wmissing-prototypes is a pretty good way of catching at least functions that should be static. Adding that to default build flags would be a way of preventing new such code being added ... after we had gone through and made sure all current code built with it... Regards, Leif