From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Pete Batard <pete@akeo.ie>
Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org
Subject: Re: [edk2-platforms][PATCH v3 0/5] Various SMBIOS improvements
Date: Tue, 15 Oct 2019 21:00:18 +0100 [thread overview]
Message-ID: <20191015200018.GR25504@bivouac.eciton.net> (raw)
In-Reply-To: <20191011110746.1952-1-pete@akeo.ie>
On Fri, Oct 11, 2019 at 12:07:41PM +0100, Pete Batard wrote:
> Changes from v2:
> - Consistent use of curly brackets for if statements
> - Remove unused variables that may produce an issue with git bisect
> - Use gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor to populate vendor
>
> Note that 5/5, which has been R-b, is unchanged.
For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 48a95de81ede..2a4e369d588e.
Thanks!
/
Leif
> Pete Batard (5):
> Platform/RPi3/RpiFirmwareDxe: Add more query functions
> Platform/RPi3/RpiFirmwareDxe: Improve serial number population
> Platform/RPi3/PlatformSmbiosDxe: Improve population of SMBIOS entries
> Platform/RPi3/PlatformSmbiosDxe: Populate BIOS major/minor from PCD
> Platform/RPi3/PlatformSmbiosDxe: Derive RAM size from board revision
>
> Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 198 ++++++++++++--------
> Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf | 2 +
> Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 167 ++++++++++++++++-
> Platform/RaspberryPi/RPi3/Include/Protocol/RpiFirmware.h | 58 ++++--
> Platform/RaspberryPi/RPi3/RPi3.dsc | 4 +-
> 5 files changed, 333 insertions(+), 96 deletions(-)
>
> --
> 2.21.0.windows.1
>
prev parent reply other threads:[~2019-10-15 20:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 11:07 [edk2-platforms][PATCH v3 0/5] Various SMBIOS improvements Pete Batard
2019-10-11 11:07 ` [edk2-platforms][PATCH v3 1/5] Platform/RPi3/RpiFirmwareDxe: Add more query functions Pete Batard
2019-10-14 9:55 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-10-11 11:07 ` [edk2-platforms][PATCH v3 2/5] Platform/RPi3/RpiFirmwareDxe: Improve serial number population Pete Batard
2019-10-11 11:07 ` [edk2-platforms][PATCH v3 3/5] Platform/RPi3/PlatformSmbiosDxe: Improve population of SMBIOS entries Pete Batard
2019-10-11 11:07 ` [edk2-platforms][PATCH v3 4/5] Platform/RPi3/PlatformSmbiosDxe: Populate BIOS major/minor from PCD Pete Batard
2019-10-11 11:07 ` [edk2-platforms][PATCH v3 5/5] Platform/RPi3/PlatformSmbiosDxe: Derive RAM size from board revision Pete Batard
2019-10-14 10:01 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-10-14 11:44 ` Pete Batard
2019-10-14 11:53 ` Philippe Mathieu-Daudé
2019-10-14 12:03 ` Pete Batard
2019-10-14 12:08 ` Philippe Mathieu-Daudé
2019-10-14 12:17 ` Leif Lindholm
2019-10-15 20:00 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015200018.GR25504@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox