From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web12.1287.1571169622047415873 for ; Tue, 15 Oct 2019 13:00:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=sZFcd3gQ; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f65.google.com with SMTP id o28so2706632wro.7 for ; Tue, 15 Oct 2019 13:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mC0FXRypejMsQ+vymFIcz2K1w6t95frj914G6Y3TqNc=; b=sZFcd3gQyOIzuDrJ/BCuD6vIOrwTIkwshJRxZeqR1Uw8850GgmSdnhqwJhJpglwIgK ufW9qkeSJWPws9hN0981HDi+0KYcDez0Q6L9CZW1zlC4pTfPu/O5Sx1/uYEHiRs/etsc vXhExvLkiY5UfnpalQHs757DqLy9/PrAAhMxt3V4HjSDbGPj0VjJ8gWDkSIUr2hQ20Mw MeXKxApkmuG/cec5qQAlfKAZ3cuEVR+HcjPvTnED73DHLbSm0bL7qsGJ9uz8EjAyITwH JC6jHwmgzdglqlt/IMbTyAmpoznsybnuj4FFsXVTCQWyON9XyZVFA5oCmreaVCGQX2qr ZKuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mC0FXRypejMsQ+vymFIcz2K1w6t95frj914G6Y3TqNc=; b=OhxWS7aETRfQpUGk4Ae6SsMyovP6+FawivIBlwJLPcjG3Xhf+cjCkRn01ixB8fHbHc 4N5z26x6d1qTGcnIfT2YCVFlNJVfc6GZiJ4OBeo7Faqy9MzVI0fRLwbgAkcB8Yutrr6o wKJJ3kT/QvvRY8zUFG1V0uGD8b58Yr6TyVKmuyuv/B+P+rDIYTu2+rfyk7hnI9IoR26g tPphcSWG22fEEDK63hJbErF9nWFhQ82Ow2mLBvT7zF6WOleDyOYXErL9/RK5AojDFBcf SjiqS05vy4DVxTSP9gKZn8pj36u8xuEsHJS5vsNTyDiJATAxJscQESJmVeSZVy0S1IZa g6fg== X-Gm-Message-State: APjAAAUMFvGhFswg3C9Xtj2vHj7xJTsKsT32wNsw0CUjBro1q+iBCkdf cgqAgRhlQTwkXJgIMzsI2YIgTQ== X-Google-Smtp-Source: APXvYqyLtdoEHRzQaivr5MQijCKJXs//fLq25BUZSkaP4/MOdnPpwZ/DVdNjJ7jBGueK5sPj8R5uiw== X-Received: by 2002:a5d:5309:: with SMTP id e9mr638881wrv.276.1571169620626; Tue, 15 Oct 2019 13:00:20 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a3sm217133wmj.35.2019.10.15.13.00.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2019 13:00:19 -0700 (PDT) Date: Tue, 15 Oct 2019 21:00:18 +0100 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org Subject: Re: [edk2-platforms][PATCH v3 0/5] Various SMBIOS improvements Message-ID: <20191015200018.GR25504@bivouac.eciton.net> References: <20191011110746.1952-1-pete@akeo.ie> MIME-Version: 1.0 In-Reply-To: <20191011110746.1952-1-pete@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 11, 2019 at 12:07:41PM +0100, Pete Batard wrote: > Changes from v2: > - Consistent use of curly brackets for if statements > - Remove unused variables that may produce an issue with git bisect > - Use gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor to populate vendor > > Note that 5/5, which has been R-b, is unchanged. For the series: Reviewed-by: Leif Lindholm Pushed as 48a95de81ede..2a4e369d588e. Thanks! / Leif > Pete Batard (5): > Platform/RPi3/RpiFirmwareDxe: Add more query functions > Platform/RPi3/RpiFirmwareDxe: Improve serial number population > Platform/RPi3/PlatformSmbiosDxe: Improve population of SMBIOS entries > Platform/RPi3/PlatformSmbiosDxe: Populate BIOS major/minor from PCD > Platform/RPi3/PlatformSmbiosDxe: Derive RAM size from board revision > > Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 198 ++++++++++++-------- > Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf | 2 + > Platform/RaspberryPi/RPi3/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 167 ++++++++++++++++- > Platform/RaspberryPi/RPi3/Include/Protocol/RpiFirmware.h | 58 ++++-- > Platform/RaspberryPi/RPi3/RPi3.dsc | 4 +- > 5 files changed, 333 insertions(+), 96 deletions(-) > > -- > 2.21.0.windows.1 >