Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3/PlatformSmbiosDxe: Fix use of invalid debug facility

["Leif Lindholm" <leif.lindholm@linaro.org>]

On Wed, Oct 16, 2019 at 01:56:15PM +0200, Philippe Mathieu-Daudé wrote:
> On 10/16/19 1:43 PM, Pete Batard wrote:
> > DEBUG_WARNING was invalid. DEBUG_WARN is the proper channel name to use.
> 
> Oops.

+1

> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

And
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as bd26e4137525.

Thanks Pete.

/
    Leif
> 
> > 
> > Signed-off-by: Pete Batard <pete@akeo.ie>
> > ---
> >   Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c b/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
> > index 5abc82b8d363..c72a749b6a2a 100644
> > --- a/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
> > +++ b/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c
> > @@ -874,7 +874,7 @@ MemArrMapInfoUpdateSmbiosType19 (
> >     mMemArrMapInfoType19.EndingAddress = 256 * 1024;
> >     Status = mFwProtocol->GetModelRevision (&BoardRevision);
> >     if (Status != EFI_SUCCESS) {
> > -    DEBUG ((DEBUG_WARNING, "Couldn't get the board memory size - defaulting to 256 MB: %r\n", Status));
> > +    DEBUG ((DEBUG_WARN, "Couldn't get the board memory size - defaulting to 256 MB: %r\n", Status));
> >     } else {
> >       // www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md
> >       // Bits [20-22] indicate the amount of memory starting with 256MB (000b)
> > 
>