From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web11.4834.1571232245620495117 for ; Wed, 16 Oct 2019 06:24:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=jTZQPK68; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f65.google.com with SMTP id f22so2767418wmc.2 for ; Wed, 16 Oct 2019 06:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=pkf3LVjHy71j6CKfiW6EKTh+iGz0izwZw252JBfr/5c=; b=jTZQPK68qwlocmFQe7kYbsrMsRViI56E9RH91RkXmdS6lGLvXph4GMf/jMbIx5dypS 03PanGXAWqfBFJYRcaeiOXi5ppyDlvam4d24YV6QMJ8wtBaPGCzn7vRy3EycEJd3PwAB DydC86eK/lRFqrrnsh82xFXCcaCmDMk472ljYuwBpAq6UDUaWTacRsq8t6141zErp/TM 9a+zrvKQVjQ5YTRgycKOsZXb1wSZr3SdsKNRjwng1Is6hP9IfXHJ+2ungiA9vsmdjvDX GmHy46+H4s3lpPzVIVJior6pC/nRLEJBXDfkqPpJPa4Ua2X9/pbOjR9qTKTOLBu/EtA0 pbwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=pkf3LVjHy71j6CKfiW6EKTh+iGz0izwZw252JBfr/5c=; b=bpqkhGoQ47RCqK7Z1MDpTYxbLGPvsR5tL+54zSvrRtwWft1jsf2IOWdiUnox9agvqY BAUcEkKtdjM5oTyQPDG79+ZIM1ahzXHRgRCHioATpncuuZEIamZiE2ONBNcumF7d72tE CyxVSQO3WUPKhe6DLkFIc88fW4V0SFVxt1RpM0BkPR1/JgqbY1nynfgPjGqyGqS8jQui mljQpoRNlJgknYNEFqZXOmuRS4tAJQdwlYhxPRbYSgdniZT+FjkRDTtidZwgl4FudbgU HBfNvii+7cPtTIBgpu5JWfmL1ivsktcI2//btUn+Cle5Pp5TP5nHQ++3HNo+cL1wq6eD Lm7g== X-Gm-Message-State: APjAAAUFmIUMJDLGWXO81v1ZiRwMRo8uUnMw2HFIYUV52A19nLNIlkMt f6P2CPsCLm1xdyFn3dgtwBB7yQ== X-Google-Smtp-Source: APXvYqyA02fUUVrzSIHUlXqD/uQ05NpuMTHIZaqNFYcTFBvpMlqqvyp287eyg29Y7oXKPv3VwBd67g== X-Received: by 2002:a7b:cf0d:: with SMTP id l13mr3319065wmg.47.1571232244083; Wed, 16 Oct 2019 06:24:04 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g185sm2842959wme.10.2019.10.16.06.24.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 06:24:03 -0700 (PDT) Date: Wed, 16 Oct 2019 14:24:01 +0100 From: "Leif Lindholm" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: devel@edk2.groups.io, pete@akeo.ie, ard.biesheuvel@linaro.org Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi3/PlatformSmbiosDxe: Fix use of invalid debug facility Message-ID: <20191016132401.GS25504@bivouac.eciton.net> References: <20191016114341.10732-1-pete@akeo.ie> <0d98e7b4-b959-7bb6-e314-c4b2cbc6c7e6@redhat.com> MIME-Version: 1.0 In-Reply-To: <0d98e7b4-b959-7bb6-e314-c4b2cbc6c7e6@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Oct 16, 2019 at 01:56:15PM +0200, Philippe Mathieu-Daudé wrote: > On 10/16/19 1:43 PM, Pete Batard wrote: > > DEBUG_WARNING was invalid. DEBUG_WARN is the proper channel name to use. > > Oops. +1 > Reviewed-by: Philippe Mathieu-Daude And Reviewed-by: Leif Lindholm Pushed as bd26e4137525. Thanks Pete. / Leif > > > > > Signed-off-by: Pete Batard > > --- > > Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c b/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c > > index 5abc82b8d363..c72a749b6a2a 100644 > > --- a/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c > > +++ b/Platform/RaspberryPi/RPi3/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c > > @@ -874,7 +874,7 @@ MemArrMapInfoUpdateSmbiosType19 ( > > mMemArrMapInfoType19.EndingAddress = 256 * 1024; > > Status = mFwProtocol->GetModelRevision (&BoardRevision); > > if (Status != EFI_SUCCESS) { > > - DEBUG ((DEBUG_WARNING, "Couldn't get the board memory size - defaulting to 256 MB: %r\n", Status)); > > + DEBUG ((DEBUG_WARN, "Couldn't get the board memory size - defaulting to 256 MB: %r\n", Status)); > > } else { > > // www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md > > // Bits [20-22] indicate the amount of memory starting with 256MB (000b) > > >