From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web12.246.1571239096468113801 for ; Wed, 16 Oct 2019 08:18:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=TJ+KYEgs; spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f67.google.com with SMTP id y18so19087878wrn.5 for ; Wed, 16 Oct 2019 08:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=YELgCsn7ZHxsCvpxTjEEIZB+i8D+8UlB+wzzz/OH+Tg=; b=TJ+KYEgsPGMNEZp4mCy8rSfALLgqlYv6aqrFGAbOdmQv8tDFOMPYYt91ja0VvU6cM+ TkdKNwWECvoC+mCK81jzdjvhJYPxF2WtVOuPpLuwOR5YC7ruhXdbQBLnqyGje+6e5gve c5KY4Hd5wjdPNmbL/st6eGI7LJK3FLKiFq+Q8SNlZ9XBS3Vj4mhs8Vqvkd/jE5uOrvk5 m2tTVoIunA5awIdiVB2CNsSDzXDDphaWcRkq1QsoprlFI+XzdgkbnrAkD/sYxjZm3lkL Nf1wlm5K2LyYFlZ1QS8s6leFIlG1bfLu+SURmSybuEGXiTRFJwy5Pk9x6x4RYZTWy0Ue XwjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=YELgCsn7ZHxsCvpxTjEEIZB+i8D+8UlB+wzzz/OH+Tg=; b=UYhBb/ldCJHLoKOfOyJ3V3EderXycawZnwbmuQgKZ1APeWWMnMu85k/RBQD/RtOlFT d+pcKoSVG2+NNRhoMBCuH6Zoav0FUvBLfCOthYYDhHjJ/Ml3yFIyE3t0mFt+KUgXK6Qw fVE1Vnmf/F1M89cQx/9gAkKtfFSWDfyhQTbia/cu7rLrf02Ju546unzdgN620KGN8J8G OO4Ij9t8vmpywETpwoPKq2pKCOLnZuN2Ng8FH0l3xBpOL/qlrpju+FKvnWVWaAArE26r +PhOw8C7Gx/MHtYJM7CTKH+BljdLAyhBfDLKqYkNxh/kQsJxIfu+Zy9KxF79Huhvriqa OH4Q== X-Gm-Message-State: APjAAAUDms1xgrHVMFrnIPpuffQ0Uj1dyXanqsGsOaExz1ENnMkHnDqP 3S5MBK0laLzV+5Lj/RZa2OXSeA== X-Google-Smtp-Source: APXvYqzW3vEPR4HcinrMDObe2yX9xnTaBN7F+tqr+YNR0/6LdQUB9u8ztqgYX2LuzzUQFLAnjbrPkg== X-Received: by 2002:adf:e8d0:: with SMTP id k16mr3291364wrn.233.1571239094899; Wed, 16 Oct 2019 08:18:14 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 13sm2640082wmj.29.2019.10.16.08.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 08:18:14 -0700 (PDT) Date: Wed, 16 Oct 2019 16:18:12 +0100 From: "Leif Lindholm" To: Philippe Mathieu-Daude Cc: devel@edk2.groups.io, Bob Feng , Liming Gao , Laszlo Ersek Subject: Re: [PATCH 0/3] BaseTools: Add a script to use with 'git-send-email --cc-cmd' Message-ID: <20191016151812.GT25504@bivouac.eciton.net> References: <20191016140940.18844-1-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191016140940.18844-1-philmd@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Phil, This is definitely a manual step that could do with automation, so many thanks for having a go. ...But, I have a few reservations regarding the actual solution. First of all, doing it as a .sh means it will not work for those developers working primarily with Visual Studio. Rewriting it as python script would resolve this, and also let you import GetMaintainer.py and use functions from there instead of adding a quiet mode to that. (I would very much like to not turn the GetMaintainer.py output into an ABI.) Secondly, I agree with Laszlo that I would rather see something that operated with format-patch than send-email (since we want to keep the Cc: tags in the commit messages). That command does not have the same useful hook, however. For this reason *I* would not use said script, but I'm not going to say we shouldn't have it. I will say it shouldn't be enabled by default by SetupGit.py though. Best Regards, Leif On Wed, Oct 16, 2019 at 04:09:37PM +0200, Philippe Mathieu-Daude wrote: > This series contains trivial fixes to the GetMaintainer.py script, > then adds a new script which allow git-send-email to automatically > fills the email addresses relevant to each patch, using the new > Maintainer.txt format (with the GetMaintainer.py script). > > I sent this series adding: > > [sendemail] > ccCmd = /home/phil/source/edk2/BaseTools/Scripts/GitCcCmd.sh > > To my /home/phil/source/edk2/.git/config > > The sendemail.ccCmd entry is documented here: > https://git-scm.com/docs/git-send-email#Documentation/git-send-email.txt---cc-cmdltcommandgt > > Regards, > > Phil. > > Philippe Mathieu-Daudé (3): > BaseTools: Let the GetMaintainer.py script be executable > BaseTools: Add '--quiet' option to GetMaintainer.py script > BaseTools: Add script to help git-send-email pick addresses to cc > > BaseTools/Scripts/GetMaintainer.py | 9 +++++-- > BaseTools/Scripts/GitCcCmd.sh | 38 ++++++++++++++++++++++++++++++ > 2 files changed, 45 insertions(+), 2 deletions(-) > mode change 100644 => 100755 BaseTools/Scripts/GetMaintainer.py > create mode 100755 BaseTools/Scripts/GitCcCmd.sh > > -- > 2.21.0 >