From: "Zhang, Shenglei" <shenglei.zhang@intel.com>
To: devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>, Hao A Wu <hao.a.wu@intel.com>
Subject: [PATCH 4/4] MdeModulePkg/SetupBrowserDxe: Add check for GetBufferForValue()
Date: Thu, 17 Oct 2019 11:31:10 +0800 [thread overview]
Message-ID: <20191017033110.12128-5-shenglei.zhang@intel.com> (raw)
In-Reply-To: <20191017033110.12128-1-shenglei.zhang@intel.com>
The returned value from GetBufferForValue might be NULL, so add a
check for that before it is used.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
MdeModulePkg/Universal/SetupBrowserDxe/Expression.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c
index 7f4929c2fcd9..984c68c6bb7a 100644
--- a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c
@@ -1281,7 +1281,12 @@ IfrToUint (
Result->Type = EFI_IFR_TYPE_UNDEFINED;
return EFI_SUCCESS;
}
+
+ if (GetBufferForValue (&Value) == NULL) {
+ return EFI_NOT_FOUND;
+ }
Result->Value.u64 = *(UINT64*) GetBufferForValue (&Value);
+
if (Value.Type == EFI_IFR_TYPE_BUFFER) {
FreePool (Value.Buffer);
}
--
2.18.0.windows.1
next prev parent reply other threads:[~2019-10-17 3:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 3:31 [PATCH 0/4] MdeModulePkg: Add check for variables and return value Zhang, Shenglei
2019-10-17 3:31 ` [PATCH 1/4] MdeModulePkg/EbcDebugger: Add check for Entry and RetEntry Zhang, Shenglei
2019-10-30 7:00 ` Wu, Hao A
2019-10-17 3:31 ` [PATCH 2/4] MdeModulePkg/HiiDatabaseDxe: Add check for StringPtr Zhang, Shenglei
2019-10-17 8:41 ` Dandan Bi
2019-10-17 3:31 ` [PATCH 3/4] MdeModulePkg/EsrtDxe: Add check for EsrtRepository Zhang, Shenglei
2019-10-30 7:01 ` Wu, Hao A
2019-10-17 3:31 ` Zhang, Shenglei [this message]
2019-10-30 7:01 ` [PATCH 4/4] MdeModulePkg/SetupBrowserDxe: Add check for GetBufferForValue() Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017033110.12128-5-shenglei.zhang@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox