From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web12.4077.1571330201567531052 for ; Thu, 17 Oct 2019 09:36:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=zvGfUCgQ; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f65.google.com with SMTP id n14so3099324wrw.9 for ; Thu, 17 Oct 2019 09:36:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yeGa7szTCcwRgyBLTTHU6w2L2g2RB3WjVuWTae1DItU=; b=zvGfUCgQ0nuBLjqnRsCXuQzltK3ZG3wvXtx02wc3n3CYTs1QUa/p3gJIB9de6k9D0p uy3edAh997l/Jt/gNz1SiXMYCEJNkcqPICzXQmLQX976VH6bYkluS/Op5O4Xpbkex/0Y +Fg1BT3mZCc03zDXlmrvhIF/SeoH/hciQIKv03SHQG39w1XQSFwAXTVg+EIZ03bQ8G+K ErGhA1Nc2xz4AXPs2TBmTArd0rqzPFek/QPwW/+ijXpN4pDbpgsqefcZSRCkh/kBYyeF HBfaxyGYyduUSDntJVJc75H0iw6MTo/0Ibg6PxBhWYInvka+3tguwUsVFSSOrEFGEQ9P IFww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yeGa7szTCcwRgyBLTTHU6w2L2g2RB3WjVuWTae1DItU=; b=VJRn/7oKSU0sflbaiQsv53i99LVniBAUO2h9RYouKZhKaytpwequJ2P77uWNlNY5zr xeigf5KHf3yoeFUNbpQXvP0HBWv81UuRvXBGAI3O+nQ0WrKbiXVJ/BXSqxFTf7RDNNwz dfldpobkMwZa/kHmfAEDb5Z2im3m7//RJuvAiyZgX++JcQmxqxTegrnFo7iHimNOIQ5+ AYDJPvQCVLjLOxBU7zbZ7jz/sDBGAUHI8Iw1CbJ7lfgnqerB4tsBYawOMFrcrKvI4ifR juY8nGPSGJcKM7DEtllI0I85pxtWe2up6EjZtqbNt/y2b/io891F2bMm50vC+x3e4iiG Yfag== X-Gm-Message-State: APjAAAVnJGXn7WNrIuyQOOFvrQy4kGM3K9aH2VW/OG/tcFkzO87bZk5p TFrEpcDzPNTAur6Ccn90DTiIkQJ7C4A= X-Google-Smtp-Source: APXvYqyx2pXbLPkzYnVM2Tvw2yGYstNfMP2782mn+AtOVNcGGfnPJYMtI2EJ4lhS6DC2SJfHPrmcYw== X-Received: by 2002:a05:6000:11d2:: with SMTP id i18mr3993051wrx.109.1571329854166; Thu, 17 Oct 2019 09:30:54 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z22sm2948681wmf.2.2019.10.17.09.30.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 09:30:53 -0700 (PDT) Date: Thu, 17 Oct 2019 17:30:51 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, liming.gao@intel.com Cc: Jiewen Yao , Steven Shi , Jordan Justen , Laszlo Ersek , Andrew Fish , Ray Ni , Ard Biesheuvel , Jian J Wang , Hao A Wu , Bob Feng , Michael D Kinney Subject: Re: [edk2-devel] [Patch v3 00/11] New Cross OS tool chain CLANG9 Message-ID: <20191017163051.GX25504@bivouac.eciton.net> References: <1571295356-11608-1-git-send-email-liming.gao@intel.com> MIME-Version: 1.0 In-Reply-To: <1571295356-11608-1-git-send-email-liming.gao@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Liming, I had missed that this set was out for review (I would appreciate a cc on any future revisions). On Thu, Oct 17, 2019 at 02:55:44PM +0800, Liming Gao wrote: > In v3, add the detail commit message for patch 3. > Update the fix in EmulatorPkg based on the comments. > > In v2, drop patch 12, and update commit message for 5 & 11. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 > Code: https://github.com/lgao4/edk2/tree/CLANG9 This branch does not appear to have been updated since 5 September, so it does not contain the version of the code sent out in this set. (And I can find no other obvious branch in that repository that may hold it.) Could you push an updated one please? One thing that strikes me as problematic with the version on the branch is that the set imports bits from GCC48 *and* GCC5. That seems like a maintenance hazard, but may no longer be the case for the current version of the set? Best Regards, Leif > Wiki: https://github.com/lgao4/edk2/wiki/CLANG9-Tools-Chain > > CLANG9 tool chain is added to directly generate PE/COFF image (EFI image). > This tool chain uses LLVM clang C compiler and lld linker, generates PE/COFF > image and PDB compatible debug symbol format. Now, it supports IA32/X64 Archs. > It must use LLVM 9 or above release. LLVM 9 is ready on > http://releases.llvm.org/download.html#9.0.0. > > CLANG9 is the cross OS tool chain. It can work on Windows/Linux/Mac host OS. > For the same source code, with the same version LLVM tool chain, > CLANG9 can generate the same binary image. So, the developer can > choose the different development environment and work on the same > code base. Besides, EDKII project build also requires third party > tools: nasm and iasl. They both keep the same version. If so, the same > binary image can be generated on the different host OS. > > LLVM tool chain provides the compiler and linker. To build EDK2 project, > some other tools are still required. On Windows OS, nmake and Visual Studio > are required to call Makefile and compile BaseTools C tools. > On Linux/Mac, binutils and gcc are required to make and compile BaseTools > C tools. Because VS or GCC are mainly used to compile BaseTools and provide > nmake/make tool, they can keep on the stable version without update. > > To build source code, CLANG9 tool chain (-t CLANG9) can be specified > on Windows OS, set CLANG_HOST_BIN=n, set CLANG9_BIN=LLVM installed directory > CLANG_HOST_BIN is used CLANG_HOST_PREFIX. Prefix n is for nmake. > For example: > * set CLANG_HOST_BIN=n > * set CLANG9_BIN=C:\Program Files\LLVM\bin\ > * set IASL_PREFIX=C:\Asl\ > > On Linux/Mac, export CLANG9_BIN=LLVM installed directory, CLANG_HOST_BIN is > not required, because there is no prefix for make. > For example: > * export CLANG9_BIN=/home/clang9/bin/ > > Now, CLANG9 tool chain has been verified in Edk2 packages and Ovmf/Emulator > with LLVM 9.0.0 on Windows and Linux OS. > OVMF IA32/X64/IA32X64 all boots to Shell on Windows and Linux OS. > Emulator can boot to Shell on Windows only with CLANG9. > OVMF Ia32X64 RELEASE build generates the same BIOS images on Windows and Linux OS. > > Cc: Jiewen Yao > Cc: Steven Shi > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Andrew Fish > Cc: Ray Ni > Cc: Ard Biesheuvel > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Bob Feng > Cc: Michael D Kinney > > Liming Gao (11): > BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) > path > BaseTools tools_def: Add CLANG9 tool chain to directly generate PE > image > BaseTools GenFw: Fix the issue to update the wrong size as SectionSize > MdePkg Base.h: Add definition for CLANG9 tool chain > MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO > functions > MdeModulePkg LzmaCustomDecompressLib: Update macro to be same in CLANG > tool > MdeModulePkg RegularExpressionDxe: Disable warning for CLANG9 tool > chain > CryptoPkg: Append options to make CLANG9 tool chain pass build > CryptoPkg IntrinsicLib: Make _fltused always be used > EmulatorPkg: Enable CLANG9 tool chain > OvmfPkg: Enable CLANG9 tool chain > > BaseTools/Source/C/GenFw/GenFw.c | 8 +- > CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 +- > EmulatorPkg/Win/Host/WinHost.c | 6 +- > MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 - > BaseTools/Conf/build_rule.template | 26 +++-- > BaseTools/Conf/tools_def.template | 124 +++++++++++++++++++-- > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 1 + > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 + > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 + > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 1 + > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 + > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 1 + > EmulatorPkg/EmulatorPkg.dsc | 7 +- > EmulatorPkg/Win/Host/WinHost.inf | 6 + > .../LzmaCustomDecompressLib/Sdk/C/7zTypes.h | 2 +- > .../RegularExpressionDxe/RegularExpressionDxe.inf | 3 + > MdePkg/Include/Base.h | 6 +- > MdePkg/Include/Ia32/ProcessorBind.h | 4 +- > MdePkg/Include/X64/ProcessorBind.h | 2 +- > OvmfPkg/OvmfPkgIa32.dsc | 4 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 4 +- > OvmfPkg/OvmfPkgX64.dsc | 4 +- > 22 files changed, 183 insertions(+), 45 deletions(-) > > -- > 2.13.0.windows.1 > > > >