Re: [edk2-platforms][PATCH 1/1] SfcPkg: Add new package

["Leif Lindholm" <leif.lindholm@linaro.org>]

First of all, could you respin this to align more with what's
described in
https://github.com/tianocore/edk2-platforms/blob/about/Readme.md
?

Specifically, it should be visible from the Readme.md (not just the
Maintainers.txt history) who owns the branch (you).

Secondly, I would prefer SolarFlarePkg - the one redeeming factor of
CamelCase is that it eliminates guessing.

Some Bikeshedding and nitpicking below:

On Thu, Oct 17, 2019 at 05:19:44PM +0100, Tomas Pilar wrote:
> This package is for Solarflare Communications drivers and utilities.
> 
> Signed-off-by: Tomas Pilar <tpilar@solarflare.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Drivers/SfcPkg/Readme.md | 11 +++++++++++
>  Maintainers.txt          |  4 ++++
>  Readme.md                |  7 +++++++
>  3 files changed, 22 insertions(+)
>  create mode 100644 Drivers/SfcPkg/Readme.md
> 
> diff --git a/Drivers/SfcPkg/Readme.md b/Drivers/SfcPkg/Readme.md
> new file mode 100644
> index 0000000000..b26b0bbc8c
> --- /dev/null
  > +++ b/Drivers/SfcPkg/Readme.md
> @@ -0,0 +1,11 @@
> +Drivers and utilities for Solarflare Communications network adapters
> +
> +## Contact
> +
> +* [Website] (www.solarflare.com)
> +* [Support] (support@solarflare.com)

Umm...
Is your support department aware that they are now supporting an
in-progress version of an open source UEFI driver?

> +
> +## Licence
> +
> +The contents are licenced under BSD-2-Clause-Patent licence. +See top level
> Licence.txt in the edk2-platforms repository.

Link to it, markdown-style.

> \ No newline at end of file

*cough*

> diff --git a/Maintainers.txt b/Maintainers.txt
> index 1260c8d246..a293e7ebaa 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -52,6 +52,10 @@ M: Leif Lindholm <leif.lindholm@linaro.org>
>  M: Ard Bieshuevel <ard.bieshuevel@linaro.org>
>  R: Andy Hayes <andy.hayes@displaylink.com>
>  +Drivers/SfcPkg

How did that happen? The '+' should have one fewer indent.
Preferably add a blank line before this section.

> +M: Leif Lindholm <leif.lindholm@linaro.org>
> +R: Tomas Pilar <tpilar@solarflare.com>
> +
>  Platform
>  M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>  M: Leif Lindholm <leif.lindholm@linaro.org>
> diff --git a/Readme.md b/Readme.md
> index 2b54b8e0b4..4de427bc69 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -247,6 +247,13 @@ For more information, see the
>  ## Socionext
>  * [SynQuacer](Platform/Socionext/DeveloperBox)
>  +# IHV Drivers

More weird indentation.
Ah:
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

Yeah, you need to submit patches with git send-email. I'll also take
them on a publicly accessible branch, as long as the email copy isn't
badly enough corrupted that it complicates review.

Best Regards,

Leif

> +
> +These are independent hardware vendor products currently supported by
> +fimware, drivers and utilities in this tree.
> +
> +## Solarflare Communications
> +
>  # Maintainers
>   See [Maintainers.txt](Maintainers.txt).
> -- 
> 2.21.0
>