From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web12.4647.1571332742226981687 for ; Thu, 17 Oct 2019 10:19:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Tpd5jn2y; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f68.google.com with SMTP id p14so3268871wro.4 for ; Thu, 17 Oct 2019 10:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PeB0m+1yU40kFKk92K71/1Wnl8S3y0xmRj83nC2XVmI=; b=Tpd5jn2yT3J4pHEwTRb4owtAu3kJMZAWp/CpYniNLw8Urm+SRDVsn1rq6aYGFGSJQq p7lHr9jjhb6B6SsjjuZqP5kGOF50vEKRU/wFmliiFN8darVAie+WgZKIp17fnEAiN55r 8cWMqRxO9CF/qVYNiLLayOzykTfA8Cu/ISGdjo/as41ADSc3XCoP0/IPjTg6V3fvMF2F pAp7Hg/mLwv9v4f3fMiJsk5yOMmUzNowMuESxRMf8kIxxchXL7aweEf0mQN2DYuhZRtN 7l9iu/40UmiVh0RdRbTv6pNfTBeVTixtuGT0QXjuHKvTpctTkWdFZr+px8J1UYUg9zKo zlYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PeB0m+1yU40kFKk92K71/1Wnl8S3y0xmRj83nC2XVmI=; b=isMkqQTotN2dLD4Q2bOE4WTkF3AKsivy/a8hSXoBjK2DZ3rvMxNgxbfFeuahS0jwoK npLnS0gmDZnLYijwz4Yzzx0YmfxauV3hIP0i1UZc8pcvO68zXGUHbw2V1/rXCSqd+oJq R4vlNzlNXX1ogotScGHA6iZg+7i5gmdaK7E+iSLwupwaDGdnsgEv1j7kHR+yrqjAILUm ZMOUgoFinuL10OHkGX0PriChCoZIV56t9x7b1CqEYkft+e8sjzubyCAK62UMryMcHRvD k2Nc8lKPnk8fd0qR6iyD0WGz241i4V/wgEIWSlYBjtO9MGcZFwPOZlI828aiBdgeXrzS rg0Q== X-Gm-Message-State: APjAAAXardgz+5ITHNnofuGaGWXOLrMHjb7u7uuF3ziyvx9/9c/ylKF3 jjoa5U88pBR7hzaKdxbyiYUMuA== X-Google-Smtp-Source: APXvYqybGpyhfZ5c6N/AybTLZFcYvugmabzVs/ALEArfYIdTP96ECbnhzwZkUIYnnSj6+E+M0f2UCQ== X-Received: by 2002:a5d:66cd:: with SMTP id k13mr4305023wrw.194.1571332740729; Thu, 17 Oct 2019 10:19:00 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id z4sm2712958wrh.93.2019.10.17.10.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 10:19:00 -0700 (PDT) Date: Thu, 17 Oct 2019 18:18:58 +0100 From: "Leif Lindholm" To: Tomas Pilar Cc: devel@edk2.groups.io, Michael D Kinney Subject: Re: [edk2-platforms][PATCH 1/1] SfcPkg: Add new package Message-ID: <20191017171858.GZ25504@bivouac.eciton.net> References: <5cc83e67-5271-7f87-6188-ae4fa03e33ed@solarflare.com> MIME-Version: 1.0 In-Reply-To: <5cc83e67-5271-7f87-6188-ae4fa03e33ed@solarflare.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline First of all, could you respin this to align more with what's described in https://github.com/tianocore/edk2-platforms/blob/about/Readme.md ? Specifically, it should be visible from the Readme.md (not just the Maintainers.txt history) who owns the branch (you). Secondly, I would prefer SolarFlarePkg - the one redeeming factor of CamelCase is that it eliminates guessing. Some Bikeshedding and nitpicking below: On Thu, Oct 17, 2019 at 05:19:44PM +0100, Tomas Pilar wrote: > This package is for Solarflare Communications drivers and utilities. > > Signed-off-by: Tomas Pilar > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Drivers/SfcPkg/Readme.md | 11 +++++++++++ > Maintainers.txt | 4 ++++ > Readme.md | 7 +++++++ > 3 files changed, 22 insertions(+) > create mode 100644 Drivers/SfcPkg/Readme.md > > diff --git a/Drivers/SfcPkg/Readme.md b/Drivers/SfcPkg/Readme.md > new file mode 100644 > index 0000000000..b26b0bbc8c > --- /dev/null > +++ b/Drivers/SfcPkg/Readme.md > @@ -0,0 +1,11 @@ > +Drivers and utilities for Solarflare Communications network adapters > + > +## Contact > + > +* [Website] (www.solarflare.com) > +* [Support] (support@solarflare.com) Umm... Is your support department aware that they are now supporting an in-progress version of an open source UEFI driver? > + > +## Licence > + > +The contents are licenced under BSD-2-Clause-Patent licence. +See top level > Licence.txt in the edk2-platforms repository. Link to it, markdown-style. > \ No newline at end of file *cough* > diff --git a/Maintainers.txt b/Maintainers.txt > index 1260c8d246..a293e7ebaa 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -52,6 +52,10 @@ M: Leif Lindholm > M: Ard Bieshuevel > R: Andy Hayes > +Drivers/SfcPkg How did that happen? The '+' should have one fewer indent. Preferably add a blank line before this section. > +M: Leif Lindholm > +R: Tomas Pilar > + > Platform > M: Ard Biesheuvel > M: Leif Lindholm > diff --git a/Readme.md b/Readme.md > index 2b54b8e0b4..4de427bc69 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -247,6 +247,13 @@ For more information, see the > ## Socionext > * [SynQuacer](Platform/Socionext/DeveloperBox) > +# IHV Drivers More weird indentation. Ah: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Yeah, you need to submit patches with git send-email. I'll also take them on a publicly accessible branch, as long as the email copy isn't badly enough corrupted that it complicates review. Best Regards, Leif > + > +These are independent hardware vendor products currently supported by > +fimware, drivers and utilities in this tree. > + > +## Solarflare Communications > + > # Maintainers > See [Maintainers.txt](Maintainers.txt). > -- > 2.21.0 >