public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Zhang, Chao B" <chao.b.zhang@intel.com>,
	Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build
Date: Fri, 18 Oct 2019 12:58:32 +0100	[thread overview]
Message-ID: <20191018115832.GD25504@bivouac.eciton.net> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F807870@shsmsx102.ccr.corp.intel.com>

On Fri, Oct 18, 2019 at 11:20:19AM +0000, Yao, Jiewen wrote:
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

Thanks!
Pushed as 0f28c513d392.

BZ closed.

/
    Leif

> > -----Original Message-----
> > From: Leif Lindholm <leif.lindholm@linaro.org>
> > Sent: Friday, October 18, 2019 5:43 PM
> > To: devel@edk2.groups.io
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B
> > <chao.b.zhang@intel.com>; Laszlo Ersek <lersek@redhat.com>
> > Subject: [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build
> > 
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2252
> > 
> > Add NULL library resolution of CompilerIntrinsicsLib and
> > BaseStackCheckLib for AARCH64 as well as ARM in order to
> > fix "undefined reference to `memcpy'" build errors.
> > 
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Chao Zhang <chao.b.zhang@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> >  SignedCapsulePkg/SignedCapsulePkg.dsc | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc
> > b/SignedCapsulePkg/SignedCapsulePkg.dsc
> > index 4d4232d6e003..03f714f9a799 100644
> > --- a/SignedCapsulePkg/SignedCapsulePkg.dsc
> > +++ b/SignedCapsulePkg/SignedCapsulePkg.dsc
> > @@ -97,6 +97,7 @@ [LibraryClasses]
> >  [LibraryClasses.ARM]
> >    ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> > 
> > +[LibraryClasses.AARCH64, LibraryClasses.ARM]
> >    #
> >    # It is not possible to prevent the ARM compiler for generic intrinsic functions.
> >    # This library provides the instrinsic functions generate by a given compiler.
> > --
> > 2.20.1
> 

      reply	other threads:[~2019-10-18 11:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18  9:43 [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build Leif Lindholm
2019-10-18 11:20 ` Yao, Jiewen
2019-10-18 11:58   ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191018115832.GD25504@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox