From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65])
 by mx.groups.io with SMTP id smtpd.web10.4842.1571399916392757719
 for <devel@edk2.groups.io>;
 Fri, 18 Oct 2019 04:58:36 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=rvXT8dj4;
 spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: leif.lindholm@linaro.org)
Received: by mail-wr1-f65.google.com with SMTP id b9so5978247wrs.0
        for <devel@edk2.groups.io>; Fri, 18 Oct 2019 04:58:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=bI2elxNiR2qpncV8hoFSphRVuJQ+vfjXh7RgeSHWnSM=;
        b=rvXT8dj4s+UIB0L6Jf98K19ACzEBD3EfFWLXcC6eWtgNKm1wfEExed4tTOD1fxt0Fp
         Ij4RAgoxpyhnqovHdg+tqUzc1yzUweBunOwKNoJztfZhCwpwDfqs1wx0hYDTQIgk9xKB
         pvlHaeoNd1SJpVwaM2lzTHsy7v7v0bpqvPtjLZdT7JksZFqpaKY1B0yE0ONWjQK2nZw+
         XWE9d554UWKZ7NfiD9iOHnpN/a5UjmC6LON8tslH/gBxjCZiiP+VySeY7u1JXK4EveWW
         5kBfDP3s0XTArKKPBJ04AzWKSdXRyBY/YglxP4Mn/xi1yNw707+Cpq/pjxVwteMzLt+r
         4gmA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=bI2elxNiR2qpncV8hoFSphRVuJQ+vfjXh7RgeSHWnSM=;
        b=VF5CEjOm05+Q+n4QCa0Ql4ea1NXDQ6+aO2FlQ6B8r57SvKoK+4u6+JmXouQWdGPj++
         m77UStlR68eiB3Qx/xY1CYiuJsVdKP6WhxKeUmNXSpiUGIDK0Cobi9O9w68gN2iUBNi2
         aSt0WuObHl250Uyq9jWX3doPQsMwXwdA0sgCv+XhLY4JMGZk9z0hFgHhGuwaEm/byGH/
         Naq/Dpi/w3CslfvRHNBmp8rOCbzSEUHfpsPvSwyx9g2uW3d9l48lk1bKP8DKPA+kjQEF
         N+3cJzzDIlTCZYyqp27KTEg6XJRitAccyjRIXuaV2NyU88Tk8USp/nUQTwGkx3lLC/+S
         6fpw==
X-Gm-Message-State: APjAAAUDYNsBaHnQg8cJrTD/tsNBRTbEsl/QBwUW2rJi/hpiPsS6OJ9n
	Y2MycZKV93IkEZlNqJkno/rSgA==
X-Google-Smtp-Source: APXvYqy7vW/Sqxl2QFKrNXNrI3GtWG6bqH9is4hA6X7YFNaj13TS6Dob8nTExDc8nXIeBnO/DPvR0A==
X-Received: by 2002:adf:d846:: with SMTP id k6mr7671792wrl.178.1571399914929;
        Fri, 18 Oct 2019 04:58:34 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id x2sm5240613wrn.81.2019.10.18.04.58.34
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 18 Oct 2019 04:58:34 -0700 (PDT)
Date: Fri, 18 Oct 2019 12:58:32 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Zhang, Chao B" <chao.b.zhang@intel.com>,
	Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build
Message-ID: <20191018115832.GD25504@bivouac.eciton.net>
References: <20191018094328.12632-1-leif.lindholm@linaro.org>
 <74D8A39837DF1E4DA445A8C0B3885C503F807870@shsmsx102.ccr.corp.intel.com>
MIME-Version: 1.0
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F807870@shsmsx102.ccr.corp.intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Oct 18, 2019 at 11:20:19AM +0000, Yao, Jiewen wrote:
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

Thanks!
Pushed as 0f28c513d392.

BZ closed.

/
    Leif

> > -----Original Message-----
> > From: Leif Lindholm <leif.lindholm@linaro.org>
> > Sent: Friday, October 18, 2019 5:43 PM
> > To: devel@edk2.groups.io
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B
> > <chao.b.zhang@intel.com>; Laszlo Ersek <lersek@redhat.com>
> > Subject: [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build
> > 
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2252
> > 
> > Add NULL library resolution of CompilerIntrinsicsLib and
> > BaseStackCheckLib for AARCH64 as well as ARM in order to
> > fix "undefined reference to `memcpy'" build errors.
> > 
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Chao Zhang <chao.b.zhang@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> >  SignedCapsulePkg/SignedCapsulePkg.dsc | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc
> > b/SignedCapsulePkg/SignedCapsulePkg.dsc
> > index 4d4232d6e003..03f714f9a799 100644
> > --- a/SignedCapsulePkg/SignedCapsulePkg.dsc
> > +++ b/SignedCapsulePkg/SignedCapsulePkg.dsc
> > @@ -97,6 +97,7 @@ [LibraryClasses]
> >  [LibraryClasses.ARM]
> >    ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> > 
> > +[LibraryClasses.AARCH64, LibraryClasses.ARM]
> >    #
> >    # It is not possible to prevent the ARM compiler for generic intrinsic functions.
> >    # This library provides the instrinsic functions generate by a given compiler.
> > --
> > 2.20.1
>