* [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build
@ 2019-10-18 9:43 Leif Lindholm
2019-10-18 11:20 ` Yao, Jiewen
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2019-10-18 9:43 UTC (permalink / raw)
To: devel; +Cc: Jiewen Yao, Chao Zhang, Laszlo Ersek
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2252
Add NULL library resolution of CompilerIntrinsicsLib and
BaseStackCheckLib for AARCH64 as well as ARM in order to
fix "undefined reference to `memcpy'" build errors.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
SignedCapsulePkg/SignedCapsulePkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc b/SignedCapsulePkg/SignedCapsulePkg.dsc
index 4d4232d6e003..03f714f9a799 100644
--- a/SignedCapsulePkg/SignedCapsulePkg.dsc
+++ b/SignedCapsulePkg/SignedCapsulePkg.dsc
@@ -97,6 +97,7 @@ [LibraryClasses]
[LibraryClasses.ARM]
ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
+[LibraryClasses.AARCH64, LibraryClasses.ARM]
#
# It is not possible to prevent the ARM compiler for generic intrinsic functions.
# This library provides the instrinsic functions generate by a given compiler.
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build
2019-10-18 9:43 [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build Leif Lindholm
@ 2019-10-18 11:20 ` Yao, Jiewen
2019-10-18 11:58 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Yao, Jiewen @ 2019-10-18 11:20 UTC (permalink / raw)
To: Leif Lindholm, devel@edk2.groups.io; +Cc: Zhang, Chao B, Laszlo Ersek
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: Leif Lindholm <leif.lindholm@linaro.org>
> Sent: Friday, October 18, 2019 5:43 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2252
>
> Add NULL library resolution of CompilerIntrinsicsLib and
> BaseStackCheckLib for AARCH64 as well as ARM in order to
> fix "undefined reference to `memcpy'" build errors.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> SignedCapsulePkg/SignedCapsulePkg.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc
> b/SignedCapsulePkg/SignedCapsulePkg.dsc
> index 4d4232d6e003..03f714f9a799 100644
> --- a/SignedCapsulePkg/SignedCapsulePkg.dsc
> +++ b/SignedCapsulePkg/SignedCapsulePkg.dsc
> @@ -97,6 +97,7 @@ [LibraryClasses]
> [LibraryClasses.ARM]
> ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
>
> +[LibraryClasses.AARCH64, LibraryClasses.ARM]
> #
> # It is not possible to prevent the ARM compiler for generic intrinsic functions.
> # This library provides the instrinsic functions generate by a given compiler.
> --
> 2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build
2019-10-18 11:20 ` Yao, Jiewen
@ 2019-10-18 11:58 ` Leif Lindholm
0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2019-10-18 11:58 UTC (permalink / raw)
To: Yao, Jiewen; +Cc: devel@edk2.groups.io, Zhang, Chao B, Laszlo Ersek
On Fri, Oct 18, 2019 at 11:20:19AM +0000, Yao, Jiewen wrote:
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
Thanks!
Pushed as 0f28c513d392.
BZ closed.
/
Leif
> > -----Original Message-----
> > From: Leif Lindholm <leif.lindholm@linaro.org>
> > Sent: Friday, October 18, 2019 5:43 PM
> > To: devel@edk2.groups.io
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B
> > <chao.b.zhang@intel.com>; Laszlo Ersek <lersek@redhat.com>
> > Subject: [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2252
> >
> > Add NULL library resolution of CompilerIntrinsicsLib and
> > BaseStackCheckLib for AARCH64 as well as ARM in order to
> > fix "undefined reference to `memcpy'" build errors.
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Chao Zhang <chao.b.zhang@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> > SignedCapsulePkg/SignedCapsulePkg.dsc | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc
> > b/SignedCapsulePkg/SignedCapsulePkg.dsc
> > index 4d4232d6e003..03f714f9a799 100644
> > --- a/SignedCapsulePkg/SignedCapsulePkg.dsc
> > +++ b/SignedCapsulePkg/SignedCapsulePkg.dsc
> > @@ -97,6 +97,7 @@ [LibraryClasses]
> > [LibraryClasses.ARM]
> > ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> >
> > +[LibraryClasses.AARCH64, LibraryClasses.ARM]
> > #
> > # It is not possible to prevent the ARM compiler for generic intrinsic functions.
> > # This library provides the instrinsic functions generate by a given compiler.
> > --
> > 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-18 11:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-18 9:43 [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build Leif Lindholm
2019-10-18 11:20 ` Yao, Jiewen
2019-10-18 11:58 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox