From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web12.5407.1571403129320224964 for ; Fri, 18 Oct 2019 05:52:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=mRlOpRoR; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f68.google.com with SMTP id i16so6075911wmd.3 for ; Fri, 18 Oct 2019 05:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sGNHyPHddoimi+WEI64IyNfr2pMBbM5947iN7/6HPOg=; b=mRlOpRoRiGFeOULQDNaGG4z9WuUQi/4RmoVWNHMn/tKpukA0f2cgAzKepnz+OfOIqr mnytEAmAv5til/6SiXXUJi7fdjnekavhCnu4pL7+ONuxSYC1BPHi9M5pJJ0Zk6R91zYf DIQR+0bCCYeizwhC9N0Emb2ddanSX9LG391Oq4w1K4sS7ubUmshdkxkHk2AaKJ4lPBGp Va+bwh0UkQvgeJRNqL8ABfcX4hSPhJpRF0hFp5PTpq/qyzWTUxSkoPPjzQE7gTsGBsTh zSAnUwTltB11kER3ek2lm4EZFijXF29qaB73fyxaKvfCB0fLB16wXpFdZcGVJba+GyF/ gWHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sGNHyPHddoimi+WEI64IyNfr2pMBbM5947iN7/6HPOg=; b=a21tGUHy3SR29zSEv0j1cJnC1fMsF7oioawLx6stSY8eflrtfq/OC5q+6mvLDllN5b lxciuqwckAD5IUIZr9UH8FglJglksfSJtLexPvFzELPEJwProt0TitdjKZiCWjmDuIK2 hmX+PTQfYoWhfqkEzfX72Fu4B7cMlFqIu09wazw+0atKmXoOX6axv8+xB2QO4db8iNdz d+p69wC4IwSZ8i7uk+mXvcVMISG2Q0VyEXU/xbPrxUmSPiC6v0QoQplZ9PoFlNdrm8oy 5kXFsLQPnhLYv70H/AFeij8oMPWVZOrA2IWWSCOtD/F6dnezp+kDJIAUmQ7GKVaf/6Rk V02Q== X-Gm-Message-State: APjAAAXgeceRsuhzsghZv8f5P8ZQ5gtA1VSioMo0rXNnxxSm+cz/Wyuy zXCmC8lN0m/0BZpbaOWSpb7EBg== X-Google-Smtp-Source: APXvYqzp/q/x/YWjAi1w/+GIyQMXTT6+nFfT8fjYmAslul5dmv+hyn1vTxhXewFTSkQnV3QJIReO0A== X-Received: by 2002:a05:600c:1007:: with SMTP id c7mr3803833wmc.41.1571403127456; Fri, 18 Oct 2019 05:52:07 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id m18sm6123269wrg.97.2019.10.18.05.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 05:52:06 -0700 (PDT) Date: Fri, 18 Oct 2019 13:52:05 +0100 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org Subject: Re: [edk2-platforms][PATCH v2 1/1] Platform/RPi3: Add TFTP command to UEFI Shell Message-ID: <20191018125205.GE25504@bivouac.eciton.net> References: <20191018124130.8456-1-pete@akeo.ie> <20191018124130.8456-2-pete@akeo.ie> MIME-Version: 1.0 In-Reply-To: <20191018124130.8456-2-pete@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 18, 2019 at 01:41:30PM +0100, Pete Batard wrote: > TFTP support, which is enabled by default, can be disabled by setting > INCLUDE_TFTP_COMMAND to FALSE. Would you be OK with flipping the default to FALSE? It is a custom extension not described by the UEFI Shell Specification. I could flip the logic in the DEFINE and commit message if so, no need for a v3. Regards, Leif > Signed-off-by: Pete Batard > --- > Platform/RaspberryPi/RPi3/RPi3.dsc | 8 ++++++++ > Platform/RaspberryPi/RPi3/RPi3.fdf | 3 +++ > 2 files changed, 11 insertions(+) > > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc > index bc424a06bb45..2289ad8c2ed2 100644 > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc > @@ -36,6 +36,7 @@ [Defines] > # -D FLAG=VALUE > # > DEFINE SECURE_BOOT_ENABLE = FALSE > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > DEFINE DEBUG_PRINT_ERROR_LEVEL = 0x8000004F > > ################################################################################ > @@ -181,6 +182,10 @@ [LibraryClasses.common.DXE_DRIVER] > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > +!if $(INCLUDE_TFTP_COMMAND) == TRUE > + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > + FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf > +!endif > > [LibraryClasses.common.UEFI_APPLICATION] > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > @@ -616,3 +621,6 @@ [Components.common] > gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 > gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|0x200000 > } > +!if $(INCLUDE_TFTP_COMMAND) == TRUE > + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > +!endif > diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf b/Platform/RaspberryPi/RPi3/RPi3.fdf > index 17c0094ac1cf..b06a15fb8ec3 100644 > --- a/Platform/RaspberryPi/RPi3/RPi3.fdf > +++ b/Platform/RaspberryPi/RPi3/RPi3.fdf > @@ -232,6 +232,9 @@ [FV.FvMain] > # UEFI application (Shell Embedded Boot Loader) > # > INF ShellPkg/Application/Shell/Shell.inf > +!if $(INCLUDE_TFTP_COMMAND) == TRUE > + INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > +!endif > > # > # ACPI Support > -- > 2.21.0.windows.1 >