From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web12.725.1571412522656712252 for ; Fri, 18 Oct 2019 08:28:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=ZgweV+45; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f67.google.com with SMTP id i16so6628990wmd.3 for ; Fri, 18 Oct 2019 08:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Ny9DBZOdoCH9P48qM1gBOmfWrkzKo21tCd+LonjfF8o=; b=ZgweV+45JNIwJI2e3yclx25rXi/VLvcawUo0IIF0stigC0Iu0ZQv+sagVh0UXfwZSJ J05NX19/7bMDJhFWmyg9w4+OkGtaUaVooPpWDAQxmHro5kQ6/pK7ksYFhoxlAFUJo9W0 4ZUbKG05eNdh1+msVQN+5z/MwZ+9QnJ3hkRw6xXVlI3Eh6BJiCNUnB7YUZFGEVV1YSpn DsldzrM7LWK8PWVwOjr27O9iTpm//szjTNap/4pITpbxLMttqqqXdnLe5i33V4qskP2j yej6WRxw5Qq7L7RGTN7vlbXQ0ybiuP6jodyzYyGx5IIQs7yLyHnqbTu72SHZepC+jja6 YhAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Ny9DBZOdoCH9P48qM1gBOmfWrkzKo21tCd+LonjfF8o=; b=J92ZePOyM0VPoB19GpgGcjrL0wHc9HXVDx384tQRzl8+y7ogJTHDoycR2HbrzEH8G6 /RXHSePx/jyYtRswECsQV9HxtyMLjMzNlJrK5csBUpamfHxUTQdrp6QjnXHOnuilhUOJ DHIkuQa3DsyApBHUg3OcyYGsXf0Qnb/5iRMnHFLnfMNHnyqxGa0GsHABnWugUvb75k65 8wN/HOqsjGDbB8oZeLFlO68b3npe3z0hxNQiPFlw2fjUrYOeQvcPJcroCYb5gaoXBywL bR2BXPNZZxmvEROLHlTbGj4EpYHSWNlxunXDMgOPiyCQcd+1gXEjo5JuyeKq2ctsiena t3LQ== X-Gm-Message-State: APjAAAXT+4P1lZKj5NWW5/ltMoD9SbquJ/MG9hL3LfzkwKv3nRy0QM2O C3dtC2BYoTB9gFRMhj2doc+N2A== X-Google-Smtp-Source: APXvYqynJTzxnNNEYKIOzPqtAxoWzBhAPzPGJzaPVar0XbZquR6fq/BKcgAJKI0gdk3WpBVCP5jVIg== X-Received: by 2002:a1c:9a8d:: with SMTP id c135mr2739875wme.82.1571412521134; Fri, 18 Oct 2019 08:28:41 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w22sm5265626wmc.16.2019.10.18.08.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 08:28:40 -0700 (PDT) Date: Fri, 18 Oct 2019 16:28:38 +0100 From: "Leif Lindholm" To: pete@akeo.ie, Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] Platform/RPi3: Add TFTP command to UEFI Shell Message-ID: <20191018152838.GF25504@bivouac.eciton.net> References: <20191018124130.8456-1-pete@akeo.ie> <20191018124130.8456-2-pete@akeo.ie> <20191018125205.GE25504@bivouac.eciton.net> <6b23a960-8af8-2ab3-69c8-454f3f0eef37@akeo.ie> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Fri, Oct 18, 2019 at 04:05:59PM +0200, Philippe Mathieu-Daudé wrote: > On 10/18/19 3:25 PM, Pete Batard wrote: > > On 2019.10.18 13:52, Leif Lindholm wrote: > > > On Fri, Oct 18, 2019 at 01:41:30PM +0100, Pete Batard wrote: > > > > TFTP support, which is enabled by default, can be disabled by setting > > > > INCLUDE_TFTP_COMMAND to FALSE. > > > > > > Would you be OK with flipping the default to FALSE? > > > > Yes, I have no issue with a default set to FALSE. > > > > > It is a custom extension not described by the UEFI Shell > > > Specification. > > > > > > I could flip the logic in the DEFINE and commit message if so, no need > > > for a v3. > > > > If you can do that, that would be great. Thanks! > > Reviewed-by: Philippe Mathieu-Daude Thanks. Reviewed-by: Leif Lindholm Pushed as f8c5d83e0042. > > > > /Pete > > > > > > > > Regards, > > > > > > Leif > > > > > > > Signed-off-by: Pete Batard > > > > --- > > > >   Platform/RaspberryPi/RPi3/RPi3.dsc | 8 ++++++++ > > > >   Platform/RaspberryPi/RPi3/RPi3.fdf | 3 +++ > > > >   2 files changed, 11 insertions(+) > > > > > > > > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc > > > > b/Platform/RaspberryPi/RPi3/RPi3.dsc > > > > index bc424a06bb45..2289ad8c2ed2 100644 > > > > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc > > > > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc > > > > @@ -36,6 +36,7 @@ [Defines] > > > >     # -D FLAG=VALUE > > > >     # > > > >     DEFINE SECURE_BOOT_ENABLE      = FALSE > > > > +  DEFINE INCLUDE_TFTP_COMMAND    = TRUE > > > >     DEFINE DEBUG_PRINT_ERROR_LEVEL = 0x8000004F > > > > ################################################################################ > > > > > > > > @@ -181,6 +182,10 @@ [LibraryClasses.common.DXE_DRIVER] > > > > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf > > > > > > > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > > > > > > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > > > > > > > +!if $(INCLUDE_TFTP_COMMAND) == TRUE > > > > +  ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > > > > +  FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf > > > > +!endif > > > >   [LibraryClasses.common.UEFI_APPLICATION] > > > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > > > > > > > @@ -616,3 +621,6 @@ [Components.common] > > > >         gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 > > > >         gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|0x200000 > > > >     } > > > > +!if $(INCLUDE_TFTP_COMMAND) == TRUE > > > > +  ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > > > > +!endif > > > > diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf > > > > b/Platform/RaspberryPi/RPi3/RPi3.fdf > > > > index 17c0094ac1cf..b06a15fb8ec3 100644 > > > > --- a/Platform/RaspberryPi/RPi3/RPi3.fdf > > > > +++ b/Platform/RaspberryPi/RPi3/RPi3.fdf > > > > @@ -232,6 +232,9 @@ [FV.FvMain] > > > >     # UEFI application (Shell Embedded Boot Loader) > > > >     # > > > >     INF ShellPkg/Application/Shell/Shell.inf > > > > +!if $(INCLUDE_TFTP_COMMAND) == TRUE > > > > +  INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > > > > +!endif > > > >     # > > > >     # ACPI Support > > > > -- > > > > 2.21.0.windows.1 > > > > > > > > > > > > >