[PATCH v1 0/1] Do not call sys.setdefaultencoding with python 3

[PATCH v1 0/1] Do not call sys.setdefaultencoding with python 3

[Vitaly Cheptsov]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

Solves https://bugzilla.tianocore.org/show_bug.cgi?id=2301.
Requesting for merge in edk2-stable2019011.

Vitaly Cheptsov (1):
  BaseTools: Do not call sys.setdefaultencoding with python 3

 BaseTools/Source/Python/sitecustomize.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.21.0 (Apple Git-122)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 489 bytes --]

[PATCH v1 1/1] BaseTools: Do not call sys.setdefaultencoding with python 3

[Vitaly Cheptsov]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2301

This interface was a originally a no-op in python 3, and now
is fully removed causing a build warning on macOS (Darwin).

Signed-off-by: Vitaly Cheptsov <vit9696@protonmail.com>>
---
 BaseTools/Source/Python/sitecustomize.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/sitecustomize.py b/BaseTools/Source/Python/sitecustomize.py
index 7dbbf8a232..50783e1b3a 100644
--- a/BaseTools/Source/Python/sitecustomize.py
+++ b/BaseTools/Source/Python/sitecustomize.py
@@ -7,7 +7,7 @@
 import sys
 import locale
 
-if sys.platform == "darwin":
+if sys.platform == "darwin" and sys.version_info[0] < 3:
   DefaultLocal = locale.getdefaultlocale()[1]
   if DefaultLocal is None:
     DefaultLocal = 'UTF8'
-- 
2.21.0 (Apple Git-122)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 489 bytes --]

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Do not call sys.setdefaultencoding with python 3

[Bob Feng]

Acked-by: Bob Feng <bob.c.feng@intel.com>


-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Vitaly Cheptsov via Groups.Io
Sent: Sunday, October 20, 2019 6:26 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH v1 1/1] BaseTools: Do not call sys.setdefaultencoding with python 3

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2301

This interface was a originally a no-op in python 3, and now is fully removed causing a build warning on macOS (Darwin).

Signed-off-by: Vitaly Cheptsov <vit9696@protonmail.com>>
---
 BaseTools/Source/Python/sitecustomize.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/sitecustomize.py b/BaseTools/Source/Python/sitecustomize.py
index 7dbbf8a232..50783e1b3a 100644
--- a/BaseTools/Source/Python/sitecustomize.py
+++ b/BaseTools/Source/Python/sitecustomize.py
@@ -7,7 +7,7 @@
 import sys
 import locale
 
-if sys.platform == "darwin":
+if sys.platform == "darwin" and sys.version_info[0] < 3:
   DefaultLocal = locale.getdefaultlocale()[1]
   if DefaultLocal is None:
     DefaultLocal = 'UTF8'
--
2.21.0 (Apple Git-122)


-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49253): https://edk2.groups.io/g/devel/message/49253
Mute This Topic: https://groups.io/mt/35942396/1768742
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [bob.c.feng@intel.com]
-=-=-=-=-=-=

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Do not call sys.setdefaultencoding with python 3

[Bob Feng]

Pushed at 5c7006c9de4029afc508e2c43d78de12a0d19cfe

-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Vitaly Cheptsov via Groups.Io
Sent: Sunday, October 20, 2019 6:26 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH v1 1/1] BaseTools: Do not call sys.setdefaultencoding with python 3

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2301

This interface was a originally a no-op in python 3, and now is fully removed causing a build warning on macOS (Darwin).

Signed-off-by: Vitaly Cheptsov <vit9696@protonmail.com>>
---
 BaseTools/Source/Python/sitecustomize.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/sitecustomize.py b/BaseTools/Source/Python/sitecustomize.py
index 7dbbf8a232..50783e1b3a 100644
--- a/BaseTools/Source/Python/sitecustomize.py
+++ b/BaseTools/Source/Python/sitecustomize.py
@@ -7,7 +7,7 @@
 import sys
 import locale
 
-if sys.platform == "darwin":
+if sys.platform == "darwin" and sys.version_info[0] < 3:
   DefaultLocal = locale.getdefaultlocale()[1]
   if DefaultLocal is None:
     DefaultLocal = 'UTF8'
--
2.21.0 (Apple Git-122)


-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49253): https://edk2.groups.io/g/devel/message/49253
Mute This Topic: https://groups.io/mt/35942396/1768742
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [bob.c.feng@intel.com]
-=-=-=-=-=-=