From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web11.661.1571668765434186790 for ; Mon, 21 Oct 2019 07:39:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=jHe39nhr; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id o28so14292478wro.7 for ; Mon, 21 Oct 2019 07:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=1RVZ2jnDgkTGZQ5efKjdhPFqQ2z6EI6ajfQPfnCMmoM=; b=jHe39nhr+FJyO8Hhf9JUzk9KETmcuSh6IqSAII5a5C87q+LEdyKajolne4C/JigiLJ Pw6huqhfiO4KIe8z/U0Ot33L/VrpXShnsj81FzOkYY8HwCoMGX7bEh/1JRgs82QNshDU FDtpGU/F6+bG+3cIJwO5KLKM2CBSQAd1sAUZtwOm/dvlGeUkhKSElUy33GssDcaMVxsz 8MX9i6QR+gD3KtmHqXFLB4cofFLS4Bk5ur3dSFFXaw3rATnSoiiDj7Q3GnGQ4eO+jl3b lt3f9Dyt/jXFqM02gYY8CKTzvsyE/uxK5UGQMPL7BcA+WbdE/MAdt8h/LA2uHiOUhImw Ausw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=1RVZ2jnDgkTGZQ5efKjdhPFqQ2z6EI6ajfQPfnCMmoM=; b=mpbUQm2eTflftJmKrhbcTvNuyKSOIJ6Q638JT7zfQkkxKFoUHZWpa0P80YeQ+pi1+w /RrHszq03jzFvefM+aGy1D3fHfhiGtM0zdUu3UJFVhnzooOk/RhNbNx8p9bWtdbd79BX T3zUZvEV45yMDauJQSkdsZ4HZLDML2iZOQArXNFlMoGPMVV2SFUt9Vok4V8CIwOA0nqs 7M2b+igm0ILS9S3RpnaoN0Y20yo98DKXA4qilcan5cnY2Tgx7dnn4hRDE4RmNsekk8UJ GS+TVV/BDY3nuxlm7bZ2sr45oeuTq72GiQ3nE7bsaETJMQwFlFVm1RhyCO7ut73OCJ+6 d05g== X-Gm-Message-State: APjAAAU8eofnxbwlMqD7zi3Ojer+NZIGSnBNQGQv9/0jzkBgEVgXsWuI xX7WYyk1zECL5ZHS3L9JIdB+4g== X-Google-Smtp-Source: APXvYqz6b9x4ZjMgkIf/9IIaqy6g7CvbdbTXsFGdVgmIITtRpM15h70PdBTlX7J8eXYv8dD2oFfdCQ== X-Received: by 2002:a05:6000:11cd:: with SMTP id i13mr19478851wrx.197.1571668764002; Mon, 21 Oct 2019 07:39:24 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c16sm1492663wrw.32.2019.10.21.07.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 07:39:23 -0700 (PDT) Date: Mon, 21 Oct 2019 15:39:22 +0100 From: "Leif Lindholm" To: Pete Batard Cc: Ard Biesheuvel , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , edk2-devel-groups-io Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RPi3: Restructure platform in preparation for Pi 4 Message-ID: <20191021143922.GE16820@bivouac.eciton.net> References: <20191021112506.1456-1-pete@akeo.ie> <6baf8d74-3639-593c-419a-c4e8d4e6b7d0@redhat.com> <1a295e8f-a679-0a03-283a-850e93c97bab@akeo.ie> <20191021134628.GC16820@bivouac.eciton.net> <240b08f4-e91e-8003-f7a6-5b0e1169b4b6@akeo.ie> MIME-Version: 1.0 In-Reply-To: <240b08f4-e91e-8003-f7a6-5b0e1169b4b6@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Oct 21, 2019 at 03:28:37PM +0100, Pete Batard wrote: > Hi Leif, > > On 2019.10.21 14:46, Leif Lindholm wrote: > > On Mon, Oct 21, 2019 at 03:24:47PM +0200, Ard Biesheuvel wrote: > > > On Mon, 21 Oct 2019 at 15:09, Philippe Mathieu-Daudé wrote: > > > > > If anything, I guess we could consider that the non-osi patch should > > > > > come first. Still, whatever we do here, as long as only one of non-osi > > > > > and platform is applied, builds are going to be broken, and there is no > > > > > way to fix that unless you do consider the set of platforms + non-osi as > > > > > a single patch. > > > > > > > > Agreed, this is a egg/chicken problem. > > > > > > I dealt with this in the past by just making sure the non-osi and > > > platform changes are applied at the same time. So it is good to make > > > note of this in the cover letter, but other than that, there is no way > > > we can apply interdependent changes to two separate repositories at > > > the same time without either breaking bisect for one of them, or > > > making a huge effort to add temporary code, defines etc that will be > > > removed again right after the changes have landed. > > > > Agreed. My preference would be to treat edk2-non-osi as the chicken, > > and edk2-platforms the egg. I could put the requisite edk2-non-osi > > hash into the edk2-platforms commit message before pushing, adding a > > line like: > > > > "This commit requires the edk2-non-osi in use to contain commit > > in order to build." > > > > If I'm feeling nitpicky, that could replace the comment > > "No other changes are being applied at this stage." > > > > Pete: would you be OK with those two changes? > > Sounds good. Feel free to go ahead with these changes, thanks. In that case: Reviewed-by: Leif Lindholm Pushed as 03f36b8fcfb7. Thanks! Do you know when the Pi4 upstreaming is likely to start? As you may have seen from my autoresponder, I'm traveling this week and next. Best Regards, Leif (from the backseat of a car going down the M25)