From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by mx.groups.io with SMTP id smtpd.web09.3010.1571737845394500986 for ; Tue, 22 Oct 2019 02:50:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@citrix.com header.s=securemail header.b=Ed1uxUWL; spf=pass (domain: citrix.com, ip: 216.71.155.168, mailfrom: anthony.perard@citrix.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1571737845; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/dOOmkiOs0cnyJVCjT1vjLsKZ8X2Ge/ZoaD9xHDX5lE=; b=Ed1uxUWLJvqkz/yOUvdG2oz1I4MHSUNyUwAdkhuBy6Vj5gy6aILWV7ZD MoiiT1QuypcebG3LT2sSmWzNPpR5K6brbzMsKKbpxepXuQjjpSg34plzB UdmecptPOh88HV19xfz/2bc4khUdiY6ENwuEgHDxZ+UWnoJ+2rmBgbeRo c=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: p9yMbnRcujDIXo66IN9bGw6Rsstj14rbYTLoxOwTGFxBGhiUWUMew7Ci4WuPCfZyd6+blY5RpH UdDWML7OiXCS6cHsenA/GLpJt3WYfPYiIVerUeHk3z/t7bdLAKXK5Y67HDEve4ZjR1/7TmINN2 paaKepAPkLu0jEvmKZ7u7JmYgNIEKHljfVS3K/UkEfSX0tT3/mqc+d4algMx3ZSSWlhnkMYUSB UfEL0F5imeFPu6KlacQrjSGDRech3+9ul1TtKI7kSr0KwiyDIaH566F8ozrKgX4of3uOovPR21 Ztc= X-SBRS: 2.7 X-MesageID: 7548030 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.67,326,1566878400"; d="scan'208";a="7548030" Date: Tue, 22 Oct 2019 10:50:42 +0100 From: "Anthony PERARD" To: Laszlo Ersek CC: edk2-devel-groups-io , Andrew Fish , Ard Biesheuvel , Jordan Justen , Julien Grall , Leif Lindholm , Michael Kinney , Peter Jones Subject: Re: [PATCH v2] OvmfPkg: Make SOURCE_DEBUG_ENABLE actually need to be set to TRUE Message-ID: <20191022095042.GJ1138@perard.uk.xensource.com> References: <20191021201320.24413-1-lersek@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191021201320.24413-1-lersek@redhat.com> User-Agent: Mutt/1.12.2 (2019-09-21) Return-Path: anthony.perard@citrix.com Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Mon, Oct 21, 2019 at 10:13:20PM +0200, Laszlo Ersek wrote: > From: Peter Jones > > Currently some tests check the value of SOURCE_DEBUG_ENABLE, and some > tests check if it's defined or not. Additionally, in UefiPayloadPkg as > well as some other trees, we define it as FALSE in the .dsc file. > > This patch changes all of the Ovmf platforms to explicitly define it as > FALSE by default, and changes all of the checks to test if the value is > TRUE. > > Signed-off-by: Peter Jones > Message-Id: <20190920184507.909884-1-pjones@redhat.com> > [lersek@redhat.com: drop Contributed-under line, per TianoCore BZ#1373] > [lersek@redhat.com: replace "!= TRUE" with more idiomatic "== FALSE"] > Cc: Andrew Fish > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Leif Lindholm > Cc: Michael Kinney > Cc: Peter Jones > Signed-off-by: Laszlo Ersek Acked-by: Anthony PERARD Thanks, -- Anthony PERARD