From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web10.6965.1572314484297409745 for ; Mon, 28 Oct 2019 19:01:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=kFg2q0sF; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id o28so11880981wro.7 for ; Mon, 28 Oct 2019 19:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5Q5McvBRyYmVYAuU5KTcgf7Ex6/h0OfDjdi52BCuuTA=; b=kFg2q0sFg9rGjK3IzCbxUcMpeYIxAu2D+rpzM1k/YSSXaQHFLRBvc85c4yTMAwk0SL VNU22d2GYvnqF+fzXG7fdyayUKySnwLtBa4OV+MfBSjTiXuL18bcML7u4cO9+pC0o2Kj HG7mtL35IsUjSYFqVPIfl0Q6PudwcAZvGechVLntuDwAtfzkLqshvZ0lpqv3jLkrtp3m qhqYhFK5pe/bXTX528QsVXNx5l/PRzqHnq5xRXkIkn9TpVKZK8BCoDID41bWhGp54xqx gs2lJ3uofgeMoiTaGz+xAc1YXkQQBoqf558xbseaxGv8HhNAQI88wGeBlba7haHojALs cXoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5Q5McvBRyYmVYAuU5KTcgf7Ex6/h0OfDjdi52BCuuTA=; b=QHaHJG5n8LA/g127XXmm0SoyixeF6f3JO4hHfzJYYEoulFbo4IYMyV7Ccmib4th5Z0 qQhgmGEhjOscFdm/iYbg1T1tZ8FnfGTgUurRfA3ynEqj0IlZHjyxphMb2o5I1yPML7Fv 6mXL2cNSrvIgYz+Og6vlprSyfp0FtN+taMh7VDKDjEozsNVMeEZDJ26wYUR0bKJ7kWSA nFEUTdyQ3seiUrFqUYanqhBdYvvGUUethPk7778xNVm2FLrIw5RXxmy3yoAkOdA1VeSo XdlT1GFIjPeaX2gGCy3VmpMjGPl+DjuRi9kbgjAQsK1tPSDbIphinN0EXRQ23ipHzhVE nJaQ== X-Gm-Message-State: APjAAAVe9ss3JA9aW8WyPekpaOULYb5QVv2frP2bjDufoQnthXsvAB3l J0vSkqyhTuLdgHn1UcdJsRzlTA== X-Google-Smtp-Source: APXvYqzso/QX2Ts46a/UHI/Rs4w1PFfcrFx1Gatf8dyhsdvFGpW0RJ1E7otQFb0ST9bvf0OTJcXUJA== X-Received: by 2002:adf:f00d:: with SMTP id j13mr16324009wro.253.1572314482780; Mon, 28 Oct 2019 19:01:22 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id l18sm20705354wrn.48.2019.10.28.19.01.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2019 19:01:21 -0700 (PDT) Date: Tue, 29 Oct 2019 02:01:20 +0000 From: "Leif Lindholm" To: Laszlo Ersek Cc: devel@edk2.groups.io, abner.chang@hpe.com, Andrew Fish , Michael D Kinney , Gilbert Chen Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md Message-ID: <20191029020120.GO16820@bivouac.eciton.net> References: <1572227957-13169-1-git-send-email-abner.chang@hpe.com> <1572227957-13169-40-git-send-email-abner.chang@hpe.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 29, 2019 at 02:07:20AM +0100, Laszlo Ersek wrote: > > diff --git a/Readme.md b/Readme.md > > index 27e4ce0..4b3d2a5 100644 > > --- a/Readme.md > > +++ b/Readme.md > > @@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains two submodules > > > > - CryptoPkg/Library/OpensslLib/openssl > > - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 > > +- RiscVPkg/Library/RiscVOpensbiLib/opensbi > > > > The latter one is actually required by previous one. It's inevitable > > in openssl-1.1.1 (since stable201905) for floating point parameter > > This will take an update that's a bit more extensive -- please see "two > submodules" just above the listing, and "latter one" right after the > listing. Adding opensbi in the proposed spot breaks both statements. This suggests the surrounding language should change. Could we merge this to master?: >>From 39f08033c934b3e631c40e373aa6a351323ab4aa Mon Sep 17 00:00:00 2001 From: Leif Lindholm Date: Tue, 29 Oct 2019 09:54:36 +0800 Subject: [PATCH 1/1] Readme.md: remove positional references from submodule description Remove references to the number of submodules in the tree, as well as reword the referring to specific submodules as "former" and "previous". This means we won't need to keep updating the surrounding text if we add/remove submodules. Signed-off-by: Leif Lindholm --- Readme.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Readme.md b/Readme.md index 27e4ce07719b..9bf60bede8ec 100644 --- a/Readme.md +++ b/Readme.md @@ -144,12 +144,12 @@ Signed-off-by: Contributor Name # Submodules Submodule in EDK II is allowed but submodule chain should be avoided -as possible as we can. Currently EDK II contains two submodules +as possible as we can. Currently EDK II contains the following submodules - CryptoPkg/Library/OpensslLib/openssl - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 -The latter one is actually required by previous one. It's inevitable +ArmSoftFloatLib is actually required by OpensslLib. It's inevitable in openssl-1.1.1 (since stable201905) for floating point parameter conversion, but should be dropped once there's no such need in future release of openssl. -- 2.20.1