From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43])
 by mx.groups.io with SMTP id smtpd.web12.616.1572404587132761293
 for <devel@edk2.groups.io>;
 Tue, 29 Oct 2019 20:03:07 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=DS2Uo+cp;
 spf=pass (domain: linaro.org, ip: 209.85.128.43, mailfrom: leif.lindholm@linaro.org)
Received: by mail-wm1-f43.google.com with SMTP id q70so474862wme.1
        for <devel@edk2.groups.io>; Tue, 29 Oct 2019 20:03:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:subject:message-id:references:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=PFhWJjze2y1K4TIGJttiH5DDzWC2L6Ip7hRWHRklN3o=;
        b=DS2Uo+cpzYSoa8yA2QVCv7Nhm5X7bB6SxwbWmXBl6qqSlmFptLFMzh7h1+2TD2W6xp
         vcWRk6L1EVJhv4NqGxOktmtrlK51XhwGw58qAn/RMHIbEqbCWrRzONidtjByc1mSwpUP
         W7Hc0KPdb5TrjHV/NZa3F7hvWN9sp+oYYEdeP4/qhUGe3CxBRw4WssFDjFLmMihRhJ0c
         VkWPYBphgk1sHaOMYaK6oMLwOohY65kD1yg6qarstzRWUUk6zKRIZMrUkNCBd85PzeYx
         e1y/SlHWl059ztmTiOmEM6aJUjzk0YfsvOqgAswIGpOFLJ4lTcakxsTqEKg0Xlpkzvaa
         985w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:subject:message-id:references
         :mime-version:content-disposition:content-transfer-encoding
         :in-reply-to:user-agent;
        bh=PFhWJjze2y1K4TIGJttiH5DDzWC2L6Ip7hRWHRklN3o=;
        b=frHZQvap15AK8hnvDv3zBhhIWkhKs0rpmobAqVSTDXxxPg+lDu2xWPPSymk4YlbhVC
         TqB2F3DRi4a9j7DuyIKD7LalJUyzzmgMUXGD35dfMP7Y5Opw0wzXoiLPBk5k6t0bk/Q7
         S8cgHGajqPGRzmeBHqaalrPo9FGOfMEYwqAmVODTeUvOMMbiNUNadgCDh3CKnQnD7rpy
         sY2XmWSVJErIv8933l10y22FhPtCKXJ1m/ABpQuSKAIFTUCOFIRA6McmFZD4SOOqiWar
         7vzSs4OYBRt2FUE0shaRZa7Pdl8VxCC9vymyej46dmjm7YQyWiietU6h64OibB0S8hV+
         kijA==
X-Gm-Message-State: APjAAAWn10XOa97O0E5TZREqTBECssbCyz2mpNxiEyn3VAxXedqeUn3a
	syMEl5QONiLBK6WRKMd4wXne0anVC5ImMQ==
X-Google-Smtp-Source: APXvYqwH/XDRhmtwc6Be5Z+y8RZuIMIzC0FhJLc7L07m9sKsUC/kw0QcDH4VqOBcster4Id5rCfAqg==
X-Received: by 2002:a7b:cb81:: with SMTP id m1mr6257162wmi.123.1572404585294;
        Tue, 29 Oct 2019 20:03:05 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id z13sm943091wrm.64.2019.10.29.20.03.04
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 29 Oct 2019 20:03:04 -0700 (PDT)
Date: Wed, 30 Oct 2019 03:03:02 +0000
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, sean.brogan@microsoft.com
Subject: Re: [edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file
Message-ID: <20191030030302.GW16820@bivouac.eciton.net>
References: <20191030022757.GS16820@bivouac.eciton.net>
 <2748.1572403968433015098@groups.io>
MIME-Version: 1.0
In-Reply-To: <2748.1572403968433015098@groups.io>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

OK, if it makes a difference for tools (and security updates), let's
try to keep it. (*grumble*)

*But* given its too-generic name, can we add a big bold comment header
to the file explaining what it is?
Some quick searching suggests lines starting with # are ignored, so
hopefully this should be possible?

Best Regards,

Leif

On Tue, Oct 29, 2019 at 07:52:48PM -0700, Sean via Groups.Io wrote:
> It is a convention for projects using python.  It definitely isn't required but there are some features that come for free when using that filename.
> 
> https://github.blog/2018-07-12-security-vulnerability-alerts-for-python/
> and
> https://help.github.com/en/github/visualizing-repository-data-with-graphs/listing-the-packages-that-a-repository-depends-on
> 
> You can also get more insight from github into dependencies and dependents.
> example: https://github.com/tianocore/edk2-pytool-extensions/network/dependencies
> 
> I did notice on the example from above that github picked up the requirements.publisher.txt so i don't know what their pattern matching does exactly.
> 
> 
>