public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhang, Shenglei" <shenglei.zhang@intel.com>
To: devel@edk2.groups.io
Cc: Hao A Wu <hao.a.wu@intel.com>, Ray Ni <ray.ni@intel.com>
Subject: [PATCH v2 2/3] MdeModulePkg/UhciPei: Initialize the variable RequestMap
Date: Wed, 30 Oct 2019 22:08:29 +0800	[thread overview]
Message-ID: <20191030140830.31156-3-shenglei.zhang@intel.com> (raw)
In-Reply-To: <20191030140830.31156-1-shenglei.zhang@intel.com>

RequestMap is used but not Initialized.
RequestMap is called by UhciMapUserRequest, in which RequestMap(Map)
is called by IoMmuMap, and is finally called by IoMmu->Map.
We can not assume RequestMap is given an initial value at any step.

Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c
index b897c3f82ce6..a05834da3c4a 100644
--- a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c
+++ b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c
@@ -274,6 +274,8 @@ UhcControlTransfer (
 
   PktID       = INPUT_PACKET_ID;
 
+  RequestMap  = NULL;
+
   if (Request == NULL || TransferResult == NULL) {
     return EFI_INVALID_PARAMETER;
   }
-- 
2.18.0.windows.1


  parent reply	other threads:[~2019-10-30 14:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 14:08 [PATCH v2 0/3] MdeModulePkg: Initialize variables Zhang, Shenglei
2019-10-30 14:08 ` [PATCH v2 1/3] MdeModulePkg/EhciPei: Initialize the variable Map Zhang, Shenglei
2019-10-31  1:59   ` Wu, Hao A
2019-10-30 14:08 ` Zhang, Shenglei [this message]
2019-10-31  1:58   ` [PATCH v2 2/3] MdeModulePkg/UhciPei: Initialize the variable RequestMap Wu, Hao A
2019-10-30 14:08 ` [PATCH v2 3/3] MdeModulePkg/Mem: Initialize the variable MapMemory Zhang, Shenglei
2019-11-01  1:59   ` Dandan Bi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191030140830.31156-3-shenglei.zhang@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox