From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web11.5091.1572524206134563299 for ; Thu, 31 Oct 2019 05:16:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=XFSMrLI2; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: by mail-wm1-f67.google.com with SMTP id v3so6457878wmh.1 for ; Thu, 31 Oct 2019 05:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G/IqH1evqdQDQWvypjH6XFMChfsbLqH/VY6IBpjvR7Y=; b=XFSMrLI2HJoFtOcrB4+WKhACfegNIQhqNCj5N8XJpzImm0C9xcMlUCM34DKUiTfgtn +xP6/9i7unFy5/ItnxUqqV9Dioe3lY/eAy4CVqTy/xMAs5wcwRC557xbaUCG9m2PJIDu q2eew1JzsS/HV5FFY7uL8frEaBhsj2mdQpH+cJ6vjEJTsz10cnhzdbcjEqjtHiBrt4AH XCs+HTJvh85RSKcpsjdXt642FXwAGSajYvGWOAz5ouFqxtfjiOEozJid1BZ34uiShqQp FtCy3tcp/2nOTbXfA7/uN+JHXa8KqVcX/vf00GNPzPeqoEMJELXTh8GKLAbf2uYoySwK 9hdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G/IqH1evqdQDQWvypjH6XFMChfsbLqH/VY6IBpjvR7Y=; b=bnT1ocfg5s0vAxHTajFP1PJ99juG+ACLhNgseWet9oytWgJoKEJxmm1fYJAlraBpWz OOOA57V05hUxwLiToEwoRil2jzA+IT3xNTgpNaUy2d33VTRtMgO/itJl9gb4VEHmavun gQkX3fiUQsi3cFp1n5NeLTa5NC+w+hbwdM+9FdcpxBjNyLK/qnnQftDMxa8GA8vl2Ofg rOv6nSPVNS7kSVtBHNXaA+4odII5cQQLYIzokffccRPhSYtM2Y0kV3BMVfR67b57rzeH 6cVls1E62fuugEqsL4R/94RT3MPA1/+YLVPucyQ6nvLCSxXkloKY8TQhAbDJS5+t8HzS up1w== X-Gm-Message-State: APjAAAVD4UDRZ5eUUfgsypOAdmW5OHiUtVu27bUpM0OEYxflBtZNICnR Q72aB46QGIcE9Bm1S+o4Bx3lkQ== X-Google-Smtp-Source: APXvYqwZwWeUSrlkIr+3Dln38prSbB5VgTZcPqglIyP0LUfpRQXBLUgj7QFbOIWsPFgAlSEv880FQQ== X-Received: by 2002:a1c:7ec2:: with SMTP id z185mr4865859wmc.79.1572524204666; Thu, 31 Oct 2019 05:16:44 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 200sm4328188wme.32.2019.10.31.05.16.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2019 05:16:43 -0700 (PDT) Date: Thu, 31 Oct 2019 12:16:42 +0000 From: "Leif Lindholm" To: Laszlo Ersek Cc: devel@edk2.groups.io, prabhakar.pkin@gmail.com, Ard Biesheuvel , naresh.bhat@linaro.org, dann.frazier@canonical.com Subject: Re: [edk2-devel] How /sys/firmware/fdt getting created Message-ID: <20191031121642.GA16820@bivouac.eciton.net> References: <2b268378-d9be-adb5-f139-a0ca8dab4329@redhat.com> MIME-Version: 1.0 In-Reply-To: <2b268378-d9be-adb5-f139-a0ca8dab4329@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 31, 2019 at 11:07:52AM +0100, Laszlo Ersek wrote: > +Leif, comment at bottom Thanks Laszlo. +Dann, -kexec. > On 10/30/19 09:16, Prabhakar Kushwaha wrote: > >> So if you want to add these properties, you should add them there. > >> > >> Can you explain why doing this is necessary? > > > > I am trying to test kexec -p (kdump feature) on CentOS-release > > 7.7.1908 and Ubuntu-18.04 distributions. > > > > "kexec -p" command show error on Ubuntu. While no error on CentOS > > > > CentOS: > > $ kexec -p /boot/vmlinuz-`uname -r` --initrd=/boot/initramfs-`uname > > -r`.img --reuse-cmdline > > $ ==> No error > > > > Ubuntu > > $ kexec -p /boot/vmlinuz-`uname -r` --initrd=/boot/initrd.img-`uname > > -r` --reuse-cmdline > > $ kexec: elfcorehdr doesn't fit cells-size. > > $ kexec: setup_2nd_dtb failed. > > $ kexec: load failed. > > $ Cannot load /boot/vmlinuz-5.4.0-rc4+ > > > > Note: Both CentOS and Ubuntu has Linux-5.4-rc4 tag. > > > > When i debugged further reason for Ubuntu error is due to > > address-cells and size-cells as "1" > > log from kexec tool :- > > load_crashdump_segments: elfcorehdr 0x7f7cbfc000-0x7f7cbff7ff > > read_1st_dtb: found name =dtb_sys /sys/firmware/fdt > > get_cells_size: #address-cells:1 #size-cells:1 > > > > On CentOS both values are "2". > > log from kexec tool :- > > load_crashdump_segments: elfcorehdr 0xbf98bf0000-0xbf98bf33ff > > read_1st_dtb: found nmae=dtb_sys /sys/firmware/fdt > > get_cells_size: #address-cells:2 #size-cells:2 > > > > Note: Kexec tool read values from /sys/firmware/fdt. > > > > I am trying to figure out why 2 distributions showing different values. > > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=347210a5d5ce655b95315f320faa515afb723c11 > > Ubuntu probably ships a grub version that lacks this commit. Yes, it came after the 18.04 release. Dann: given that 18.04 is LTS, would it be reasonable to cherry-pick this grub patch? I would consider the behaviour without it to be a bug. / Leif > (The commit was first released as part of upstream grub-2.04. I have no > idea what version of grub is shipped in the CentOS distro you mention > above -- it could be based upon upstream 2.04, or the upstream patch may > have been backported to CentOS.) > > Thanks > Laszlo >